From: David Lechner <dlechner@baylibre.com>
To: "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
"jic23@kernel.org" <jic23@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH v6 8/8] iio: adc: ad4851: add ad485x driver
Date: Thu, 14 Nov 2024 08:47:36 -0600 [thread overview]
Message-ID: <6c034f2c-1f07-4dfb-8e65-dbf41e803f01@baylibre.com> (raw)
In-Reply-To: <CY4PR03MB3399FA960416CEC64E1FFF929B5B2@CY4PR03MB3399.namprd03.prod.outlook.com>
On 11/14/24 4:39 AM, Miclaus, Antoniu wrote:
>> On 11/11/24 6:12 AM, Antoniu Miclaus wrote:
>>> Add support for the AD485X a fully buffered, 8-channel simultaneous
>>> sampling, 16/20-bit, 1 MSPS data acquisition system (DAS) with
>>> differential, wide common-mode range inputs.
>>>
>>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
>>> ---
>>> changes in v6 (implemented most of the review comments in v5):
>> What is the plan for addressing the rest of the comments?
> For the rest of the comments I think I replied inline in the previous series.
>
I didn't look very close yet, but at a quick glance, I saw that all
scan_type are still only signed, there is no unsigned for when the
channels are used as single-ended. And the scan_index ordering is
still wrong. This makes me doubt that buffered reads are working
correctly for all configurations.
next prev parent reply other threads:[~2024-11-14 14:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 12:11 [PATCH v6 0/8] *** Add support for AD485x DAS Family *** Antoniu Miclaus
2024-11-11 12:11 ` [PATCH v6 1/8] iio: backend: add API for interface get Antoniu Miclaus
2024-11-11 12:11 ` [PATCH v6 2/8] iio: backend: add support for data size set Antoniu Miclaus
2024-11-11 12:11 ` [PATCH v6 3/8] iio: backend: add API for oversampling Antoniu Miclaus
2024-11-11 15:41 ` Nuno Sá
2024-11-23 16:02 ` Jonathan Cameron
2024-11-23 16:05 ` Jonathan Cameron
2024-11-11 12:11 ` [PATCH v6 4/8] iio: adc: adi-axi-adc: add interface type Antoniu Miclaus
2024-11-11 12:12 ` [PATCH v6 5/8] iio: adc: adi-axi-adc: set data format Antoniu Miclaus
2024-11-12 20:11 ` David Lechner
2024-11-11 12:12 ` [PATCH v6 6/8] iio: adc: adi-axi-adc: add oversampling Antoniu Miclaus
2024-11-12 20:12 ` David Lechner
2024-11-23 16:04 ` Jonathan Cameron
2024-11-11 12:12 ` [PATCH v6 7/8] dt-bindings: iio: adc: add ad4851 Antoniu Miclaus
2024-11-11 12:12 ` [PATCH v6 8/8] iio: adc: ad4851: add ad485x driver Antoniu Miclaus
2024-11-12 20:02 ` David Lechner
2024-11-14 10:39 ` Miclaus, Antoniu
2024-11-14 14:47 ` David Lechner [this message]
2024-11-15 10:59 ` Miclaus, Antoniu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c034f2c-1f07-4dfb-8e65-dbf41e803f01@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Antoniu.Miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox