Re: [PATCH v2 6/6] arm64: dts: qcom: sm8350-lemonade(p): new devices

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 18/10/2023 16:43, Nia Espera wrote:
> 
> On 10/18/23 16:34, Krzysztof Kozlowski wrote:
>> On 18/10/2023 16:25, Nia Espera wrote:
>>> Device tree files for OnePlus 9 and 9 Pro. Details of supported features
>>> mentioned in the cover letter for this patch series, but for
>>> accessibility also repeated here:
>>>
>>
>> ...
>>
>>> +	/* tp_rst_suspend pinctrl is different per device, don't specify here */
>>> +
>>> +	tp_irq_active: tp-irq-active-state {
>>> +		pins = "gpio23";
>>> +		function = "gpio";
>>> +		drive-strength = <8>;
>>> +		bias-disable;
>>> +		input-enable;
>>
>> It does not look like you tested the DTS against bindings. Please run
>> `make dtbs_check W=1` (see
>> Documentation/devicetree/bindings/writing-schema.rst or
>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
>> for instructions).
> 
> I noticed that dtbs_check was unhappy here, but I figured it's okay to 
> ignore that since it didn't complain in other places (e.g. lines 
> 554-555) and assumed the error was just a bug in the yaml. Sorry!

There are no other DTS having this property for TLMM, so you could not
have seen this in other boards.

Best regards,
Krzysztof