From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nia Espera <nespera@igalia.com>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, phone-devel@vger.kernel.org,
Rob <Me@orbit.sh>, Clayton Craft <clayton@igalia.com>,
Caleb Connolly <caleb.connolly@linaro.org>,
Luca Weiss <luca.weiss@fairphone.com>,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 5/6] dt-bindings: arm: qcom: add oneplus-lemonade(p) bindings
Date: Wed, 18 Oct 2023 16:32:05 +0200 [thread overview]
Message-ID: <8bc3e567-01c2-4258-9d4a-c922539ac2be@linaro.org> (raw)
In-Reply-To: <20231018-nia-sm8350-for-upstream-v2-5-7b243126cb77@igalia.com>
On 18/10/2023 16:25, Nia Espera wrote:
> Document the devicetree bindings for oneplus-lemonade and oneplus-lemonadep.
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
>
> Signed-off-by: Nia Espera <nespera@igalia.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index adbfaea32343..72832ee5b876 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -974,6 +974,8 @@ properties:
> - qcom,sm8350-mtp
> - sony,pdx214-generic
> - sony,pdx215-generic
> + - oneplus,lemonade
> + - oneplus,lemonadep
Wrong order. 'o' does not go after 's'.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-18 14:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 14:25 [PATCH v2 0/6] support oneplus-lemonade(p) devices Nia Espera
2023-10-18 14:25 ` [PATCH v2 1/6] iio: adc: add smb139x bindings Nia Espera
2023-10-18 14:30 ` Krzysztof Kozlowski
2023-10-18 14:25 ` [PATCH v2 2/6] arm64: dts: qcom: sm8350: Fix DMA0 address Nia Espera
2023-10-18 14:25 ` [PATCH v2 3/6] arm64: dts: qcom: pm8350k: remove hanging whitespace Nia Espera
2023-10-18 14:25 ` [PATCH v2 4/6] arm64: dts: qcom: sm8350: Fix remoteproc interrupt type Nia Espera
2023-10-18 20:17 ` Konrad Dybcio
2023-10-18 20:21 ` Luca Weiss
2023-10-19 4:06 ` Manivannan Sadhasivam
2023-10-21 17:44 ` Konrad Dybcio
2023-10-21 19:34 ` Luca Weiss
2023-10-23 13:59 ` Konrad Dybcio
2023-10-18 14:25 ` [PATCH v2 5/6] dt-bindings: arm: qcom: add oneplus-lemonade(p) bindings Nia Espera
2023-10-18 14:32 ` Krzysztof Kozlowski [this message]
2023-10-18 14:25 ` [PATCH v2 6/6] arm64: dts: qcom: sm8350-lemonade(p): new devices Nia Espera
2023-10-18 14:34 ` Krzysztof Kozlowski
2023-10-18 14:43 ` Nia Espera
2023-10-18 14:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bc3e567-01c2-4258-9d4a-c922539ac2be@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Me@orbit.sh \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=clayton@igalia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=jic23@kernel.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=nespera@igalia.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox