From: Lars-Peter Clausen <lars@metafoo.de>
To: Matt Ranostay <mranostay@gmail.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] iio: chemical: ams-iaq-core: update driver name and DT match table
Date: Wed, 3 Aug 2016 22:08:51 +0200 [thread overview]
Message-ID: <73ab649b-e28f-6783-b4e7-aeb07c839859@metafoo.de> (raw)
In-Reply-To: <CAKzfze8vkmGwEX5Us4+K83pJp8vocgZfGVXDmivn+HYfe6hcrg@mail.gmail.com>
On 08/03/2016 10:02 PM, Matt Ranostay wrote:
> On Wed, Aug 3, 2016 at 5:13 AM, Lars-Peter Clausen <lars@metafoo.de> wrote:
>> On 08/02/2016 06:25 AM, Matt Ranostay wrote:
>>> DT match name should be similar to the i2c device table entry.
>>
>> Why?
>
> To be consistent mostly. But I have noticed compatible =
> "ams,iaq-core" doesn't actually match...
Well, consistent with what? The normal pattern for devicetree compatible
strings is vendor,partname. So that would suggest that ams,iaq-core is the
preferred solution if it is supposed to be consistent. Btw. there seem to be
no binding documents for this part.
> Does anyone here know if i2c-core just checks the id_table, and not
> of_match_table as well?
>
> Anyone have thoughts on this but I dig into this too deep?
It uses of_match_table when it is set. See
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/i2c/i2c-core.c#n609
next prev parent reply other threads:[~2016-08-03 20:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 4:25 [PATCH] iio: chemical: ams-iaq-core: update driver name and DT match table Matt Ranostay
2016-08-03 12:13 ` Lars-Peter Clausen
2016-08-03 20:02 ` Matt Ranostay
2016-08-03 20:08 ` Lars-Peter Clausen [this message]
2016-08-04 2:25 ` Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73ab649b-e28f-6783-b4e7-aeb07c839859@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mranostay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox