[PATCH v3 0/8] iio: adc: ad7606: Improvements

[PATCH v3 0/8] iio: adc: ad7606: Improvements

[Guillaume Stols]

This series adds the following improvements over the current AD7606's
driver implementation:

- Fix wrong usage of gpio array
- Fix standby that was documented as ACTIVE_LOW but handled in the
  driver as if it was ACTIVE_HIGH
- Improve dt-bindings documentation
- Switch mutex lock to scoped guard

Signed-off-by: Guillaume Stols <gstols@baylibre.com>
---
Changes in v3:
- Remove the two first patches that were already picked up.
- Add styling corrections.
- [Patch 6/8] Improve commit message.
- [Patch 8/8] Replace every scoped_guard by simple guard.
- Link to v2: https://lore.kernel.org/r/20240628-cleanup-ad7606-v2-0-96e02f90256d@baylibre.com

Changes in v2:
- Change scoped guard to guard(mutex)(&st->lock). This was tested with
  Rob's bot condition, and seems not to generate warning anymore.
- Reorder the commits for avoiding bisection issues and respect commit
  priority rules.
- Add vdrive-supply to required properties.
- Separate cosmetic changes from content ones in dt-binding
  descriptions.
- Move maxItems changes (and plural in descriptions) to the commit that
  adds conditions.
- Link to v1: https://lore.kernel.org/r/20240618-cleanup-ad7606-v1-0-f1854d5c779d@baylibre.com

---
Guillaume Stols (8):
      dt-bindings: iio: adc: adi,ad7606: normalize textwidth
      dt-bindings: iio: adc: adi,ad7606: improve descriptions
      dt-bindings: iio: adc: adi,ad7606: add supply properties
      dt-bindings: iio: adc: adi,ad7606: fix example
      dt-bindings: iio: adc: adi,ad7606: add conditions
      iio: adc: ad7606: fix oversampling gpio array
      iio: adc: ad7606: fix standby gpio state to match the documentation
      iio: adc: ad7606: switch mutexes to scoped_guard

 .../devicetree/bindings/iio/adc/adi,ad7606.yaml    | 123 ++++++++++++++++-----
 drivers/iio/adc/ad7606.c                           |  47 ++++----
 drivers/iio/adc/ad7606_spi.c                       |   5 +-
 3 files changed, 115 insertions(+), 60 deletions(-)
---
base-commit: 340fa834ae229a952db04a57ed13fd5d35d75818
change-id: 20240416-cleanup-ad7606-161e2ed9818b

Best regards,
-- 
Guillaume Stols <gstols@baylibre.com>

[PATCH v3 1/8] dt-bindings: iio: adc: adi,ad7606: normalize textwidth

[Guillaume Stols]

Normalize textwidth to 80 columns on the descriptions.

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Guillaume Stols <gstols@baylibre.com>
---
 .../devicetree/bindings/iio/adc/adi,ad7606.yaml    | 50 +++++++++++-----------
 1 file changed, 24 insertions(+), 26 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
index 00fdaed11cbd..32caa9fc00e4 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
@@ -40,60 +40,58 @@ properties:
 
   adi,conversion-start-gpios:
     description:
-      Must be the device tree identifier of the CONVST pin.
-      This logic input is used to initiate conversions on the analog
-      input channels. As the line is active high, it should be marked
-      GPIO_ACTIVE_HIGH.
+      Must be the device tree identifier of the CONVST pin. This logic input is
+      used to initiate conversions on the analog input channels. As the line is
+      active high, it should be marked GPIO_ACTIVE_HIGH.
     maxItems: 1
 
   reset-gpios:
     description:
-      Must be the device tree identifier of the RESET pin. If specified,
-      it will be asserted during driver probe. As the line is active high,
-      it should be marked GPIO_ACTIVE_HIGH.
+      Must be the device tree identifier of the RESET pin. If specified, it will
+      be asserted during driver probe. As the line is active high, it should be
+      marked GPIO_ACTIVE_HIGH.
     maxItems: 1
 
   standby-gpios:
     description:
-      Must be the device tree identifier of the STBY pin. This pin is used
-      to place the AD7606 into one of two power-down modes, Standby mode or
+      Must be the device tree identifier of the STBY pin. This pin is used to
+      place the AD7606 into one of two power-down modes, Standby mode or
       Shutdown mode. As the line is active low, it should be marked
       GPIO_ACTIVE_LOW.
     maxItems: 1
 
   adi,first-data-gpios:
     description:
-      Must be the device tree identifier of the FRSTDATA pin.
-      The FRSTDATA output indicates when the first channel, V1, is
-      being read back on either the parallel, byte or serial interface.
-      As the line is active high, it should be marked GPIO_ACTIVE_HIGH.
+      Must be the device tree identifier of the FRSTDATA pin.  The FRSTDATA
+      output indicates when the first channel, V1, is being read back on either
+      the parallel, byte or serial interface.  As the line is active high, it
+      should be marked GPIO_ACTIVE_HIGH.
     maxItems: 1
 
   adi,range-gpios:
     description:
-      Must be the device tree identifier of the RANGE pin. The polarity on
-      this pin determines the input range of the analog input channels. If
-      this pin is tied to a logic high, the analog input range is ±10V for
-      all channels. If this pin is tied to a logic low, the analog input range
-      is ±5V for all channels. As the line is active high, it should be marked
+      Must be the device tree identifier of the RANGE pin. The polarity on this
+      pin determines the input range of the analog input channels. If this pin
+      is tied to a logic high, the analog input range is ±10V for all channels.
+      If this pin is tied to a logic low, the analog input range is ±5V for all
+      channels. As the line is active high, it should be marked
       GPIO_ACTIVE_HIGH.
     maxItems: 1
 
   adi,oversampling-ratio-gpios:
     description:
-      Must be the device tree identifier of the over-sampling
-      mode pins. As the line is active high, it should be marked
-      GPIO_ACTIVE_HIGH.
+      Must be the device tree identifier of the over-sampling mode pins. As the
+      line is active high, it should be marked GPIO_ACTIVE_HIGH.
     maxItems: 3
 
   adi,sw-mode:
     description:
       Software mode of operation, so far available only for ad7616 and ad7606b.
-      It is enabled when all three oversampling mode pins are connected to
-      high level. The device is configured by the corresponding registers. If the
-      adi,oversampling-ratio-gpios property is defined, then the driver will set the
-      oversampling gpios to high. Otherwise, it is assumed that the pins are hardwired
-      to VDD.
+      It is enabled when all three oversampling mode pins are connected to high
+      level. The device is configured by the corresponding registers. If the
+      adi,oversampling-ratio-gpios property is defined, then the driver will set
+      the oversampling gpios to high. Otherwise, it is assumed that the pins are
+      hardwired to VDD.
     type: boolean
 
 required:

-- 
2.34.1

[PATCH v3 2/8] dt-bindings: iio: adc: adi,ad7606: improve descriptions

[Guillaume Stols]

Reword a few descriptions, and normalize the text width to 80 characters.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Guillaume Stols <gstols@baylibre.com>
---
 .../devicetree/bindings/iio/adc/adi,ad7606.yaml    | 33 +++++++++++++---------
 1 file changed, 20 insertions(+), 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
index 32caa9fc00e4..76fd6df5f9ca 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
@@ -36,6 +36,9 @@ properties:
   avcc-supply: true
 
   interrupts:
+    description:
+      The BUSY pin falling edge indicates that the conversion is over, and thus
+      new data is available.
     maxItems: 1
 
   adi,conversion-start-gpios:
@@ -48,8 +51,9 @@ properties:
   reset-gpios:
     description:
       Must be the device tree identifier of the RESET pin. If specified, it will
-      be asserted during driver probe. As the line is active high, it should be
-      marked GPIO_ACTIVE_HIGH.
+      be asserted during driver probe. On the AD7606x, as the line is active
+      high, it should be marked GPIO_ACTIVE_HIGH. On the AD7616, as the line is
+      active low, it should be marked GPIO_ACTIVE_LOW.
     maxItems: 1
 
   standby-gpios:
@@ -62,36 +66,39 @@ properties:
 
   adi,first-data-gpios:
     description:
-      Must be the device tree identifier of the FRSTDATA pin.  The FRSTDATA
+      Must be the device tree identifier of the FRSTDATA pin. The FRSTDATA
       output indicates when the first channel, V1, is being read back on either
-      the parallel, byte or serial interface.  As the line is active high, it
+      the parallel, byte or serial interface. As the line is active high, it
       should be marked GPIO_ACTIVE_HIGH.
     maxItems: 1
 
   adi,range-gpios:
     description:
-      Must be the device tree identifier of the RANGE pin. The polarity on this
+      Must be the device tree identifier of the RANGE pin. The state on this
       pin determines the input range of the analog input channels. If this pin
       is tied to a logic high, the analog input range is ±10V for all channels.
-      If this pin is tied to a logic low, the analog input range is ±5V for all
-      channels. As the line is active high, it should be marked
+      On the AD760X, if this pin is tied to a logic low, the analog input range
+      is ±5V for all channels. As the line is active high, it should be marked
       GPIO_ACTIVE_HIGH.
     maxItems: 1
 
   adi,oversampling-ratio-gpios:
     description:
       Must be the device tree identifier of the over-sampling mode pins. As the
-      line is active high, it should be marked GPIO_ACTIVE_HIGH.
+      line is active high, it should be marked GPIO_ACTIVE_HIGH. On the AD7606X
+      parts that support it, if all 3 pins are tied to a logic high, software
+      mode is enabled.
     maxItems: 3
 
   adi,sw-mode:
     description:
-      Software mode of operation, so far available only for ad7616 and ad7606b.
+      Software mode of operation, so far available only for AD7616 and AD7606B.
       It is enabled when all three oversampling mode pins are connected to high
-      level. The device is configured by the corresponding registers. If the
-      adi,oversampling-ratio-gpios property is defined, then the driver will set
-      the oversampling gpios to high. Otherwise, it is assumed that the pins are
-      hardwired to VDD.
+      level for the AD7606B, or both the range selection are connected to high
+      level for the AD7616. The device is configured by the corresponding
+      registers. If the adi,oversampling-ratio-gpios property is defined, then
+      the driver will set the oversampling gpios to high. Otherwise, it is
+      assumed that the pins are hardwired to VDD.
     type: boolean
 
 required:

-- 
2.34.1

[PATCH v3 3/8] dt-bindings: iio: adc: adi,ad7606: add supply properties

[Guillaume Stols]

Add voltage supplies

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Guillaume Stols <gstols@baylibre.com>
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
index 76fd6df5f9ca..bb716182db63 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
@@ -35,6 +35,15 @@ properties:
 
   avcc-supply: true
 
+  vdrive-supply:
+    description:
+      Determines the voltage level at which the interface logic pins will
+      operate.
+
+  refin-supply:
+    description:
+      The voltage supply for optional external reference voltage.
+
   interrupts:
     description:
       The BUSY pin falling edge indicates that the conversion is over, and thus
@@ -106,6 +115,7 @@ required:
   - reg
   - spi-cpha
   - avcc-supply
+  - vdrive-supply
   - interrupts
   - adi,conversion-start-gpios
 
@@ -130,6 +140,7 @@ examples:
             spi-cpha;
 
             avcc-supply = <&adc_vref>;
+            vdrive-supply = <&vdd_supply>;
 
             interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
             interrupt-parent = <&gpio>;

-- 
2.34.1

[PATCH v3 4/8] dt-bindings: iio: adc: adi,ad7606: fix example

[Guillaume Stols]

Example uses adi,ad7606-8 as compatible, but adi,sw-mode is not
available for it. So remove this property from example.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Guillaume Stols <gstols@baylibre.com>
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
index bb716182db63..499b6ad5525a 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
@@ -152,7 +152,6 @@ examples:
                                            <&gpio 23 GPIO_ACTIVE_HIGH>,
                                            <&gpio 26 GPIO_ACTIVE_HIGH>;
             standby-gpios = <&gpio 24 GPIO_ACTIVE_LOW>;
-            adi,sw-mode;
         };
     };
 ...

-- 
2.34.1

[PATCH v3 5/8] dt-bindings: iio: adc: adi,ad7606: add conditions

[Guillaume Stols]

Since the driver supports several parts that present differences in
their layout and behaviour, it is necessary to describe the differences
from one chip to another.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Guillaume Stols <gstols@baylibre.com>
---
 .../devicetree/bindings/iio/adc/adi,ad7606.yaml    | 60 +++++++++++++++++++---
 1 file changed, 54 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
index 499b6ad5525a..69408cae3db9 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
@@ -52,10 +52,11 @@ properties:
 
   adi,conversion-start-gpios:
     description:
-      Must be the device tree identifier of the CONVST pin. This logic input is
-      used to initiate conversions on the analog input channels. As the line is
-      active high, it should be marked GPIO_ACTIVE_HIGH.
-    maxItems: 1
+      Must be the device tree identifier of the CONVST pin(s). This logic input
+      is used to initiate conversions on the analog input channels. As the line
+      is active high, it should be marked GPIO_ACTIVE_HIGH.
+    minItems: 1
+    maxItems: 2
 
   reset-gpios:
     description:
@@ -88,8 +89,11 @@ properties:
       is tied to a logic high, the analog input range is ±10V for all channels.
       On the AD760X, if this pin is tied to a logic low, the analog input range
       is ±5V for all channels. As the line is active high, it should be marked
-      GPIO_ACTIVE_HIGH.
-    maxItems: 1
+      GPIO_ACTIVE_HIGH. On the AD7616, there are 2 pins, and if the 2 pins are
+      tied to a logic high, software mode is enabled, otherwise one of the 3
+      possible range values is selected.
+    minItems: 1
+    maxItems: 2
 
   adi,oversampling-ratio-gpios:
     description:
@@ -122,6 +126,50 @@ required:
 allOf:
   - $ref: /schemas/spi/spi-peripheral-props.yaml#
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: adi,ad7616
+    then:
+      properties:
+        adi,first-data-gpios: false
+        standby-gpios: false
+        adi,range-gpios:
+          maxItems: 2
+    else:
+      properties:
+        adi,range-gpios:
+          maxItems: 1
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - adi,ad7605-4
+              - adi,ad7616
+    then:
+      properties:
+        adi,oversampling-ratio-gpios: false
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - adi,ad7605-4
+              - adi,ad7606-4
+              - adi,ad7606-6
+              - adi,ad7606-8
+    then:
+      properties:
+        adi,sw-mode: false
+    else:
+      properties:
+        adi,conversion-start-gpios:
+          maxItems: 1
+
 unevaluatedProperties: false
 
 examples:

-- 
2.34.1

[PATCH v3 6/8] iio: adc: ad7606: fix oversampling gpio array

[Guillaume Stols]

gpiod_set_array_value was misused here: the implementation relied on the
assumption that an unsigned long was required for each gpio, while the
function expects a bit array stored in "as much unsigned long as needed
for storing one bit per GPIO", i.e it is using a bit field.

This leaded to incorrect parameter passed to gpiod_set_array_value, that
would set 1 value instead of 3.
It also prevents to select the software mode correctly for the AD7606B.

Fixes: d2a415c86c6b ("iio: adc: ad7606: Add support for AD7606B ADC")
Fixes: 41f71e5e7daf ("staging: iio: adc: ad7606: Use find_closest() macro")
Signed-off-by: Guillaume Stols <gstols@baylibre.com>
---
 drivers/iio/adc/ad7606.c     | 4 ++--
 drivers/iio/adc/ad7606_spi.c | 5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
index 3a417595294f..8cce1fad9763 100644
--- a/drivers/iio/adc/ad7606.c
+++ b/drivers/iio/adc/ad7606.c
@@ -236,9 +236,9 @@ static int ad7606_write_os_hw(struct iio_dev *indio_dev, int val)
 	struct ad7606_state *st = iio_priv(indio_dev);
 	DECLARE_BITMAP(values, 3);
 
-	values[0] = val;
+	values[0] = val & GENMASK(2, 0);
 
-	gpiod_set_array_value(ARRAY_SIZE(values), st->gpio_os->desc,
+	gpiod_set_array_value(st->gpio_os->ndescs, st->gpio_os->desc,
 			      st->gpio_os->info, values);
 
 	/* AD7616 requires a reset to update value */
diff --git a/drivers/iio/adc/ad7606_spi.c b/drivers/iio/adc/ad7606_spi.c
index 263a778bcf25..287a0591533b 100644
--- a/drivers/iio/adc/ad7606_spi.c
+++ b/drivers/iio/adc/ad7606_spi.c
@@ -249,8 +249,9 @@ static int ad7616_sw_mode_config(struct iio_dev *indio_dev)
 static int ad7606B_sw_mode_config(struct iio_dev *indio_dev)
 {
 	struct ad7606_state *st = iio_priv(indio_dev);
-	unsigned long os[3] = {1};
+	DECLARE_BITMAP(os, 3);
 
+	bitmap_fill(os, 3);
 	/*
 	 * Software mode is enabled when all three oversampling
 	 * pins are set to high. If oversampling gpios are defined
@@ -258,7 +259,7 @@ static int ad7606B_sw_mode_config(struct iio_dev *indio_dev)
 	 * otherwise, they must be hardwired to VDD
 	 */
 	if (st->gpio_os) {
-		gpiod_set_array_value(ARRAY_SIZE(os),
+		gpiod_set_array_value(st->gpio_os->ndescs,
 				      st->gpio_os->desc, st->gpio_os->info, os);
 	}
 	/* OS of 128 and 256 are available only in software mode */

-- 
2.34.1

Re: [PATCH v3 6/8] iio: adc: ad7606: fix oversampling gpio array

[Nuno Sá]

On Tue, 2024-07-02 at 17:34 +0000, Guillaume Stols wrote:
> gpiod_set_array_value was misused here: the implementation relied on the
> assumption that an unsigned long was required for each gpio, while the
> function expects a bit array stored in "as much unsigned long as needed
> for storing one bit per GPIO", i.e it is using a bit field.
> 
> This leaded to incorrect parameter passed to gpiod_set_array_value, that
> would set 1 value instead of 3.
> It also prevents to select the software mode correctly for the AD7606B.
> 
> Fixes: d2a415c86c6b ("iio: adc: ad7606: Add support for AD7606B ADC")
> Fixes: 41f71e5e7daf ("staging: iio: adc: ad7606: Use find_closest() macro")
> Signed-off-by: Guillaume Stols <gstols@baylibre.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

[PATCH v3 7/8] iio: adc: ad7606: fix standby gpio state to match the documentation

[Guillaume Stols]

The binding's documentation specifies that "As the line is active low, it
should be marked GPIO_ACTIVE_LOW". However, in the driver, it was handled
the opposite way. This commit sets the driver's behaviour in sync with the
documentation

Fixes: 722407a4e8c0 ("staging:iio:ad7606: Use GPIO descriptor API")
Signed-off-by: Guillaume Stols <gstols@baylibre.com>
---
 drivers/iio/adc/ad7606.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
index 8cce1fad9763..50ccc245e314 100644
--- a/drivers/iio/adc/ad7606.c
+++ b/drivers/iio/adc/ad7606.c
@@ -443,7 +443,7 @@ static int ad7606_request_gpios(struct ad7606_state *st)
 		return PTR_ERR(st->gpio_range);
 
 	st->gpio_standby = devm_gpiod_get_optional(dev, "standby",
-						   GPIOD_OUT_HIGH);
+						   GPIOD_OUT_LOW);
 	if (IS_ERR(st->gpio_standby))
 		return PTR_ERR(st->gpio_standby);
 
@@ -686,7 +686,7 @@ static int ad7606_suspend(struct device *dev)
 
 	if (st->gpio_standby) {
 		gpiod_set_value(st->gpio_range, 1);
-		gpiod_set_value(st->gpio_standby, 0);
+		gpiod_set_value(st->gpio_standby, 1);
 	}
 
 	return 0;

-- 
2.34.1

Re: [PATCH v3 7/8] iio: adc: ad7606: fix standby gpio state to match the documentation

[Nuno Sá]

On Tue, 2024-07-02 at 17:34 +0000, Guillaume Stols wrote:
> The binding's documentation specifies that "As the line is active low, it
> should be marked GPIO_ACTIVE_LOW". However, in the driver, it was handled
> the opposite way. This commit sets the driver's behaviour in sync with the
> documentation
> 
> Fixes: 722407a4e8c0 ("staging:iio:ad7606: Use GPIO descriptor API")
> Signed-off-by: Guillaume Stols <gstols@baylibre.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

[PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard

[Guillaume Stols]

Switching to scoped_guard simplifies the code and avoids to take care to
unlock the mutex in case of premature return.

Signed-off-by: Guillaume Stols <gstols@baylibre.com>
---
 drivers/iio/adc/ad7606.c | 39 +++++++++++++++------------------------
 1 file changed, 15 insertions(+), 24 deletions(-)

diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
index 50ccc245e314..539e4a8621fe 100644
--- a/drivers/iio/adc/ad7606.c
+++ b/drivers/iio/adc/ad7606.c
@@ -69,19 +69,17 @@ static int ad7606_reg_access(struct iio_dev *indio_dev,
 	struct ad7606_state *st = iio_priv(indio_dev);
 	int ret;
 
-	mutex_lock(&st->lock);
+	guard(mutex)(&st->lock);
+
 	if (readval) {
 		ret = st->bops->reg_read(st, reg);
 		if (ret < 0)
-			goto err_unlock;
+			return ret;
 		*readval = ret;
-		ret = 0;
+		return 0;
 	} else {
-		ret = st->bops->reg_write(st, reg, writeval);
+		return st->bops->reg_write(st, reg, writeval);
 	}
-err_unlock:
-	mutex_unlock(&st->lock);
-	return ret;
 }
 
 static int ad7606_read_samples(struct ad7606_state *st)
@@ -124,19 +122,19 @@ static irqreturn_t ad7606_trigger_handler(int irq, void *p)
 	struct ad7606_state *st = iio_priv(indio_dev);
 	int ret;
 
-	mutex_lock(&st->lock);
+	guard(mutex)(&st->lock);
 
 	ret = ad7606_read_samples(st);
-	if (ret == 0)
-		iio_push_to_buffers_with_timestamp(indio_dev, st->data,
-						   iio_get_time_ns(indio_dev));
+	if (ret)
+		goto error_ret;
 
+	iio_push_to_buffers_with_timestamp(indio_dev, st->data,
+					   iio_get_time_ns(indio_dev));
+error_ret:
 	iio_trigger_notify_done(indio_dev->trig);
 	/* The rising edge of the CONVST signal starts a new conversion. */
 	gpiod_set_value(st->gpio_convst, 1);
 
-	mutex_unlock(&st->lock);
-
 	return IRQ_HANDLED;
 }
 
@@ -257,19 +255,17 @@ static int ad7606_write_raw(struct iio_dev *indio_dev,
 	struct ad7606_state *st = iio_priv(indio_dev);
 	int i, ret, ch = 0;
 
+	guard(mutex)(&st->lock);
+
 	switch (mask) {
 	case IIO_CHAN_INFO_SCALE:
-		mutex_lock(&st->lock);
 		i = find_closest(val2, st->scale_avail, st->num_scales);
 		if (st->sw_mode_en)
 			ch = chan->address;
 		ret = st->write_scale(indio_dev, ch, i);
-		if (ret < 0) {
-			mutex_unlock(&st->lock);
+		if (ret < 0)
 			return ret;
-		}
 		st->range[ch] = i;
-		mutex_unlock(&st->lock);
 
 		return 0;
 	case IIO_CHAN_INFO_OVERSAMPLING_RATIO:
@@ -277,14 +273,9 @@ static int ad7606_write_raw(struct iio_dev *indio_dev,
 			return -EINVAL;
 		i = find_closest(val, st->oversampling_avail,
 				 st->num_os_ratios);
-		mutex_lock(&st->lock);
 		ret = st->write_os(indio_dev, i);
-		if (ret < 0) {
-			mutex_unlock(&st->lock);
+		if (ret < 0)
 			return ret;
-		}
-		st->oversampling = st->oversampling_avail[i];
-		mutex_unlock(&st->lock);
 
 		return 0;
 	default:

-- 
2.34.1

Re: [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard

[Nuno Sá]

On Tue, 2024-07-02 at 17:34 +0000, Guillaume Stols wrote:
> Switching to scoped_guard simplifies the code and avoids to take care to
> unlock the mutex in case of premature return.
> 
> Signed-off-by: Guillaume Stols <gstols@baylibre.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

Re: [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard

[Markus Elfring]

> Switching to scoped_guard simplifies the code and avoids to take care to
> unlock the mutex in case of premature return.

Can such a change description become more imperative?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n94


…
> +++ b/drivers/iio/adc/ad7606.c
…
> @@ -124,19 +122,19 @@ static irqreturn_t ad7606_trigger_handler(int irq, void *p)
…
>  	ret = ad7606_read_samples(st);
> -	if (ret == 0)
> -		iio_push_to_buffers_with_timestamp(indio_dev, st->data,
> -						   iio_get_time_ns(indio_dev));
> +	if (ret)
> +		goto error_ret;
>
> +	iio_push_to_buffers_with_timestamp(indio_dev, st->data,
> +					   iio_get_time_ns(indio_dev));
> +error_ret:
>  	iio_trigger_notify_done(indio_dev->trig);
…

I find that these control flow adjustments do not fit to the changelog.
They can be offered in another update step (on demand), can't they?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n81


There are no scoped_guard() calls performed in your patch.
How do you think about to use a summary phrase like “Switch mutex calls to mutex guard usage”?

Regards,
Markus

Re: [PATCH v3 0/8] iio: adc: ad7606: Improvements

[Jonathan Cameron]

On Tue, 02 Jul 2024 17:34:04 +0000
Guillaume Stols <gstols@baylibre.com> wrote:

> This series adds the following improvements over the current AD7606's
> driver implementation:
> 
> - Fix wrong usage of gpio array
> - Fix standby that was documented as ACTIVE_LOW but handled in the
>   driver as if it was ACTIVE_HIGH
> - Improve dt-bindings documentation
> - Switch mutex lock to scoped guard
> 
> Signed-off-by: Guillaume Stols <gstols@baylibre.com>
This series is blowing up with b4, in that it is finding tags that were
not given and I can't work out why.

Tried various options but even a simple b4 am -l 20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@baylibre.com
Is merrily finding tags that I can find no record of.
  ✓ [PATCH v3 1/8] dt-bindings: iio: adc: adi,ad7606: normalize textwidth
    + Reviewed-by: Conor Dooley <conor.dooley@microchip.com> (✓ DKIM/kernel.org)
    + Reviewed-by: Rob Herring (Arm) <robh@kernel.org> (✓ DKIM/kernel.org)
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-1-57fd02a4e2aa@baylibre.com
  ✓ [PATCH v3 2/8] dt-bindings: iio: adc: adi,ad7606: improve descriptions
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-2-57fd02a4e2aa@baylibre.com
  ✓ [PATCH v3 3/8] dt-bindings: iio: adc: adi,ad7606: add supply properties
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-3-57fd02a4e2aa@baylibre.com
  ✓ [PATCH v3 4/8] dt-bindings: iio: adc: adi,ad7606: fix example
    + Reviewed-by: Conor Dooley <conor.dooley@microchip.com> (✓ DKIM/kernel.org)
    + Acked-by: Rob Herring (Arm) <robh@kernel.org> (✓ DKIM/kernel.org)
    + Reviewed-by: Rob Herring (Arm) <robh@kernel.org> (✓ DKIM/kernel.org)
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-4-57fd02a4e2aa@baylibre.com
  ✓ [PATCH v3 5/8] dt-bindings: iio: adc: adi,ad7606: add conditions
    + Acked-by: Rob Herring (Arm) <robh@kernel.org> (✓ DKIM/kernel.org)
    + Reviewed-by: Rob Herring (Arm) <robh@kernel.org> (✓ DKIM/kernel.org)
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-5-57fd02a4e2aa@baylibre.com
  ✓ [PATCH v3 6/8] iio: adc: ad7606: fix oversampling gpio array
    + Reviewed-by: Conor Dooley <conor.dooley@microchip.com> (✓ DKIM/kernel.org)
    + Acked-by: Rob Herring (Arm) <robh@kernel.org> (✓ DKIM/kernel.org)
    + Reviewed-by: Rob Herring (Arm) <robh@kernel.org> (✓ DKIM/kernel.org)
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-6-57fd02a4e2aa@baylibre.com
  ✓ [PATCH v3 7/8] iio: adc: ad7606: fix standby gpio state to match the documentation
    + Reviewed-by: Conor Dooley <conor.dooley@microchip.com> (✓ DKIM/kernel.org)
    + Acked-by: Rob Herring (Arm) <robh@kernel.org> (✓ DKIM/kernel.org)
    + Reviewed-by: Rob Herring (Arm) <robh@kernel.org> (✓ DKIM/kernel.org)
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-7-57fd02a4e2aa@baylibre.com
  ✓ [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-8-57fd02a4e2aa@baylibre.com

Take patch 7 for example, I can find no record or Rob or Conor replying to that
or giving tags on the cover letter.

The only local parameter I have is to change the link path as you can see above.

Tried it with b4 0.14 and master as of today.


> ---
> Changes in v3:
> - Remove the two first patches that were already picked up.
> - Add styling corrections.
> - [Patch 6/8] Improve commit message.
> - [Patch 8/8] Replace every scoped_guard by simple guard.
> - Link to v2: https://lore.kernel.org/r/20240628-cleanup-ad7606-v2-0-96e02f90256d@baylibre.com
> 
> Changes in v2:
> - Change scoped guard to guard(mutex)(&st->lock). This was tested with
>   Rob's bot condition, and seems not to generate warning anymore.
> - Reorder the commits for avoiding bisection issues and respect commit
>   priority rules.
> - Add vdrive-supply to required properties.
> - Separate cosmetic changes from content ones in dt-binding
>   descriptions.
> - Move maxItems changes (and plural in descriptions) to the commit that
>   adds conditions.
> - Link to v1: https://lore.kernel.org/r/20240618-cleanup-ad7606-v1-0-f1854d5c779d@baylibre.com
> 
> ---
> Guillaume Stols (8):
>       dt-bindings: iio: adc: adi,ad7606: normalize textwidth
>       dt-bindings: iio: adc: adi,ad7606: improve descriptions
>       dt-bindings: iio: adc: adi,ad7606: add supply properties
>       dt-bindings: iio: adc: adi,ad7606: fix example
>       dt-bindings: iio: adc: adi,ad7606: add conditions
>       iio: adc: ad7606: fix oversampling gpio array
>       iio: adc: ad7606: fix standby gpio state to match the documentation
>       iio: adc: ad7606: switch mutexes to scoped_guard
> 
>  .../devicetree/bindings/iio/adc/adi,ad7606.yaml    | 123 ++++++++++++++++-----
>  drivers/iio/adc/ad7606.c                           |  47 ++++----
>  drivers/iio/adc/ad7606_spi.c                       |   5 +-
>  3 files changed, 115 insertions(+), 60 deletions(-)
> ---
> base-commit: 340fa834ae229a952db04a57ed13fd5d35d75818
> change-id: 20240416-cleanup-ad7606-161e2ed9818b
> 
> Best regards,

Re: [PATCH v3 0/8] iio: adc: ad7606: Improvements

[Konstantin Ryabitsev]

On Sat, Jul 06, 2024 at 01:15:49PM GMT, Jonathan Cameron wrote:
> This series is blowing up with b4, in that it is finding tags that were
> not given and I can't work out why.
> 
> Tried various options but even a simple b4 am -l 20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@baylibre.com
> Is merrily finding tags that I can find no record of.

I can't replicate this, so something else is going on. Can you try:

    b4 --no-cache am -l 20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@baylibre.com

In either case, I want to see the output of:

    b4 -d am -l 20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@baylibre.com 2>/tmp/b4-debug

-K

Re: [PATCH v3 0/8] iio: adc: ad7606: Improvements

[Jonathan Cameron]

On Sat, 6 Jul 2024 08:29:28 -0400
Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:

> On Sat, Jul 06, 2024 at 01:15:49PM GMT, Jonathan Cameron wrote:
> > This series is blowing up with b4, in that it is finding tags that were
> > not given and I can't work out why.
> > 
> > Tried various options but even a simple b4 am -l 20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@baylibre.com
> > Is merrily finding tags that I can find no record of.  
> 
> I can't replicate this, so something else is going on. Can you try:
> 
>     b4 --no-cache am -l 20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@baylibre.com

Moved the no-cache after am as otherwise unrecognised parameter.
Not seeing any change to results.

> 
> In either case, I want to see the output of:
> 
>     b4 -d am -l 20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@baylibre.com 2>/tmp/b4-debug

Running git --no-pager rev-parse --show-toplevel
Running git --no-pager config -z --get-regexp b4\..*
Running git --no-pager config -z --get-regexp gpg\..*
Running git --no-pager config -z --get-regexp user\..*
Running git --no-pager config -z --get-regexp sendemail\.[^.]+$
Using values from sendemail
t_mbx_url=https://lore.kernel.org/all/20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@baylibre.com/t.mbox.gz
Grabbing thread from lore.kernel.org/all/20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@baylibre.com/t.mbox.gz
Mailsplitting the mbox into /tmp/tmp5ftpkxzs-mailsplit
Running git --no-pager mailsplit --mboxrd -o/tmp/tmp5ftpkxzs-mailsplit
Looking at: 20240702-cleanup-ad7606-v3-1-57fd02a4e2aa@baylibre.com
Kept in thread: 20240702-cleanup-ad7606-v3-1-57fd02a4e2aa@baylibre.com
Looking at: 20240702-cleanup-ad7606-v3-2-57fd02a4e2aa@baylibre.com
Kept in thread: 20240702-cleanup-ad7606-v3-2-57fd02a4e2aa@baylibre.com
Looking at: 20240702-cleanup-ad7606-v3-3-57fd02a4e2aa@baylibre.com
Kept in thread: 20240702-cleanup-ad7606-v3-3-57fd02a4e2aa@baylibre.com
Looking at: 20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@baylibre.com
Kept in thread: 20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@baylibre.com
Looking at: 20240702-cleanup-ad7606-v3-4-57fd02a4e2aa@baylibre.com
Kept in thread: 20240702-cleanup-ad7606-v3-4-57fd02a4e2aa@baylibre.com
Looking at: 20240702-cleanup-ad7606-v3-6-57fd02a4e2aa@baylibre.com
Kept in thread: 20240702-cleanup-ad7606-v3-6-57fd02a4e2aa@baylibre.com
Looking at: 20240702-cleanup-ad7606-v3-5-57fd02a4e2aa@baylibre.com
Kept in thread: 20240702-cleanup-ad7606-v3-5-57fd02a4e2aa@baylibre.com
Looking at: 20240702-cleanup-ad7606-v3-7-57fd02a4e2aa@baylibre.com
Kept in thread: 20240702-cleanup-ad7606-v3-7-57fd02a4e2aa@baylibre.com
Looking at: 20240702-cleanup-ad7606-v3-8-57fd02a4e2aa@baylibre.com
Kept in thread: 20240702-cleanup-ad7606-v3-8-57fd02a4e2aa@baylibre.com
Looking at: 17e484a2c07c0a521120a6a3cab7dfcf5f3c2fee.camel@gmail.com
Kept in thread: 17e484a2c07c0a521120a6a3cab7dfcf5f3c2fee.camel@gmail.com
Looking at: 429af3d1afe4297dde5c8795ca745d84d52e5033.camel@gmail.com
Kept in thread: 429af3d1afe4297dde5c8795ca745d84d52e5033.camel@gmail.com
Looking at: 8010eaf5300d2dcf928812693379b649b77f0e0f.camel@gmail.com
Kept in thread: 8010eaf5300d2dcf928812693379b649b77f0e0f.camel@gmail.com
Looking at: 20240706131549.1f94449c@jic23-huawei
Kept in thread: 20240706131549.1f94449c@jic23-huawei
Looking at: 20240706-funny-flamingo-of-temperance-9d1e85@lemur
Kept in thread: 20240706-funny-flamingo-of-temperance-9d1e85@lemur
Looking at: 4d47b8c3-2f36-4325-b288-0faa40f876eb@web.de
Kept in thread: 4d47b8c3-2f36-4325-b288-0faa40f876eb@web.de
Analyzing 15 messages in the thread
Ignoring 24:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 34:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 44:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 56:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 71:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 80:      maxItems: 3 (not a recognized non-person trailer)
Ignoring 95:      type: boolean (not a recognized non-person trailer)
Looking at: [PATCH v3 1/8] dt-bindings: iio: adc: adi,ad7606: normalize textwidth
  adding as patch
Ignoring 14:    avcc-supply: true (not a recognized non-person trailer)
Ignoring 20:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 32:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 45:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 58:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 67:      maxItems: 3 (not a recognized non-person trailer)
Ignoring 83:      type: boolean (not a recognized non-person trailer)
Looking at: [PATCH v3 2/8] dt-bindings: iio: adc: adi,ad7606: improve descriptions
  adding as patch
Ignoring 15:    avcc-supply: true (not a recognized non-person trailer)
Looking at: [PATCH v3 3/8] dt-bindings: iio: adc: adi,ad7606: add supply properties
  adding as patch
Ignoring 33:       dt-bindings: iio: adc: adi,ad7606: normalize textwidth (not a recognized non-person trailer)
Ignoring 34:       dt-bindings: iio: adc: adi,ad7606: improve descriptions (not a recognized non-person trailer)
Ignoring 35:       dt-bindings: iio: adc: adi,ad7606: add supply properties (not a recognized non-person trailer)
Ignoring 36:       dt-bindings: iio: adc: adi,ad7606: fix example (not a recognized non-person trailer)
Ignoring 37:       dt-bindings: iio: adc: adi,ad7606: add conditions (not a recognized non-person trailer)
Ignoring 38:       iio: adc: ad7606: fix oversampling gpio array (not a recognized non-person trailer)
Ignoring 39:       iio: adc: ad7606: fix standby gpio state to match the documentation (not a recognized non-person trailer)
Ignoring 40:       iio: adc: ad7606: switch mutexes to scoped_guard (not a recognized non-person trailer)
Looking at: [PATCH v3 0/8] iio: adc: ad7606: Improvements
  adding as v3 cover letter
Looking at: [PATCH v3 4/8] dt-bindings: iio: adc: adi,ad7606: fix example
  adding as patch
Looking at: [PATCH v3 6/8] iio: adc: ad7606: fix oversampling gpio array
  adding as patch
Ignoring 93:  unevaluatedProperties: false (not a recognized non-person trailer)
Looking at: [PATCH v3 5/8] dt-bindings: iio: adc: adi,ad7606: add conditions
  adding as patch
Looking at: [PATCH v3 7/8] iio: adc: ad7606: fix standby gpio state to match the documentation
  adding as patch
Looking at: [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard
  adding as patch
Looking at: Re: [PATCH v3 6/8] iio: adc: ad7606: fix oversampling gpio array
  adding to followups
Looking at: Re: [PATCH v3 7/8] iio: adc: ad7606: fix standby gpio state to match the documentation
  adding to followups
Looking at: Re: [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard
  adding to followups
Looking at: Re: [PATCH v3 0/8] iio: adc: ad7606: Improvements
  adding to followups
Looking at: Re: [PATCH v3 0/8] iio: adc: ad7606: Improvements
  adding to followups
Looking at: Re: [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard
  adding to followups
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
full_threads specified, adding t=1
Using cached copy: /home/jic23/.cache/b4/3bbd0dc0edd87cc84b84b8e5684b244bc5ee9b43.pi.msgs
Retrieved 65 matching code-review messages
Ignoring 92:  unevaluatedProperties: false (not a recognized non-person trailer)
Ignoring 53:  Base: using specified base-commit 07d4d0bb4a8ddcc463ed599b22f510d5926c2495 (not a recognized non-person trailer)
Ignoring 54: Applying: dt-bindings: iio: adc: adi,ad7606: add missing datasheet link (not a recognized non-person trailer)
Ignoring 55: Applying: dt-bindings: iio: adc: adi,ad7606: comment and sort the compatible names (not a recognized non-person trailer)
Ignoring 56: Applying: dt-bindings: iio: adc: adi,ad7606: normalize textwidth (not a recognized non-person trailer)
Ignoring 57: Applying: dt-bindings: iio: adc: adi,ad7606: improve descriptions (not a recognized non-person trailer)
Ignoring 58: Applying: dt-bindings: iio: adc: adi,ad7606: add supply properties (not a recognized non-person trailer)
Ignoring 59: Applying: dt-bindings: iio: adc: adi,ad7606: fix example (not a recognized non-person trailer)
Ignoring 60: Applying: dt-bindings: iio: adc: adi,ad7606: add conditions (not a recognized non-person trailer)
Ignoring 61: Applying: iio: adc: ad7606: fix oversampling gpio array (not a recognized non-person trailer)
Ignoring 62: Applying: iio: adc: ad7606: fix standby gpio state to match the documentation (not a recognized non-person trailer)
Ignoring 63: Applying: iio: adc: ad7606: switch mutexes to scoped_guard (not a recognized non-person trailer)
Ignoring 14:  description: | (not a recognized non-person trailer)
Ignoring 14:    avcc-supply: true (not a recognized non-person trailer)
Ignoring 7: url:    https://github.com/intel-lab-lkp/linux/commits/Guillaume-Stols/dt-bindings-iio-adc-adi-ad7606-add-missing-datasheet-link/20240618-223010 (not a recognized non-person trailer)
Ignoring 8: base:   07d4d0bb4a8ddcc463ed599b22f510d5926c2495 (not a recognized non-person trailer)
Ignoring 11: config: x86_64-randconfig-101-20240619 (https://download.01.org/0day-ci/archive/20240619/202406191142.rs8moLqC-lkp@intel.com/config) (not a recognized link trailer)
Ignoring 12: compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) (not a recognized non-person trailer)
Ignoring 13:    avcc-supply: true (not a recognized non-person trailer)
Ignoring 19:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 30:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 41:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 51:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 63:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 80:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 91:      maxItems: 3 (not a recognized non-person trailer)
Ignoring 108:      type: boolean (not a recognized non-person trailer)
Ignoring 14:  description: | (not a recognized non-person trailer)
Ignoring 14:    avcc-supply: true (not a recognized non-person trailer)
Ignoring 23:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 33:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 43:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 55:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 70:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 79:      maxItems: 3 (not a recognized non-person trailer)
Ignoring 94:      type: boolean (not a recognized non-person trailer)
Ignoring 13:    avcc-supply: true (not a recognized non-person trailer)
Ignoring 19:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 31:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 44:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 57:      maxItems: 1 (not a recognized non-person trailer)
Ignoring 66:      maxItems: 3 (not a recognized non-person trailer)
Ignoring 82:      type: boolean (not a recognized non-person trailer)
Ignoring 26:       dt-bindings: iio: adc: adi,ad7606: add missing datasheet link (not a recognized non-person trailer)
Ignoring 27:       dt-bindings: iio: adc: adi,ad7606: comment and sort the compatible names (not a recognized non-person trailer)
Ignoring 28:       dt-bindings: iio: adc: adi,ad7606: normalize textwidth (not a recognized non-person trailer)
Ignoring 29:       dt-bindings: iio: adc: adi,ad7606: improve descriptions (not a recognized non-person trailer)
Ignoring 30:       dt-bindings: iio: adc: adi,ad7606: add supply properties (not a recognized non-person trailer)
Ignoring 31:       dt-bindings: iio: adc: adi,ad7606: fix example (not a recognized non-person trailer)
Ignoring 32:       dt-bindings: iio: adc: adi,ad7606: add conditions (not a recognized non-person trailer)
Ignoring 33:       iio: adc: ad7606: fix oversampling gpio array (not a recognized non-person trailer)
Ignoring 34:       iio: adc: ad7606: fix standby gpio state to match the documentation (not a recognized non-person trailer)
Ignoring 35:       iio: adc: ad7606: switch mutexes to scoped_guard (not a recognized non-person trailer)
Ignoring 82:  unevaluatedProperties: false (not a recognized non-person trailer)
Ignoring 13:       dt-bindings: iio: adc: adi,ad7606: add missing datasheet link (not a recognized non-person trailer)
Ignoring 14:       dt-bindings: iio: adc: adi,ad7606: comment and sort the compatible names (not a recognized non-person trailer)
Ignoring 15:       dt-bindings: iio: adc: adi,ad7606: improve descriptions (not a recognized non-person trailer)
Ignoring 16:       dt-bindings: iio: adc: adi,ad7606: add supply properties (not a recognized non-person trailer)
Ignoring 17:       dt-bindings: iio: adc: adi,ad7606: add conditions (not a recognized non-person trailer)
Ignoring 18:       dt-bindings: iio: adc: adi,ad7606: fix example (not a recognized non-person trailer)
Ignoring 19:       iio: adc: ad7606: switch mutexes to scoped_guard (not a recognized non-person trailer)
Ignoring 20:       iio: adc: ad7606: fix oversampling gpio array (not a recognized non-person trailer)
Ignoring 21:       iio: adc: ad7606: fix standby gpio state to match the documentation (not a recognized non-person trailer)
Analyzing 50 code-review messages
  new message: 171985401324.129711.10327596818735583111.robh@kernel.org
Running git --no-pager patch-id --stable
  found matching patch-id for dt-bindings: iio: adc: adi,ad7606: normalize textwidth
  new message: 20240623163130.4a72707b@jic23-huawei
  skipping reply without trailers: 20240623163130.4a72707b@jic23-huawei
  new message: 20240618-oval-parish-d3fa2925a52a@spud
  found a cover letter for dt-bindings: iio: adc: adi,ad7606: add conditions
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
  found matching patch-id for dt-bindings: iio: adc: adi,ad7606: add conditions
  new message: 20240618-cleanup-ad7606-v1-7-f1854d5c779d@baylibre.com
  skipping non-reply: 20240618-cleanup-ad7606-v1-7-f1854d5c779d@baylibre.com
  new message: 12e5c4b4-e51d-4e69-8c63-3f6aefb574d9@baylibre.com
  skipping reply without trailers: 12e5c4b4-e51d-4e69-8c63-3f6aefb574d9@baylibre.com
  new message: 20240628-cleanup-ad7606-v2-7-96e02f90256d@baylibre.com
  skipping non-reply: 20240628-cleanup-ad7606-v2-7-96e02f90256d@baylibre.com
  new message: 20240629162223.5b8d35b8@jic23-huawei
  skipping reply without trailers: 20240629162223.5b8d35b8@jic23-huawei
  new message: 20240628-postwar-scaling-cb7d7b1f4f3c@spud
  skipping reply without trailers: 20240628-postwar-scaling-cb7d7b1f4f3c@spud
  new message: 20240623164126.0cf96981@jic23-huawei
  skipping reply without trailers: 20240623164126.0cf96981@jic23-huawei
  new message: 20240630-darling-dairy-f161f784f45a@spud
  skipping reply without trailers: 20240630-darling-dairy-f161f784f45a@spud
  new message: 20240618-cleanup-ad7606-v1-1-f1854d5c779d@baylibre.com
  skipping non-reply: 20240618-cleanup-ad7606-v1-1-f1854d5c779d@baylibre.com
  new message: 20240618-cleanup-ad7606-v1-6-f1854d5c779d@baylibre.com
  skipping non-reply: 20240618-cleanup-ad7606-v1-6-f1854d5c779d@baylibre.com
  new message: 20240618-cleanup-ad7606-v1-4-f1854d5c779d@baylibre.com
  skipping non-reply: 20240618-cleanup-ad7606-v1-4-f1854d5c779d@baylibre.com
  new message: 20240628-sworn-vegan-be51d695ba52@spud
  found a cover letter for dt-bindings: iio: adc: adi,ad7606: add conditions
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
Running git --no-pager patch-id --stable
  found matching patch-id for dt-bindings: iio: adc: adi,ad7606: add conditions
  new message: 20240623163508.4e0bdb8b@jic23-huawei
  skipping reply without trailers: 20240623163508.4e0bdb8b@jic23-huawei
  new message: 171952025424.477297.14698127361119381011.robh@kernel.org
  found matching patch-id for dt-bindings: iio: adc: adi,ad7606: add missing datasheet link
  new message: 20240628-cleanup-ad7606-v2-10-96e02f90256d@baylibre.com
  skipping non-reply: 20240628-cleanup-ad7606-v2-10-96e02f90256d@baylibre.com
  new message: 202406191142.rs8moLqC-lkp@intel.com
  skipping reply without trailers: 202406191142.rs8moLqC-lkp@intel.com
  new message: 171985436896.136027.10830474139479480832.robh@kernel.org
  found a cover letter for dt-bindings: iio: adc: adi,ad7606: improve descriptions
  found matching patch-id for dt-bindings: iio: adc: adi,ad7606: improve descriptions
  new message: 20240623164920.48dda649@jic23-huawei
  skipping reply without trailers: 20240623164920.48dda649@jic23-huawei
  new message: 20240618-cleanup-ad7606-v1-8-f1854d5c779d@baylibre.com
  skipping non-reply: 20240618-cleanup-ad7606-v1-8-f1854d5c779d@baylibre.com
  new message: 171872601308.2592859.9209680647249959738.robh@kernel.org
  skipping reply without trailers: 171872601308.2592859.9209680647249959738.robh@kernel.org
  new message: 20240618-cleanup-ad7606-v1-3-f1854d5c779d@baylibre.com
  skipping non-reply: 20240618-cleanup-ad7606-v1-3-f1854d5c779d@baylibre.com
  new message: 20240628-cleanup-ad7606-v2-1-96e02f90256d@baylibre.com
  skipping non-reply: 20240628-cleanup-ad7606-v2-1-96e02f90256d@baylibre.com
  new message: 20240618-spearfish-swear-213166c7224f@spud
  skipping parent without a diff or diffstat
  skipping parent without a diff or diffstat
  found matching patch-id for dt-bindings: iio: adc: adi,ad7606: add supply properties
  new message: 62dadd31-5fd1-45b4-99e8-44ffb367bad5@baylibre.com
  skipping reply without trailers: 62dadd31-5fd1-45b4-99e8-44ffb367bad5@baylibre.com
  new message: 20240628-cleanup-ad7606-v2-6-96e02f90256d@baylibre.com
  skipping non-reply: 20240628-cleanup-ad7606-v2-6-96e02f90256d@baylibre.com
  new message: 20240628-cleanup-ad7606-v2-5-96e02f90256d@baylibre.com
  skipping non-reply: 20240628-cleanup-ad7606-v2-5-96e02f90256d@baylibre.com
  new message: 20240618-cleanup-ad7606-v1-9-f1854d5c779d@baylibre.com
  skipping non-reply: 20240618-cleanup-ad7606-v1-9-f1854d5c779d@baylibre.com
  new message: 20240629163659.322954c3@jic23-huawei
  skipping reply without trailers: 20240629163659.322954c3@jic23-huawei
  new message: 20240629163845.0a8ed683@jic23-huawei
  skipping reply without trailers: 20240629163845.0a8ed683@jic23-huawei
  new message: 20240628-cleanup-ad7606-v2-3-96e02f90256d@baylibre.com
  skipping non-reply: 20240628-cleanup-ad7606-v2-3-96e02f90256d@baylibre.com
  new message: 20240628-trustful-urchin-741943d2e98d@spud
  skipping reply without trailers: 20240628-trustful-urchin-741943d2e98d@spud
  new message: 20240618-rack-synthetic-1d1747b34a6a@spud
  found matching patch-id for dt-bindings: iio: adc: adi,ad7606: fix example
  new message: 20240623162827.45220840@jic23-huawei
  skipping reply without trailers: 20240623162827.45220840@jic23-huawei
  new message: 20240618-cleanup-ad7606-v1-2-f1854d5c779d@baylibre.com
  skipping non-reply: 20240618-cleanup-ad7606-v1-2-f1854d5c779d@baylibre.com
  new message: 20240628-cleanup-ad7606-v2-8-96e02f90256d@baylibre.com
  skipping non-reply: 20240628-cleanup-ad7606-v2-8-96e02f90256d@baylibre.com
  new message: 171952032004.478307.5280182877867747227.robh@kernel.org
  found matching patch-id for dt-bindings: iio: adc: adi,ad7606: comment and sort the compatible names
  new message: 20240623163330.7a9fd911@jic23-huawei
  skipping reply without trailers: 20240623163330.7a9fd911@jic23-huawei
  new message: 20240629161808.6c15bcb9@jic23-huawei
  skipping reply without trailers: 20240629161808.6c15bcb9@jic23-huawei
  new message: 20240629163043.5e96e80c@jic23-huawei
  skipping reply without trailers: 20240629163043.5e96e80c@jic23-huawei
  new message: 20240628-cleanup-ad7606-v2-4-96e02f90256d@baylibre.com
  skipping non-reply: 20240628-cleanup-ad7606-v2-4-96e02f90256d@baylibre.com
  new message: 20240623164542.53a9f2b1@jic23-huawei
  skipping reply without trailers: 20240623164542.53a9f2b1@jic23-huawei
  new message: 20240628-cleanup-ad7606-v2-0-96e02f90256d@baylibre.com
  skipping non-reply: 20240628-cleanup-ad7606-v2-0-96e02f90256d@baylibre.com
  new message: 20240618-eggnog-cusp-8b5a17313367@spud
  skipping reply without trailers: 20240618-eggnog-cusp-8b5a17313367@spud
  new message: 20240618-cleanup-ad7606-v1-5-f1854d5c779d@baylibre.com
  skipping non-reply: 20240618-cleanup-ad7606-v1-5-f1854d5c779d@baylibre.com
  new message: 20240629162907.0f5b234e@jic23-huawei
  skipping reply without trailers: 20240629162907.0f5b234e@jic23-huawei
  new message: 20240618-cleanup-ad7606-v1-0-f1854d5c779d@baylibre.com
  skipping non-reply: 20240618-cleanup-ad7606-v1-0-f1854d5c779d@baylibre.com
  new message: 20240628-cleanup-ad7606-v2-2-96e02f90256d@baylibre.com
  skipping non-reply: 20240628-cleanup-ad7606-v2-2-96e02f90256d@baylibre.com
  new message: 20240628-cleanup-ad7606-v2-9-96e02f90256d@baylibre.com
  skipping non-reply: 20240628-cleanup-ad7606-v2-9-96e02f90256d@baylibre.com
Analyzing follow-up: Re: [PATCH v3 6/8] iio: adc: ad7606: fix oversampling gpio array (noname.nuno@gmail.com)
fmsg.in_reply_to=20240702-cleanup-ad7606-v3-6-57fd02a4e2aa@baylibre.com
Found in-reply-to 20240702-cleanup-ad7606-v3-6-57fd02a4e2aa@baylibre.com in msgid_map
trailer did not match: Reviewed-by: Nuno Sa <nuno.sa@analog.com>
 Parent: [PATCH v3 6/8] iio: adc: ad7606: fix oversampling gpio array
 Trailers:
Analyzing follow-up: Re: [PATCH v3 7/8] iio: adc: ad7606: fix standby gpio state to match the documentation (noname.nuno@gmail.com)
fmsg.in_reply_to=20240702-cleanup-ad7606-v3-7-57fd02a4e2aa@baylibre.com
Found in-reply-to 20240702-cleanup-ad7606-v3-7-57fd02a4e2aa@baylibre.com in msgid_map
trailer did not match: Reviewed-by: Nuno Sa <nuno.sa@analog.com>
 Parent: [PATCH v3 7/8] iio: adc: ad7606: fix standby gpio state to match the documentation
 Trailers:
Analyzing follow-up: Re: [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard (noname.nuno@gmail.com)
fmsg.in_reply_to=20240702-cleanup-ad7606-v3-8-57fd02a4e2aa@baylibre.com
Found in-reply-to 20240702-cleanup-ad7606-v3-8-57fd02a4e2aa@baylibre.com in msgid_map
trailer did not match: Reviewed-by: Nuno Sa <nuno.sa@analog.com>
 Parent: [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard
 Trailers:
Analyzing follow-up: Re: [PATCH v3 0/8] iio: adc: ad7606: Improvements (jic23@kernel.org)
  no trailers found, skipping
Analyzing follow-up: Re: [PATCH v3 0/8] iio: adc: ad7606: Improvements (konstantin@linuxfoundation.org)
  no trailers found, skipping
Analyzing follow-up: Re: [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard (Markus.Elfring@web.de)
  no trailers found, skipping
  trailer email match
    adding "Acked-by: Rob Herring (Arm) <robh@kernel.org>" from trailer_map to: [PATCH v3 1/8] dt-bindings: iio: adc: adi,ad7606: normalize textwidth
  trailer exact name match
  trailer fuzzy name match
    adding "Reviewed-by: Conor Dooley <conor.dooley@microchip.com>" from trailer_map to: [PATCH v3 1/8] dt-bindings: iio: adc: adi,ad7606: normalize textwidth
  trailer email match
    adding "Reviewed-by: Rob Herring (Arm) <robh@kernel.org>" from trailer_map to: [PATCH v3 1/8] dt-bindings: iio: adc: adi,ad7606: normalize textwidth
  trailer exact name match
  trailer fuzzy name match
    adding "Reviewed-by: Conor Dooley <conor.dooley@microchip.com>" from trailer_map to: [PATCH v3 4/8] dt-bindings: iio: adc: adi,ad7606: fix example
  trailer exact name match
  trailer fuzzy name match
  trailer email match
    adding "Reviewed-by: Rob Herring (Arm) <robh@kernel.org>" from trailer_map to: [PATCH v3 4/8] dt-bindings: iio: adc: adi,ad7606: fix example
  trailer exact name match
  trailer fuzzy name match
    adding "Acked-by: Conor Dooley <conor.dooley@microchip.com>" from trailer_map to: [PATCH v3 4/8] dt-bindings: iio: adc: adi,ad7606: fix example
  trailer exact name match
  trailer fuzzy name match
    adding "Reviewed-by: Conor Dooley <conor.dooley@microchip.com>" from trailer_map to: [PATCH v3 5/8] dt-bindings: iio: adc: adi,ad7606: add conditions
  trailer email match
    adding "Reviewed-by: Rob Herring (Arm) <robh@kernel.org>" from trailer_map to: [PATCH v3 5/8] dt-bindings: iio: adc: adi,ad7606: add conditions
  trailer exact name match
  trailer fuzzy name match
    adding "Reviewed-by: Conor Dooley <conor.dooley@microchip.com>" from trailer_map to: [PATCH v3 6/8] iio: adc: ad7606: fix oversampling gpio array
  trailer exact name match
  trailer fuzzy name match
  trailer email match
    adding "Reviewed-by: Rob Herring (Arm) <robh@kernel.org>" from trailer_map to: [PATCH v3 6/8] iio: adc: ad7606: fix oversampling gpio array
  trailer exact name match
  trailer fuzzy name match
    adding "Reviewed-by: Conor Dooley <conor.dooley@microchip.com>" from trailer_map to: [PATCH v3 7/8] iio: adc: ad7606: fix standby gpio state to match the documentation
  trailer exact name match
  trailer fuzzy name match
  trailer email match
    adding "Reviewed-by: Rob Herring (Arm) <robh@kernel.org>" from trailer_map to: [PATCH v3 7/8] iio: adc: ad7606: fix standby gpio state to match the documentation
Checking attestation on all messages, may take a moment...
Loading attestation: [PATCH v3 1/8] dt-bindings: iio: adc: adi,ad7606: normalize textwidth
Loading DKIM attestation for d=baylibre-com.20230601.gappssmtp.com, s=20230601
DKIM: sig: {b'v': b'1', b'a': b'rsa-sha256', b'c': b'relaxed/relaxed', b'd': b'baylibre-com.20230601.gappssmtp.com', b's': b'20230601', b't': b'1719941647', b'x': b'1720546447', b'darn': b'vger.kernel.org', b'h': b'cc:to:in-reply-to:references:message-id:content-transfer-encoding\r\n         :mime-version:subject:date:from:from:to:cc:subject:date:message-id\r\n         :reply-to', b'bh': b'XoOP6xDFVO+piNQMxKh2JgMUAWvA+ZCbwk4Ckp0ym3U=', b'b': b'bskrnKu86JUiCpGnSMMH0jp0oIo7CNOU5GucJkH1i8FNuWfuWtgReLxPKvsgakZwwe\r\n         zeCBNMxG4Ev5grxV0bx9i2Dj/w9ZHSLvHRN4Sx6nKXjNT1vKIHb0cSCBedtTb7KneORE\r\n         F6VzDlGwGBBYugqJT1xtmsuSbUR5ujVM8dIlADMkhlqoJY+77P59vry8d5kiW/SNtMID\r\n         Ejgdd2Gt2ocgc9+W/bypD9KGWg10oIlrxxuS4PB30iEIi2fUsm8tiwnhnBm8RToMKs7r\r\n         ZBKEyyxjJLJgzsbDytQli+8g7Uxdk029u1WEmmfi18xEZD8PQ7xXGgf4umta217DkiV0\r\n         WL1Q=='}
DKIM: bh: b'XoOP6xDFVO+piNQMxKh2JgMUAWvA+ZCbwk4Ckp0ym3U='
DKIM: b'DKIM-Signature' valid: True
DKIM verify results: baylibre-com.20230601.gappssmtp.com=True
Attestors: 1
PASS : time drift between Date and t (0:00:02)
Loading attestation: [PATCH v3 2/8] dt-bindings: iio: adc: adi,ad7606: improve descriptions
Loading DKIM attestation for d=baylibre-com.20230601.gappssmtp.com, s=20230601
DKIM: sig: {b'v': b'1', b'a': b'rsa-sha256', b'c': b'relaxed/relaxed', b'd': b'baylibre-com.20230601.gappssmtp.com', b's': b'20230601', b't': b'1719941648', b'x': b'1720546448', b'darn': b'vger.kernel.org', b'h': b'cc:to:in-reply-to:references:message-id:content-transfer-encoding\r\n         :mime-version:subject:date:from:from:to:cc:subject:date:message-id\r\n         :reply-to', b'bh': b'HiVIhZEAyuYnJTbH9Xr5ihUjZSz2ff/4WqtLGIZJN0k=', b'b': b'JVOkIvJ+wPM4x7f1DiLk5FgH7P2fdCOFd5yG0hQ1yWyFJA0zhdVyeV6NbX92z8gSWv\r\n         KVb7rxfScYJQTBbv5mE2ykov//i1aNLabqEJzgkCF7mR9a/mRs7p1wZg+9l8mWvvwbAr\r\n         Ssg68/Yjzo0ra30+fc/Hpko9ZhURiLXswyNcHMWWErQLN4G68FQYmsBFvt3y+YTNl7hd\r\n         0ToQ6lMQjcB1fgdtCHqemj5uJuZhsaco8ZFZd8TNCEwLKUhYdMW596nBuc/koIG1bOeB\r\n         x78KtxccdXiqugLGGpP5G9JgHnI2/9lDsOOBjSA4jDiCT4BYD5JlD+JiMvDYW9Gtbn77\r\n         jzEw=='}
DKIM: bh: b'HiVIhZEAyuYnJTbH9Xr5ihUjZSz2ff/4WqtLGIZJN0k='
DKIM: b'DKIM-Signature' valid: True
DKIM verify results: baylibre-com.20230601.gappssmtp.com=True
Attestors: 1
PASS : time drift between Date and t (0:00:02)
Loading attestation: [PATCH v3 3/8] dt-bindings: iio: adc: adi,ad7606: add supply properties
Loading DKIM attestation for d=baylibre-com.20230601.gappssmtp.com, s=20230601
DKIM: sig: {b'v': b'1', b'a': b'rsa-sha256', b'c': b'relaxed/relaxed', b'd': b'baylibre-com.20230601.gappssmtp.com', b's': b'20230601', b't': b'1719941648', b'x': b'1720546448', b'darn': b'vger.kernel.org', b'h': b'cc:to:in-reply-to:references:message-id:content-transfer-encoding\r\n         :mime-version:subject:date:from:from:to:cc:subject:date:message-id\r\n         :reply-to', b'bh': b'W4PsgI6ViSPMjJzEXz9ZwZPETs75x12HxOOvUnLBogs=', b'b': b'MMQfxXhxHILGpuIKp7BXBARHk67TYPEtouN+SIQNb/okU9lwCsaVwPUui8IJdSAnwq\r\n         eELlxHmR7iXrka7txLZRSn4LI9QY+6s3uf7QoQicsEjT8zkdWIKf7Y5R3oGsWyMIhgDW\r\n         NOdTRaM/dyhHjsDtVv6JTsl1HPbeBA5ilCvMN4hSenQ3nPqjZR9JC9Vg6fCJ+ydiR5fs\r\n         B3Xbyskyg5ffV8ONLy1CuWbsLLm89Md/CgQ8tSxYhgl8Kocmi/9xWyMjbKkc7hiZbiss\r\n         GjNj8dxHP2FtztI9SQLm54lmwW8KGpUbxQqnaFFHm4qMxC9EaEx5gCFD7grgZxyqYiv/\r\n         NdfQ=='}
DKIM: bh: b'W4PsgI6ViSPMjJzEXz9ZwZPETs75x12HxOOvUnLBogs='
DKIM: b'DKIM-Signature' valid: True
DKIM verify results: baylibre-com.20230601.gappssmtp.com=True
Attestors: 1
PASS : time drift between Date and t (0:00:01)
Loading attestation: [PATCH v3 4/8] dt-bindings: iio: adc: adi,ad7606: fix example
Loading DKIM attestation for d=baylibre-com.20230601.gappssmtp.com, s=20230601
DKIM: sig: {b'v': b'1', b'a': b'rsa-sha256', b'c': b'relaxed/relaxed', b'd': b'baylibre-com.20230601.gappssmtp.com', b's': b'20230601', b't': b'1719941649', b'x': b'1720546449', b'darn': b'vger.kernel.org', b'h': b'cc:to:in-reply-to:references:message-id:content-transfer-encoding\r\n         :mime-version:subject:date:from:from:to:cc:subject:date:message-id\r\n         :reply-to', b'bh': b'bqVxrCmaqTdd1OivUsUaCiiNGBxmmQjkW28fKPO8hWM=', b'b': b'X9OwpT/GOyRvGYNRAocpe5BorQ35LZ8cPEWEfpTR6VVmG/PAiBclZWeABUcaqBY7qh\r\n         LDPrH3wmj2M9egaLNVE0QXywMfeRljb3nFTSSHVEA2Fq6BttdiEj5Wg1LvIhwsPo3FQN\r\n         YSjl8QJTLn5CachTFU1FE9zAyxIYewQNASAbijE5rrbCTLor6iymiVQlZGI3yH81+hre\r\n         hmhcxSoPQ6mjcnmwbRKMq9gwBFiRFv6XD3dcXiah3zLKRFZiNea74dhik8S2mz6Ho3lL\r\n         t4WG2pmXB7JXCj9SJxI9Vc/mfFhv7GyeVtS+zPSNqggUVVSPskvwEtL0EMutxK6dI13F\r\n         TPZg=='}
DKIM: bh: b'bqVxrCmaqTdd1OivUsUaCiiNGBxmmQjkW28fKPO8hWM='
DKIM: b'DKIM-Signature' valid: True
DKIM verify results: baylibre-com.20230601.gappssmtp.com=True
Attestors: 1
PASS : time drift between Date and t (0:00:01)
Loading attestation: [PATCH v3 5/8] dt-bindings: iio: adc: adi,ad7606: add conditions
Loading DKIM attestation for d=baylibre-com.20230601.gappssmtp.com, s=20230601
DKIM: sig: {b'v': b'1', b'a': b'rsa-sha256', b'c': b'relaxed/relaxed', b'd': b'baylibre-com.20230601.gappssmtp.com', b's': b'20230601', b't': b'1719941649', b'x': b'1720546449', b'darn': b'vger.kernel.org', b'h': b'cc:to:in-reply-to:references:message-id:content-transfer-encoding\r\n         :mime-version:subject:date:from:from:to:cc:subject:date:message-id\r\n         :reply-to', b'bh': b'OlOMVM0Oi/I1G5ABSh4CvVIoiZHYlhaelZAr8Gl3RX4=', b'b': b'Tb2/hbh25bo/t5+n3AURyKbt8RCGLirlj9Dzhx3WRbY6Rf+9SPAc3FH73mXmDXjc0r\r\n         oecveLKmgKuQw/9hNnyGi3S8L3W5Pl1wLMFYIssGi0QiqdTx/Sd2nib8Fx1In2mmZEsX\r\n         sTf/I2R1uYfqUD5y8rktm73lE4yBU30TQmo7sEO8s5TYZH1Uwb4+5dzNJ8sMd4RwXGcq\r\n         l9+7mQd1CAiNBGxZjte/NKmjepAXvKOk6Zv2biaaN7SQyReGZnQENMVNFAWySePshDyN\r\n         GC7BBHxwts+6IJ5bqdtKCMMLLyNhx3yziQS5JJQ/Qk5WIGRSX6YvxjfehsrHOQ5BqcMW\r\n         VatQ=='}
DKIM: bh: b'OlOMVM0Oi/I1G5ABSh4CvVIoiZHYlhaelZAr8Gl3RX4='
DKIM: b'DKIM-Signature' valid: True
DKIM verify results: baylibre-com.20230601.gappssmtp.com=True
Attestors: 1
PASS : time drift between Date and t (0:00:00)
Loading attestation: [PATCH v3 6/8] iio: adc: ad7606: fix oversampling gpio array
Loading DKIM attestation for d=baylibre-com.20230601.gappssmtp.com, s=20230601
DKIM: sig: {b'v': b'1', b'a': b'rsa-sha256', b'c': b'relaxed/relaxed', b'd': b'baylibre-com.20230601.gappssmtp.com', b's': b'20230601', b't': b'1719941650', b'x': b'1720546450', b'darn': b'vger.kernel.org', b'h': b'cc:to:in-reply-to:references:message-id:content-transfer-encoding\r\n         :mime-version:subject:date:from:from:to:cc:subject:date:message-id\r\n         :reply-to', b'bh': b'iYOb3cXloM7JPnPejGsCNHK/CDwXTFwHzLHb3/a7qrs=', b'b': b'svL4kTXcPOQ9HPCJ3Xp0NAJEsOuZVPfLRyOAMLjPjEaUjFowOymTlyXzxtdSE4+pQ2\r\n         XFfjnZSuNjeoiP4z6JQExroqoVw1VCkW1sb+A41j8cTp17lN5LaM9oY8zEdBiLA+xov7\r\n         LcgwmBWgQKXaEm+zHRwsTpBXVcLaRmMmlc/tLo4Y77a9FVLYJDSQLOJwPDFBTlfTPMCa\r\n         UK8IWdqXS/+zUWQXXjPiNObYDFcUl/Tfnsx6dnyrZhiLl4ySc73QtT4j5/1wnkpSBCrY\r\n         NelVVL/dWhhd1AhsABv9fMBhGBc1BqovDozxd1OS/0GOunqEU802FHzfDHHa96O5uDzO\r\n         t2dA=='}
DKIM: bh: b'iYOb3cXloM7JPnPejGsCNHK/CDwXTFwHzLHb3/a7qrs='
DKIM: b'DKIM-Signature' valid: True
DKIM verify results: baylibre-com.20230601.gappssmtp.com=True
Attestors: 1
PASS : time drift between Date and t (0:00:00)
Loading attestation: [PATCH v3 7/8] iio: adc: ad7606: fix standby gpio state to match the documentation
Loading DKIM attestation for d=baylibre-com.20230601.gappssmtp.com, s=20230601
DKIM: sig: {b'v': b'1', b'a': b'rsa-sha256', b'c': b'relaxed/relaxed', b'd': b'baylibre-com.20230601.gappssmtp.com', b's': b'20230601', b't': b'1719941650', b'x': b'1720546450', b'darn': b'vger.kernel.org', b'h': b'cc:to:in-reply-to:references:message-id:content-transfer-encoding\r\n         :mime-version:subject:date:from:from:to:cc:subject:date:message-id\r\n         :reply-to', b'bh': b'0syamWwYKEIgGFfBRP6mPS2Iu9QxWFGeekc+8eB0dRA=', b'b': b'f04+9I1Zp3cuLVlh/iAyzqvyLqR/68uCE60iStM+7uiaA+NyLfEIhUU/fBEOK5ahv9\r\n         W5+qEKQMAGz/8TAzWesVAKfHURcOsU7/4EI79CGAKDVsLbK4sFiuQ4dofCfXafxeFlul\r\n         V8uTBRmqvkYu2dqTJLQvF1K7REeYy0oFREGAzcwdrf7EgM29goqFrq5pr1WyPTwkdcD6\r\n         n7ijdi3EdUM+RDW2MaQ4QQqt0Ne5eD1XrPOTBcnHD/8ysSZenDYfb7WlBnVkj8qJ7uBm\r\n         r5kODm7INJp8Tep99c2QJzme64wh1O+bsN33Izg3hdakNMh5AgcvfVblmgqQ+C+/M6gb\r\n         U5+Q=='}
DKIM: bh: b'0syamWwYKEIgGFfBRP6mPS2Iu9QxWFGeekc+8eB0dRA='
DKIM: b'DKIM-Signature' valid: True
DKIM verify results: baylibre-com.20230601.gappssmtp.com=True
Attestors: 1
PASS : time drift between Date and t (-1 day, 23:59:59)
Loading attestation: [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard
Loading DKIM attestation for d=baylibre-com.20230601.gappssmtp.com, s=20230601
DKIM: sig: {b'v': b'1', b'a': b'rsa-sha256', b'c': b'relaxed/relaxed', b'd': b'baylibre-com.20230601.gappssmtp.com', b's': b'20230601', b't': b'1719941651', b'x': b'1720546451', b'darn': b'vger.kernel.org', b'h': b'cc:to:in-reply-to:references:message-id:content-transfer-encoding\r\n         :mime-version:subject:date:from:from:to:cc:subject:date:message-id\r\n         :reply-to', b'bh': b'E8NfF8jZGHkcRRoEHwh26DQAMmLR92lEfTyFLVBd7mk=', b'b': b'wjgEClSKZUgLm+5X2uffIcPZ8XKSVrPa9StW/UaOK5HuR6isRw6VJz5Abx/rf50QAK\r\n         kXoyWi3gZXDLrOqoXcGEVlQADzT5gdleupF0ljteP8kq3rDZuTH8zQphgZd1z3BvunqE\r\n         amG4Najj73fS73XTLLMMnVCA0nDi+RXZ82kYZDtzRelT5ljnj9cVx3pC2d5/EhEm5N4n\r\n         saRx1qzD+F0MB2TwYFKRfia3C618gHwpIsLwWzJW41EjofybfJNFG1TYpFzI8yr9LsC2\r\n         oPGOhUyASfS+bYAyBzQ1P38qh+ni12suKkDrOHDSdrZ+kJ/0UNmx2bBUMiQ16vnxJ97j\r\n         FiPA=='}
DKIM: bh: b'E8NfF8jZGHkcRRoEHwh26DQAMmLR92lEfTyFLVBd7mk='
DKIM: b'DKIM-Signature' valid: True
DKIM verify results: baylibre-com.20230601.gappssmtp.com=True
Attestors: 1
PASS : time drift between Date and t (-1 day, 23:59:59)
---
  ^[[32m✓^[[0m [PATCH v3 1/8] dt-bindings: iio: adc: adi,ad7606: normalize textwidth
Body contains non-ascii characters. Running Unicode Cf char tests.
Running git --no-pager mailinfo --encoding=UTF-8 --scissors /tmp/tmpzcodvutk/m /tmp/tmpzcodvutk/p
Loading attestation: Re: [PATCH v2 07/10] dt-bindings: iio: adc: adi,ad7606: add conditions
Loading DKIM attestation for d=kernel.org, s=k20201202
DKIM: sig: {b'v': b'1', b'a': b'rsa-sha256', b'c': b'relaxed/simple', b'd': b'kernel.org', b's': b'k20201202', b't': b'1719587717', b'bh': b'bu0ftpyAijuweDhRTmvWJVpSDGx2EDgXAxaHL4ijmww=', b'h': b'Date:From:To:Cc:Subject:References:In-Reply-To:From', b'b': b'sJf6Few/SMza311Oz8Dt5No3XiJ94XiQWAasODCybdXBiSeYvzAQlejnBa1Lato5U\r\n\t wyG5175CnhPJqSxeIQ4zw+MjsyidmYSmnGjSefsTbqXU+jgjx80Wq99amKuWLsyb3y\r\n\t sLqmVURhq4h1hUOVoA0w10ibFAEBciW1t5MIPGBYrBrNQI6DivjGg/VNHW1/ag6i3T\r\n\t IYKSCrRPCE7moJNURIlvC/3aBPQtVxe7onVmb1SIQ3t1o9Lz8ziKQThZdD6KgQHLBT\r\n\t 5IsYpjJOsLaMI2D0zXH5RvL+lfV7LOjCIC8R2avOqMX6SHf2IH3JPrkurxMUYdVV2I\r\n\t vGQQG9lKR8L+A=='}
DKIM: bh: b'bu0ftpyAijuweDhRTmvWJVpSDGx2EDgXAxaHL4ijmww='
DKIM: b'DKIM-Signature' valid: True
DKIM verify results: kernel.org=True
PASS : sig domain kernel.org matches from identity conor@kernel.org
Attestors: 1
    + Reviewed-by: Conor Dooley <conor.dooley@microchip.com> (^[[32m✓^[[0m DKIM/kernel.org)
Loading attestation: Re: [PATCH v2 04/10] dt-bindings: iio: adc: adi,ad7606: improve descriptions
Loading DKIM attestation for d=kernel.org, s=k20201202
DKIM: sig: {b'v': b'1', b'a': b'rsa-sha256', b'c': b'relaxed/simple', b'd': b'kernel.org', b's': b'k20201202', b't': b'1719854370', b'bh': b'F6Mg3Q9HtFWN3btjP5ziRej2VlTPFVg4j6vn1JweSfI=', b'h': b'Date:From:To:Cc:Subject:References:In-Reply-To:From', b'b': b'SHx7u0vLf+kFXkUaPhxUr8J78oY6ddSvwzn4tjHaO8qiAeZxuucFdRm2vDrZOO8T/\r\n\t MzL6oKjXa7TXAio2yY8E4j255UKeljiSIW91xWHq2iKYSyKPd+/HQlsBw6CkrGkrW4\r\n\t r847M5mE+gZH1TBnO4e79zptI8uxQ6DMyyJ4oUvEHdlCEEEZ8/3FOOCyNVJJSo/Fui\r\n\t J35ZkXzk3JMINehehfZdv3C5Hi9PzpGxocXfKB9ATBLm2LJVZK4Ya1D1IJjy7p1tuk\r\n\t qJEp9eHbZulMa6TTWvEHi/3ggMbjOjR6Uk6j5zdzemeUfZ/mFXLl01BCl75YZrTlNh\r\n\t pAxKYhOpNhVow=='}
DKIM: bh: b'F6Mg3Q9HtFWN3btjP5ziRej2VlTPFVg4j6vn1JweSfI='
DKIM: b'DKIM-Signature' valid: True
DKIM verify results: kernel.org=True
PASS : sig domain kernel.org matches from identity robh@kernel.org
Attestors: 1
    + Reviewed-by: Rob Herring (Arm) <robh@kernel.org> (^[[32m✓^[[0m DKIM/kernel.org)
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-1-57fd02a4e2aa@baylibre.com
  ^[[32m✓^[[0m [PATCH v3 2/8] dt-bindings: iio: adc: adi,ad7606: improve descriptions
Body contains non-ascii characters. Running Unicode Cf char tests.
Running git --no-pager mailinfo --encoding=UTF-8 --scissors /tmp/tmphavuehp5/m /tmp/tmphavuehp5/p
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-2-57fd02a4e2aa@baylibre.com
  ^[[32m✓^[[0m [PATCH v3 3/8] dt-bindings: iio: adc: adi,ad7606: add supply properties
Running git --no-pager mailinfo --encoding=UTF-8 --scissors /tmp/tmp3_24h10k/m /tmp/tmp3_24h10k/p
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-3-57fd02a4e2aa@baylibre.com
  ^[[32m✓^[[0m [PATCH v3 4/8] dt-bindings: iio: adc: adi,ad7606: fix example
Running git --no-pager mailinfo --encoding=UTF-8 --scissors /tmp/tmpcy04xgt3/m /tmp/tmpcy04xgt3/p
Loading attestation: Re: [PATCH 5/9] dt-bindings: iio: adc: adi,ad7606: add conditions
Loading DKIM attestation for d=kernel.org, s=k20201202
DKIM: sig: {b'v': b'1', b'a': b'rsa-sha256', b'c': b'relaxed/simple', b'd': b'kernel.org', b's': b'k20201202', b't': b'1718723637', b'bh': b'kWLzasd2Jv00eh2+ymMa0JXWplIZ46GqFdb45PLJiMs=', b'h': b'Date:From:To:Cc:Subject:References:In-Reply-To:From', b'b': b'JHP2taepLHd1qo2ZO3Fqo5kv42Y7HWK3Hvd4M9y2nQyamYsR5YFzzeg2qxzZaGeZB\r\n\t 7ZdRPOggnESPB72uGTfHtxrMYHUu9VivKEp62sFDgqw7t40OShbPhAyEmDwSujTM8L\r\n\t jlpJkJIwACiMEUKiXkgrJQS2ImsfaBlG+vo6JUZgmmw/lV7Tg1gZIUY4HFTjPIb/Xu\r\n\t UntfmSZN5WNXqR1Es9Jto/136eADuj73gdLn4T7FL3k9ui8XrhCxUm86sueii4+W/r\r\n\t 4Va9iKPlphFGvUY/fnde6a6Ahqk1mQxQRXUSHs0ZoEeLJo/FfhR8SRt6a7bbMF/DSc\r\n\t Cfl1P7hqIRE+g=='}
DKIM: bh: b'kWLzasd2Jv00eh2+ymMa0JXWplIZ46GqFdb45PLJiMs='
DKIM: b'DKIM-Signature' valid: True
DKIM verify results: kernel.org=True
PASS : sig domain kernel.org matches from identity conor@kernel.org
Attestors: 1
    + Reviewed-by: Conor Dooley <conor.dooley@microchip.com> (^[[32m✓^[[0m DKIM/kernel.org)
    + Reviewed-by: Rob Herring (Arm) <robh@kernel.org> (^[[32m✓^[[0m DKIM/kernel.org)
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-4-57fd02a4e2aa@baylibre.com
  ^[[32m✓^[[0m [PATCH v3 5/8] dt-bindings: iio: adc: adi,ad7606: add conditions
Body contains non-ascii characters. Running Unicode Cf char tests.
Running git --no-pager mailinfo --encoding=UTF-8 --scissors /tmp/tmpdbsjbqe5/m /tmp/tmpdbsjbqe5/p
    + Reviewed-by: Rob Herring (Arm) <robh@kernel.org> (^[[32m✓^[[0m DKIM/kernel.org)
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-5-57fd02a4e2aa@baylibre.com
  ^[[32m✓^[[0m [PATCH v3 6/8] iio: adc: ad7606: fix oversampling gpio array
Running git --no-pager mailinfo --encoding=UTF-8 --scissors /tmp/tmp07w7v2eu/m /tmp/tmp07w7v2eu/p
    + Reviewed-by: Conor Dooley <conor.dooley@microchip.com> (^[[32m✓^[[0m DKIM/kernel.org)
    + Reviewed-by: Rob Herring (Arm) <robh@kernel.org> (^[[32m✓^[[0m DKIM/kernel.org)
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-6-57fd02a4e2aa@baylibre.com
  ^[[32m✓^[[0m [PATCH v3 7/8] iio: adc: ad7606: fix standby gpio state to match the documentation
Running git --no-pager mailinfo --encoding=UTF-8 --scissors /tmp/tmparf0xuvu/m /tmp/tmparf0xuvu/p
    + Reviewed-by: Conor Dooley <conor.dooley@microchip.com> (^[[32m✓^[[0m DKIM/kernel.org)
    + Reviewed-by: Rob Herring (Arm) <robh@kernel.org> (^[[32m✓^[[0m DKIM/kernel.org)
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-7-57fd02a4e2aa@baylibre.com
  ^[[32m✓^[[0m [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard
Running git --no-pager mailinfo --encoding=UTF-8 --scissors /tmp/tmpypnbwtkn/m /tmp/tmpypnbwtkn/p
    + Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-8-57fd02a4e2aa@baylibre.com
  ---
  ^[[32m✓^[[0m Signed: DKIM/baylibre-com.20230601.gappssmtp.com (From: gstols@baylibre.com)
---
Total patches: 8
---
NOTE: some trailers ignored due to from/email mismatches:
    ! Trailer: Reviewed-by: Nuno Sa <nuno.sa@analog.com>
     Msg From: Nuno Sá <noname.nuno@gmail.com>
NOTE: Rerun with -S to apply them anyway
Running git --no-pager rev-parse --show-toplevel
---
Running git --no-pager mailinfo --encoding=UTF-8 --scissors /tmp/tmpnzax6wah/m /tmp/tmpnzax6wah/p
Cover: ./v3_20240702_gstols_iio_adc_ad7606_improvements.cover
 Link: https://patch.msgid.link/20240702-cleanup-ad7606-v3-0-57fd02a4e2aa@baylibre.com
Running git --no-pager --git-dir /home/jic23/src/kernel/iio/.git cat-file -e 340fa834ae229a952db04a57ed13fd5d35d75818
 Base: using specified base-commit 340fa834ae229a952db04a57ed13fd5d35d75818
       git checkout -b v3_20240702_gstols_baylibre_com 340fa834ae229a952db04a57ed13fd5d35d75818
       git am ./v3_20240702_gstols_iio_adc_ad7606_improvements.mbx
Wrote v3_20240702_gstols_iio_adc_ad7606_improvements.am for thanks tracking


> 
> -K

Re: [PATCH v3 0/8] iio: adc: ad7606: Improvements

[Jonathan Cameron]

On Tue, 02 Jul 2024 17:34:04 +0000
Guillaume Stols <gstols@baylibre.com> wrote:

> This series adds the following improvements over the current AD7606's
> driver implementation:
> 
> - Fix wrong usage of gpio array
> - Fix standby that was documented as ACTIVE_LOW but handled in the
>   driver as if it was ACTIVE_HIGH
> - Improve dt-bindings documentation
> - Switch mutex lock to scoped guard
> 
> Signed-off-by: Guillaume Stols <gstols@baylibre.com>
Given issues I'm having locally with b4 I applied these but added tags by hand.
Tweaked last patch description to mention guard() rather than scoped_guard()
to reflect changes in v3.

Thanks,

Jonathan

> ---
> Changes in v3:
> - Remove the two first patches that were already picked up.
> - Add styling corrections.
> - [Patch 6/8] Improve commit message.
> - [Patch 8/8] Replace every scoped_guard by simple guard.
> - Link to v2: https://lore.kernel.org/r/20240628-cleanup-ad7606-v2-0-96e02f90256d@baylibre.com
> 
> Changes in v2:
> - Change scoped guard to guard(mutex)(&st->lock). This was tested with
>   Rob's bot condition, and seems not to generate warning anymore.
> - Reorder the commits for avoiding bisection issues and respect commit
>   priority rules.
> - Add vdrive-supply to required properties.
> - Separate cosmetic changes from content ones in dt-binding
>   descriptions.
> - Move maxItems changes (and plural in descriptions) to the commit that
>   adds conditions.
> - Link to v1: https://lore.kernel.org/r/20240618-cleanup-ad7606-v1-0-f1854d5c779d@baylibre.com
> 
> ---
> Guillaume Stols (8):
>       dt-bindings: iio: adc: adi,ad7606: normalize textwidth
>       dt-bindings: iio: adc: adi,ad7606: improve descriptions
>       dt-bindings: iio: adc: adi,ad7606: add supply properties
>       dt-bindings: iio: adc: adi,ad7606: fix example
>       dt-bindings: iio: adc: adi,ad7606: add conditions
>       iio: adc: ad7606: fix oversampling gpio array
>       iio: adc: ad7606: fix standby gpio state to match the documentation
>       iio: adc: ad7606: switch mutexes to scoped_guard
> 
>  .../devicetree/bindings/iio/adc/adi,ad7606.yaml    | 123 ++++++++++++++++-----
>  drivers/iio/adc/ad7606.c                           |  47 ++++----
>  drivers/iio/adc/ad7606_spi.c                       |   5 +-
>  3 files changed, 115 insertions(+), 60 deletions(-)
> ---
> base-commit: 340fa834ae229a952db04a57ed13fd5d35d75818
> change-id: 20240416-cleanup-ad7606-161e2ed9818b
> 
> Best regards,