Re: [PATCH] iio: flow: slf3s: disable regulator if measurement restart fails

[Wadim Mueller <wafgo01@gmail.com>]

On 2026-09-01 10:50, Li Youhong wrote:

> From: Li Youhong <liyouhong@kylinos.cn>
>
> slf3s_resume() enables the vdd regulator and then starts continuous
> measurement. If slf3s_start_meas() fails, resume returns an error
> while leaving the regulator enabled. Disable vdd on that path so a
> failed resume does not leave the supply on.
>
> Fixes: d240b0b8a1ce ("iio: flow: add Sensirion SLF3S liquid flow sensor driver")
> Signed-off-by: Li Youhong <liyouhong@kylinos.cn>
> ---
>  drivers/iio/flow/slf3s.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/flow/slf3s.c b/drivers/iio/flow/slf3s.c
> index dfa7c1409045..9b63ceb3768a 100644
> --- a/drivers/iio/flow/slf3s.c
> +++ b/drivers/iio/flow/slf3s.c
> @@ -487,7 +487,11 @@ static int slf3s_resume(struct device *dev)
>  
>  	fsleep(SLF3S_POWER_UP_DELAY_US);
>  
> -	return slf3s_start_meas(sf, sf->medium);
> +	ret = slf3s_start_meas(sf, sf->medium);
> +	if (ret)
> +		regulator_disable(sf->vdd);
> +
> +	return ret;
>  }
>  
>  static DEFINE_SIMPLE_DEV_PM_OPS(slf3s_pm_ops, slf3s_suspend, slf3s_resume);
> -- 
> 2.25.1

Fixes the unbalanced regulator refcount across resume retries, as                             described.

Reviewed-by: Wadim Mueller <wafgo01@gmail.com>