From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Li Youhong <dayou5941@163.com>
Cc: wafgo01@gmail.com, jic23@kernel.org, maxwell@maxwelld.cc,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, Li Youhong <liyouhong@kylinos.cn>
Subject: Re: [PATCH] iio: flow: slf3s: disable regulator if measurement restart fails
Date: Thu, 3 Sep 2026 18:15:26 +0300 [thread overview]
Message-ID: <apmPDkkOBDYP6eEj@ashevche-desk.local> (raw)
In-Reply-To: <20260901025010.356735-1-dayou5941@163.com>
On Tue, Sep 01, 2026 at 10:50:10AM +0800, Li Youhong wrote:
> slf3s_resume() enables the vdd regulator and then starts continuous
> measurement. If slf3s_start_meas() fails, resume returns an error
> while leaving the regulator enabled. Disable vdd on that path so a
> failed resume does not leave the supply on.
In the scope of resume/suspend path this looks okay, but let's imagine
how it may work without this change. So, if resume fails, device will be
in suspend mode until it gets another resume attempt, right? Will it be
achievable at all? If so, then the regulator reference counting will go
sideways. That's what your patch is probably fixing? Needs a bit more of
an explanation in the commit message.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-03 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 2:50 [PATCH] iio: flow: slf3s: disable regulator if measurement restart fails Li Youhong
2026-09-03 15:15 ` Andy Shevchenko [this message]
2026-09-04 7:21 ` Wadim Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apmPDkkOBDYP6eEj@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dayou5941@163.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=liyouhong@kylinos.cn \
--cc=maxwell@maxwelld.cc \
--cc=nuno.sa@analog.com \
--cc=wafgo01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox