Linux IIO development
 help / color / mirror / Atom feed
* [PATCH v4 0/2] iio: adc: Add Maxim MAX11100 driver
@ 2017-01-13  9:50 Jacopo Mondi
  2017-01-13  9:50 ` [PATCH v4 1/2] " Jacopo Mondi
                   ` (2 more replies)
  0 siblings, 3 replies; 13+ messages in thread
From: Jacopo Mondi @ 2017-01-13  9:50 UTC (permalink / raw)
  To: wsa+renesas, magnus.damm, jic23, knaack.h, lars, pmeerw,
	marek.vasut, geert, robh+dt, mark.rutland
  Cc: linux-iio, devicetree, linux-renesas-soc

Hello,
   sending out v4 splitting device tree bindings documentation and actual ADC
driver.
No changes in driver code since v3.

Same question for iio maintainers here:
I would like to have clarified the measure unit returned by read_raw().
Currently (value_raw * value_scale) return the ADC input value in mV.
While testing the patch I've been questioned if that should not actually
be in uV. This is easily achievable making _scale return a value in uV.
I have found no mention of this in the ABI documentation as it speaks of
generic voltage.
Can we have a final word on this?

Thanks Marek for having tested this.

v1 -> v2:
    - incorporated pmeerw's review comments
    - retrieve vref from dts and use that to convert read_raw result
      to mV
    - add device tree bindings documentation

v2 -> v3:
    - add _SCALE bit of read_raw function and change _RAW bit accordingly
    - call regulator_get_voltage when accessing the _SCALE part of read_raw
      and not during probe
    - add back remove function as regulator has to be disabled when detaching
      the module. Do not use devm_ version of iio_register/unregister functions
      anymore but do unregister in the remove.
    - remove mutex as access to SPI bus is protected by SPI core. Thanks marex

v3 -> v4:
    - split device tree binding documentation and actual ADC driver
    - add "reg" to the list of required properties and use a better
      namimg for the adc device node in bindings documentation as suggested
      by Geert.

Jacopo Mondi (2):
  iio: adc: Add Maxim MAX11100 driver
  dt-bindings: iio: document MAX11100 ADC

 .../devicetree/bindings/iio/adc/max11100.txt       |  19 +++
 drivers/iio/adc/Kconfig                            |   9 +
 drivers/iio/adc/Makefile                           |   1 +
 drivers/iio/adc/max11100.c                         | 187 +++++++++++++++++++++
 4 files changed, 216 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/max11100.txt
 create mode 100644 drivers/iio/adc/max11100.c

-- 
2.7.4


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2017-01-17 21:03 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-13  9:50 [PATCH v4 0/2] iio: adc: Add Maxim MAX11100 driver Jacopo Mondi
2017-01-13  9:50 ` [PATCH v4 1/2] " Jacopo Mondi
2017-01-14 10:22   ` Jonathan Cameron
2017-01-15 12:18   ` Lars-Peter Clausen
2017-01-17 21:02   ` Wolfram Sang
2017-01-13  9:50 ` [PATCH v4 2/2] dt-bindings: iio: document MAX11100 ADC Jacopo Mondi
2017-01-13 10:04   ` Geert Uytterhoeven
2017-01-17 21:03   ` Wolfram Sang
2017-01-15 14:13 ` [PATCH v4 0/2] iio: adc: Add Maxim MAX11100 driver jacopo mondi
2017-01-15 14:31   ` Jonathan Cameron
2017-01-15 14:41     ` jacopo mondi
2017-01-15 14:45       ` Jonathan Cameron
2017-01-15 15:41     ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox