From: Dmitry Osipenko <digetx@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>, David Heidelberg <david@ixit.cz>
Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Daniel Baluta" <daniel.baluta@nxp.com>,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v4 4/7] iio: light: add Dyna-Image AL3010 driver
Date: Thu, 6 Feb 2020 17:55:09 +0300 [thread overview]
Message-ID: <9cc718bc-799f-f68f-02fe-695345d01dfd@gmail.com> (raw)
In-Reply-To: <20200206114806.5180a415@archlinux>
06.02.2020 14:48, Jonathan Cameron пишет:
> On Tue, 4 Feb 2020 10:30:34 +0100
> David Heidelberg <david@ixit.cz> wrote:
>
>> Based on:
>> - 3320A in-kernel driver
>> - https://www.spinics.net/lists/linux-iio/msg25145.html
>> - https://lore.kernel.org/patchwork/patch/684179/
>>
>> I decided to keep it aside of AL3320A due to different approach and much
>> simpler design of 3010.
>>
>> Tested on Nexus 7 2012 (grouper/tilapia).
>>
>> Tested-by: David Heidelberg <david@ixit.cz>
>> Tested-by: Dmitry Osipenko <digetx@gmail.com>
>> Tested-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
>> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>
>> v4:
>> - SQUASHed: iio: light: al3010 implement suspend support
>> - switched from _remove to devm_add_action_or_reset
>> - implement bitfields FIELD_PREP & FIELD_GET, no functionality change
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>
> This is fine as is, but you might want to think about adding basic
> regulator control as VDD might not be turned on.
> Then there is the follow up question on whether it is sensible to
> disable VDD in the suspend path.
Nexus 7 uses always-ON regulator for the AL3010 VDD. It should be better
if VDD enable/disable could be implemented by somebody who could
actually test it.
next prev parent reply other threads:[~2020-02-06 14:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 9:30 [PATCH v4 0/7] AL3010 introduction David Heidelberg
2020-02-04 9:30 ` [PATCH v4 1/7] dt-bindings: iio: light: add support for Dyna-Image AL3320A David Heidelberg
2020-02-06 19:07 ` Rob Herring
2020-02-06 21:16 ` David Heidelberg
2020-02-06 21:27 ` Rob Herring
2020-02-06 21:44 ` David Heidelberg
2020-02-04 9:30 ` [PATCH v4 2/7] dt-bindings: iio: light: add support for Dyna-Image AL3010 David Heidelberg
2020-02-04 9:52 ` Michał Mirosław
2020-02-04 15:10 ` Dmitry Osipenko
2020-02-04 9:30 ` [PATCH v4 3/7] iio: light: al3320a slightly improve code formatting David Heidelberg
2020-02-06 11:42 ` Jonathan Cameron
2020-02-06 14:50 ` Dmitry Osipenko
2020-02-06 14:51 ` Dmitry Osipenko
2020-02-04 9:30 ` [PATCH v4 4/7] iio: light: add Dyna-Image AL3010 driver David Heidelberg
2020-02-04 15:17 ` Dmitry Osipenko
2020-02-06 11:48 ` Jonathan Cameron
2020-02-06 14:55 ` Dmitry Osipenko [this message]
2020-02-04 9:30 ` [PATCH v4 5/7] iio: light: al3320a implement suspend support David Heidelberg
2020-02-04 9:30 ` [PATCH v4 6/7] iio: light: al3320a implement devm_add_action_or_reset David Heidelberg
2020-02-04 9:30 ` [PATCH v4 7/7] iio: light: al3320a allow module autoload and polish David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cc718bc-799f-f68f-02fe-695345d01dfd@gmail.com \
--to=digetx@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=david@ixit.cz \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox