From: Dmitry Osipenko <digetx@gmail.com>
To: "David Heidelberg" <david@ixit.cz>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Daniel Baluta" <daniel.baluta@nxp.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH v4 3/7] iio: light: al3320a slightly improve code formatting
Date: Thu, 6 Feb 2020 17:51:32 +0300 [thread overview]
Message-ID: <d66d93b2-6046-3f9e-80b0-1e7694e902b2@gmail.com> (raw)
In-Reply-To: <791299ad-c8e0-a94a-7dbb-780473c8346c@gmail.com>
06.02.2020 17:50, Dmitry Osipenko пишет:
> 04.02.2020 12:30, David Heidelberg пишет:
> ...
>> #define AL3320A_CONFIG_DISABLE 0x00
>> #define AL3320A_CONFIG_ENABLE 0x01
>>
>> -#define AL3320A_GAIN_SHIFT 1
>> -#define AL3320A_GAIN_MASK (BIT(2) | BIT(1))
>> +#define AL3320A_GAIN_MASK GENMASK(2, 1)
>
> Looks like you forgot to compile-test this driver because the
> AL3320A_GAIN_SHIFT is removed above, while it's still in-use below.
>
>> /* chip params default values */
>> #define AL3320A_DEFAULT_MEAN_TIME 4
>> @@ -90,7 +89,8 @@ static int al3320a_init(struct al3320a_data *data)
>> return ret;
>>
>> ret = i2c_smbus_write_byte_data(data->client, AL3320A_REG_CONFIG_RANGE,
>> - AL3320A_RANGE_3 << AL3320A_GAIN_SHIFT);
>> + FIELD_PREP(AL3320A_GAIN_MASK,
>> + AL3320A_RANGE_3));
> ...
>
Ah, my bad! Sorry :)
next prev parent reply other threads:[~2020-02-06 14:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 9:30 [PATCH v4 0/7] AL3010 introduction David Heidelberg
2020-02-04 9:30 ` [PATCH v4 1/7] dt-bindings: iio: light: add support for Dyna-Image AL3320A David Heidelberg
2020-02-06 19:07 ` Rob Herring
2020-02-06 21:16 ` David Heidelberg
2020-02-06 21:27 ` Rob Herring
2020-02-06 21:44 ` David Heidelberg
2020-02-04 9:30 ` [PATCH v4 2/7] dt-bindings: iio: light: add support for Dyna-Image AL3010 David Heidelberg
2020-02-04 9:52 ` Michał Mirosław
2020-02-04 15:10 ` Dmitry Osipenko
2020-02-04 9:30 ` [PATCH v4 3/7] iio: light: al3320a slightly improve code formatting David Heidelberg
2020-02-06 11:42 ` Jonathan Cameron
2020-02-06 14:50 ` Dmitry Osipenko
2020-02-06 14:51 ` Dmitry Osipenko [this message]
2020-02-04 9:30 ` [PATCH v4 4/7] iio: light: add Dyna-Image AL3010 driver David Heidelberg
2020-02-04 15:17 ` Dmitry Osipenko
2020-02-06 11:48 ` Jonathan Cameron
2020-02-06 14:55 ` Dmitry Osipenko
2020-02-04 9:30 ` [PATCH v4 5/7] iio: light: al3320a implement suspend support David Heidelberg
2020-02-04 9:30 ` [PATCH v4 6/7] iio: light: al3320a implement devm_add_action_or_reset David Heidelberg
2020-02-04 9:30 ` [PATCH v4 7/7] iio: light: al3320a allow module autoload and polish David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d66d93b2-6046-3f9e-80b0-1e7694e902b2@gmail.com \
--to=digetx@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=david@ixit.cz \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox