From: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>
To: "Andy Shevchenko" <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Rishi Gupta" <gupt21@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] iio: light: veml6030: remove unnecessary read of IT index
Date: Thu, 14 May 2026 07:17:24 +1300 [thread overview]
Message-ID: <DIHR7242IVEQ.HZ3NLNX0G9E1@gmail.com> (raw)
In-Reply-To: <agSt_TGpyujxqrZc@ashevche-desk.local>
On Thu May 14, 2026 at 5:59 AM +13, Andy Shevchenko wrote:
> On Wed, May 13, 2026 at 05:49:41PM +1300, Javier Carrasco wrote:
>> This is dead code as the IT index is not used by gts to set the new scale.
>> In its current form, the value is read but not used afterward. Remove
>> the dead code.
>
> Does it have any side-effects on the HW side? Exempli gratia, flushing FIFO,
> R1C (read to clear 1) bits?
>
>> Fixes: 22eaca4283b2 ("iio: light: veml6030: fix scale to conform to ABI")
>
> Not sure it fixes anything. But it might regress, see above why.
>
> ...
>
> If no side-effects, the code wise looks good.
Hi Andy,
This patch does not have side effects on the HW side. Apart from having
it tested with real HW, the operation being handled here is setting a
new scale, which is stored in a persistent register.
Best regards,
Javier
next prev parent reply other threads:[~2026-05-13 18:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 4:49 [PATCH v2 0/4] iio: light: add support for veml6031x00 ALS series Javier Carrasco
2026-05-13 4:49 ` [PATCH v2 1/4] iio: light: veml6030: remove unnecessary read of IT index Javier Carrasco
2026-05-13 16:59 ` Andy Shevchenko
2026-05-13 18:17 ` Javier Carrasco [this message]
2026-05-13 19:58 ` Andy Shevchenko
2026-05-13 4:49 ` [PATCH v2 2/4] iio: light: veml6030: fix channel type when pushing events Javier Carrasco
2026-05-13 17:48 ` Andy Shevchenko
2026-05-13 18:13 ` Javier Carrasco
2026-05-13 20:02 ` Andy Shevchenko
2026-05-13 4:49 ` [PATCH v2 3/4] dt-bindings: iio: light: veml6030: add veml6031x00 ALS series Javier Carrasco
2026-05-13 4:49 ` [PATCH v2 4/4] iio: light: add support for " Javier Carrasco
[not found] ` <690B63AD-4429-4045-B413-29911ED7DA3D@gmail.com>
2026-05-13 16:36 ` Andy Shevchenko
2026-05-13 16:37 ` Andy Shevchenko
2026-05-13 16:56 ` Andy Shevchenko
2026-05-13 18:23 ` Javier Carrasco
2026-05-13 20:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIHR7242IVEQ.HZ3NLNX0G9E1@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gupt21@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox