From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Rishi Gupta" <gupt21@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] iio: light: veml6030: fix channel type when pushing events
Date: Wed, 13 May 2026 20:48:14 +0300 [thread overview]
Message-ID: <agS5Xu8ORtEwuwOB@ashevche-desk.local> (raw)
In-Reply-To: <20260513-veml6031x00-v2-2-4703ca661a1d@gmail.com>
On Wed, May 13, 2026 at 05:49:42PM +1300, Javier Carrasco wrote:
> The events are registered for IIO_LIGHT and not for IIO_INTENSITY.
> Use the correct channel type.
> This bug was introduced in the first version of the driver.
Unneeded detail, if it's a bug, use Fixes tag.
> When at it, fix minor checkpatch code style warning (alignment).
...
> - iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_INTENSITY,
> - 0, IIO_EV_TYPE_THRESH, evtdir),
> - iio_get_time_ns(indio_dev));
> + iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_LIGHT,
> + 0,
> + IIO_EV_TYPE_THRESH,
> + evtdir),
> + iio_get_time_ns(indio_dev));
AFAICS the indentation is still broken. Why not doing like this:
iio_push_event(indio_dev,
IIO_UNMOD_EVENT_CODE(IIO_LIGHT, 0, IIO_EV_TYPE_THRESH, evtdir),
iio_get_time_ns(indio_dev));
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-13 17:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 4:49 [PATCH v2 0/4] iio: light: add support for veml6031x00 ALS series Javier Carrasco
2026-05-13 4:49 ` [PATCH v2 1/4] iio: light: veml6030: remove unnecessary read of IT index Javier Carrasco
2026-05-13 16:59 ` Andy Shevchenko
2026-05-13 18:17 ` Javier Carrasco
2026-05-13 19:58 ` Andy Shevchenko
2026-05-13 4:49 ` [PATCH v2 2/4] iio: light: veml6030: fix channel type when pushing events Javier Carrasco
2026-05-13 17:48 ` Andy Shevchenko [this message]
2026-05-13 18:13 ` Javier Carrasco
2026-05-13 20:02 ` Andy Shevchenko
2026-05-13 20:44 ` Javier Carrasco
2026-05-13 20:56 ` Andy Shevchenko
2026-05-13 4:49 ` [PATCH v2 3/4] dt-bindings: iio: light: veml6030: add veml6031x00 ALS series Javier Carrasco
2026-05-13 4:49 ` [PATCH v2 4/4] iio: light: add support for " Javier Carrasco
[not found] ` <690B63AD-4429-4045-B413-29911ED7DA3D@gmail.com>
2026-05-13 16:36 ` Andy Shevchenko
2026-05-13 16:37 ` Andy Shevchenko
2026-05-13 16:56 ` Andy Shevchenko
2026-05-13 18:23 ` Javier Carrasco
2026-05-13 20:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agS5Xu8ORtEwuwOB@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gupt21@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox