Re: [PATCH] iio: adc: mcp3422: use sysfs_emit() in show functions

["Maxwell Doose" <maxwell@maxwelld.cc>]

Hello,

On Sat Sep 19, 2026 at 2:55 PM CDT
Angel2Eyes <thefireking@gmail.com> wrote:

> sysfs_emit() is preferred over sprintf() for sysfs show() callbacks
> since it is aware of the PAGE_SIZE buffer and has built-in size and
> alignment checks.
>
> Convert the remaining sprintf() calls in mcp3422_show_samp_freqs() and
> mcp3422_show_scales(). The formatted output is unchanged.
>
> Assisted-by: LLM

Pretty sure this should be the name of the LLM used (feel free to
correct me if I'm wrong though).

> Signed-off-by: Angel2Eyes <thefireking@gmail.com>

The DCO requires the use of a known identity (e.g. <first> <last>),
but this does not seem to be one.

Please read Documentation/process/submitting-patches.rst next time.

> ---
>  drivers/iio/adc/mcp3422.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/mcp3422.c b/drivers/iio/adc/mcp3422.c
> index 36ba00edf..fd9e72265 100644
> --- a/drivers/iio/adc/mcp3422.c
> +++ b/drivers/iio/adc/mcp3422.c
> @@ -262,9 +262,9 @@ static ssize_t mcp3422_show_samp_freqs(struct device *dev,
>  	struct mcp3422 *adc = iio_priv(dev_to_iio_dev(dev));
>  
>  	if (adc->id > 4)
> -		return sprintf(buf, "240 60 15\n");
> +		return sysfs_emit(buf, "240 60 15\n");
>  
> -	return sprintf(buf, "240 60 15 3\n");
> +	return sysfs_emit(buf, "240 60 15 3\n");
>  }
>  
>  static ssize_t mcp3422_show_scales(struct device *dev,
> @@ -273,7 +273,7 @@ static ssize_t mcp3422_show_scales(struct device *dev,
>  	struct mcp3422 *adc = iio_priv(dev_to_iio_dev(dev));
>  	u8 sample_rate = FIELD_GET(MCP3422_SRATE_MASK, adc->config);
>  
> -	return sprintf(buf, "0.%09u 0.%09u 0.%09u 0.%09u\n",
> +	return sysfs_emit(buf, "0.%09u 0.%09u 0.%09u 0.%09u\n",
>  		mcp3422_scales[sample_rate][0],
>  		mcp3422_scales[sample_rate][1],
>  		mcp3422_scales[sample_rate][2],
>
> base-commit: 69fa76f0af3414cc189c3b0b807cb59e327ecc00