From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Yuval Saar <thefireking@gmail.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
maxwell@maxwelld.cc
Subject: Re: [PATCH v3 1/2] iio: adc: mcp3422: describe parts with chip_info
Date: Sat, 3 Oct 2026 23:37:29 +0300 [thread overview]
Message-ID: <asFniVfXlEW_7PAw@ashevche-desk.local> (raw)
In-Reply-To: <20261003001647.1975549-2-thefireking@gmail.com>
On Sat, Oct 03, 2026 at 03:16:46AM +0300, Yuval Saar wrote:
> The driver encodes MCP3421-8 differences as integer ids and switches
> on them in probe. Point i2c_device_id.driver_data at a per-chip
> structure instead, and keep the channel list and 3 SPS support there.
>
> Compile tested. No hardware.
...
> adc->i2c = client;
+ Blank line.
> - adc->id = (u8)(id->driver_data);
> + adc->chip_info = i2c_get_match_data(client);
> + if (!adc->chip_info)
> + return -ENODEV;
-ENODATA
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-03 20:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 19:55 [PATCH] iio: adc: mcp3422: use sysfs_emit() in show functions Angel2Eyes
2026-09-19 22:33 ` Maxwell Doose
2026-09-19 22:45 ` Joshua Crofts
2026-09-20 0:30 ` Jonathan Cameron
2026-09-20 16:00 ` [PATCH v2] iio: adc: mcp3422: use read_avail() for available attributes Yuval Saar
2026-09-21 3:47 ` Jonathan Cameron
2026-09-25 16:50 ` Andy Shevchenko
2026-10-03 0:16 ` [PATCH v3 0/2] iio: adc: mcp3422: chip info and read_avail() Yuval Saar
2026-10-03 0:16 ` [PATCH v3 1/2] iio: adc: mcp3422: describe parts with chip_info Yuval Saar
2026-10-03 20:37 ` Andy Shevchenko [this message]
2026-10-04 16:38 ` Jonathan Cameron
2026-10-03 0:16 ` [PATCH v3 2/2] iio: adc: mcp3422: use read_avail() for available attributes Yuval Saar
2026-10-03 13:40 ` [PATCH v3 0/2] iio: adc: mcp3422: chip info and read_avail() Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asFniVfXlEW_7PAw@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=maxwell@maxwelld.cc \
--cc=nuno.sa@analog.com \
--cc=thefireking@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox