From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: Hungyu Lin <dennylin0707@gmail.com>,
lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/1] dt-bindings: iio: dds: Add AD9832/AD9835 binding
Date: Sat, 09 May 2026 07:40:55 +0530 [thread overview]
Message-ID: <F55DA41F-BF95-401B-BF6C-0FAF93EB2704@gmail.com> (raw)
In-Reply-To: <20260509013745.80478-1-dennylin0707@gmail.com>
On 9 May 2026 7:07:44 am IST, Hungyu Lin <dennylin0707@gmail.com> wrote:
>This series adds devicetree binding documentation for the
>Analog Devices AD9832 and AD9835 DDS devices.
>
>v3:
> - Require spi-cpol in binding and example
> - Use generic node name (dds@0) in example
>
Hi,
Thank you for the change.
Ideally, multiple logical changes should be split into series. For a single patch you can include changelog like this:
Signed-off-by: ....
---
Changes in v2:
- Add SPI peripheral schema reference
---
.../bindings..
| 94 +++++++++++++++++++
If reviewer specifically asked to update, you can mention in the changelog as well. for examle:
- Add SPI peripheral schema reference based on review comment from <Reviewer Name>
Replace <Reviewer Name> with the actual reviewer.
Thanks,
Sanjay
>v2:
> - Add SPI peripheral schema reference
> - Fix example by adding clock and regulator providers
> - Fix SPDX license format
>
>Hungyu Lin (1):
> dt-bindings: iio: dds: Add AD9832/AD9835 binding
>
> .../bindings/iio/dds/adi,ad9832.yaml | 91 +++++++++++++++++++
> 1 file changed, 91 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
>
prev parent reply other threads:[~2026-05-09 2:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 1:37 [PATCH v3 0/1] dt-bindings: iio: dds: Add AD9832/AD9835 binding Hungyu Lin
2026-05-09 1:37 ` [PATCH v3 1/1] " Hungyu Lin
2026-05-09 2:20 ` Sanjay Chitroda
2026-05-09 2:10 ` Sanjay Chitroda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F55DA41F-BF95-401B-BF6C-0FAF93EB2704@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dennylin0707@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox