[PATCH v3 0/1] dt-bindings: iio: dds: Add AD9832/AD9835 binding

[PATCH v3 0/1] dt-bindings: iio: dds: Add AD9832/AD9835 binding

[Hungyu Lin]

This series adds devicetree binding documentation for the
Analog Devices AD9832 and AD9835 DDS devices.

v3:
  - Require spi-cpol in binding and example
  - Use generic node name (dds@0) in example

v2:
  - Add SPI peripheral schema reference
  - Fix example by adding clock and regulator providers
  - Fix SPDX license format

Hungyu Lin (1):
  dt-bindings: iio: dds: Add AD9832/AD9835 binding

 .../bindings/iio/dds/adi,ad9832.yaml          | 91 +++++++++++++++++++
 1 file changed, 91 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml

-- 
2.34.1

[PATCH v3 1/1] dt-bindings: iio: dds: Add AD9832/AD9835 binding

[Hungyu Lin]

Add devicetree binding documentation for AD9832 and AD9835 DDS devices.

These devices are SPI-controlled direct digital synthesizers
requiring AVDD, DVDD supplies and an external master clock.

Require spi-cpol since AD9832/AD9835 use SPI mode 2.
Update the example to include spi-cpol and use a generic node name.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 .../bindings/iio/dds/adi,ad9832.yaml          | 91 +++++++++++++++++++
 1 file changed, 91 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml

diff --git a/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
new file mode 100644
index 000000000000..9f3e41cb0a0d
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/dds/adi,ad9832.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD9832 / AD9835 DDS
+
+maintainers:
+  - Hungyu Lin <dennylin0707@gmail.com>
+
+description: |
+  Binding for Analog Devices AD9832 and AD9835 SPI-controlled direct
+  digital synthesizers (DDS). The devices use an external master clock
+  and are controlled over a serial SPI-compatible interface.
+
+properties:
+  compatible:
+    enum:
+      - adi,ad9832
+      - adi,ad9835
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 20000000
+
+  spi-cpol: true
+
+  clocks:
+    maxItems: 1
+    description:
+      External master clock input.
+
+  clock-names:
+    const: mclk
+
+  avdd-supply:
+    description:
+      Analog power supply.
+
+  dvdd-supply:
+    description:
+      Digital power supply.
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - avdd-supply
+  - dvdd-supply
+  - spi-cpol
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    mclk: clock {
+      compatible = "fixed-clock";
+      #clock-cells = <0>;
+      clock-frequency = <25000000>;
+    };
+
+    vdd_3v3: regulator {
+      compatible = "regulator-fixed";
+      regulator-name = "vdd_3v3";
+      regulator-min-microvolt = <3300000>;
+      regulator-max-microvolt = <3300000>;
+      regulator-always-on;
+    };
+
+    spi {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      dds@0 {
+        compatible = "adi,ad9832";
+        reg = <0>;
+        spi-max-frequency = <20000000>;
+        spi-cpol;
+        clocks = <&mclk>;
+        clock-names = "mclk";
+        avdd-supply = <&vdd_3v3>;
+        dvdd-supply = <&vdd_3v3>;
+      };
+    };
-- 
2.34.1

Re: [PATCH v3 0/1] dt-bindings: iio: dds: Add AD9832/AD9835 binding

[Sanjay Chitroda]

On 9 May 2026 7:07:44 am IST, Hungyu Lin <dennylin0707@gmail.com> wrote:
>This series adds devicetree binding documentation for the
>Analog Devices AD9832 and AD9835 DDS devices.
>
>v3:
>  - Require spi-cpol in binding and example
>  - Use generic node name (dds@0) in example
>

Hi,

Thank you for the change.

Ideally, multiple logical changes should be split into series. For a single patch you can include changelog like this:

Signed-off-by: ....
---
Changes in v2:
- Add SPI peripheral schema reference
---
 .../bindings..
         | 94 +++++++++++++++++++

If reviewer specifically asked to update, you can mention in the changelog as well. for examle:

- Add SPI peripheral schema reference based on review comment from <Reviewer Name>

Replace <Reviewer Name> with the actual reviewer.

Thanks,
Sanjay

>v2:
>  - Add SPI peripheral schema reference
>  - Fix example by adding clock and regulator providers
>  - Fix SPDX license format
>
>Hungyu Lin (1):
>  dt-bindings: iio: dds: Add AD9832/AD9835 binding
>
> .../bindings/iio/dds/adi,ad9832.yaml          | 91 +++++++++++++++++++
> 1 file changed, 91 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
>

Re: [PATCH v3 1/1] dt-bindings: iio: dds: Add AD9832/AD9835 binding

[Sanjay Chitroda]

On 9 May 2026 7:07:45 am IST, Hungyu Lin <dennylin0707@gmail.com> wrote:
>Add devicetree binding documentation for AD9832 and AD9835 DDS devices.
>

Hi,

It looks like you have sent multiple patch versions within 24 hours.

I would suggest taking some additional time for development and validation before sending updates to the mailing list. It is also good to allow reviewers enough time to provide feedback, atleast a minimum of 24 hours.

Please be patient and wait for a few days, or ideally upto week, so reviewers have sufficient time to review the changes properly.

Thanks, Sanjay 

>These devices are SPI-controlled direct digital synthesizers
>requiring AVDD, DVDD supplies and an external master clock.
>
>Require spi-cpol since AD9832/AD9835 use SPI mode 2.
>Update the example to include spi-cpol and use a generic node name.
>
>Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
>---
> .../bindings/iio/dds/adi,ad9832.yaml          | 91 +++++++++++++++++++
> 1 file changed, 91 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
>
>diff --git a/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
>new file mode 100644
>index 000000000000..9f3e41cb0a0d
>--- /dev/null
>+++ b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
>@@ -0,0 +1,91 @@
>+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>+%YAML 1.2
>+---
>+$id: http://devicetree.org/schemas/iio/dds/adi,ad9832.yaml#
>+$schema: http://devicetree.org/meta-schemas/core.yaml#
>+
>+title: Analog Devices AD9832 / AD9835 DDS
>+
>+maintainers:
>+  - Hungyu Lin <dennylin0707@gmail.com>
>+
>+description: |
>+  Binding for Analog Devices AD9832 and AD9835 SPI-controlled direct
>+  digital synthesizers (DDS). The devices use an external master clock
>+  and are controlled over a serial SPI-compatible interface.
>+
>+properties:
>+  compatible:
>+    enum:
>+      - adi,ad9832
>+      - adi,ad9835
>+
>+  reg:
>+    maxItems: 1
>+
>+  spi-max-frequency:
>+    maximum: 20000000
>+
>+  spi-cpol: true
>+
>+  clocks:
>+    maxItems: 1
>+    description:
>+      External master clock input.
>+
>+  clock-names:
>+    const: mclk
>+
>+  avdd-supply:
>+    description:
>+      Analog power supply.
>+
>+  dvdd-supply:
>+    description:
>+      Digital power supply.
>+
>+required:
>+  - compatible
>+  - reg
>+  - clocks
>+  - clock-names
>+  - avdd-supply
>+  - dvdd-supply
>+  - spi-cpol
>+
>+allOf:
>+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
>+
>+unevaluatedProperties: false
>+
>+examples:
>+  - |
>+    mclk: clock {
>+      compatible = "fixed-clock";
>+      #clock-cells = <0>;
>+      clock-frequency = <25000000>;
>+    };
>+
>+    vdd_3v3: regulator {
>+      compatible = "regulator-fixed";
>+      regulator-name = "vdd_3v3";
>+      regulator-min-microvolt = <3300000>;
>+      regulator-max-microvolt = <3300000>;
>+      regulator-always-on;
>+    };
>+
>+    spi {
>+      #address-cells = <1>;
>+      #size-cells = <0>;
>+
>+      dds@0 {
>+        compatible = "adi,ad9832";
>+        reg = <0>;
>+        spi-max-frequency = <20000000>;
>+        spi-cpol;
>+        clocks = <&mclk>;
>+        clock-names = "mclk";
>+        avdd-supply = <&vdd_3v3>;
>+        dvdd-supply = <&vdd_3v3>;
>+      };
>+    };