[PATCH v2 0/2] counter: push event on every pulse

[PATCH v2 0/2] counter: push event on every pulse

[Oleksij Rempel]

changes v2
- rebase against latest kernel and fix some regressions
- add COUNTER_EVENT_CHANGE_OF_STATE event

Add support of push even on every pulse.

Oleksij Rempel (2):
  counter: add new COUNTER_EVENT_CHANGE_OF_STATE
  counter: interrupt-cnt: add counter_push_event()

 drivers/counter/interrupt-cnt.c | 7 +++++--
 include/uapi/linux/counter.h    | 2 ++
 2 files changed, 7 insertions(+), 2 deletions(-)

-- 
2.30.2

[PATCH v2 1/2] counter: add new COUNTER_EVENT_CHANGE_OF_STATE

[Oleksij Rempel]

Add new counter event to notify user space about every new counter
pulse.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 include/uapi/linux/counter.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/uapi/linux/counter.h b/include/uapi/linux/counter.h
index d0aa95aeff7b..96c5ffd368ad 100644
--- a/include/uapi/linux/counter.h
+++ b/include/uapi/linux/counter.h
@@ -61,6 +61,8 @@ enum counter_event_type {
 	COUNTER_EVENT_THRESHOLD,
 	/* Index signal detected */
 	COUNTER_EVENT_INDEX,
+	/* State of counter is changed */
+	COUNTER_EVENT_CHANGE_OF_STATE,
 };
 
 /**
-- 
2.30.2

[PATCH v2 2/2] counter: interrupt-cnt: add counter_push_event()

[Oleksij Rempel]

Add counter_push_event() to notify user space about new pulses

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/counter/interrupt-cnt.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cnt.c
index 9e99702470c2..3b13f56bbb11 100644
--- a/drivers/counter/interrupt-cnt.c
+++ b/drivers/counter/interrupt-cnt.c
@@ -26,10 +26,13 @@ struct interrupt_cnt_priv {
 
 static irqreturn_t interrupt_cnt_isr(int irq, void *dev_id)
 {
-	struct interrupt_cnt_priv *priv = dev_id;
+	struct counter_device *counter = dev_id;
+	struct interrupt_cnt_priv *priv = counter_priv(counter);
 
 	atomic_inc(&priv->count);
 
+	counter_push_event(counter, COUNTER_EVENT_CHANGE_OF_STATE, 0);
+
 	return IRQ_HANDLED;
 }
 
@@ -209,7 +212,7 @@ static int interrupt_cnt_probe(struct platform_device *pdev)
 	irq_set_status_flags(priv->irq, IRQ_NOAUTOEN);
 	ret = devm_request_irq(dev, priv->irq, interrupt_cnt_isr,
 			       IRQF_TRIGGER_RISING | IRQF_NO_THREAD,
-			       dev_name(dev), priv);
+			       dev_name(dev), counter);
 	if (ret)
 		return ret;
 
-- 
2.30.2

Re: [PATCH v2 2/2] counter: interrupt-cnt: add counter_push_event()

[William Breathitt Gray]

[-- Attachment #1: Type: text/plain, Size: 1699 bytes --]

On Thu, Feb 03, 2022 at 02:57:27PM +0100, Oleksij Rempel wrote:
> Add counter_push_event() to notify user space about new pulses
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

This is a simple solution so if it works for your use-case I'm okay with
it; I think future counter devices could make use of this new
COUNTER_EVENT_CHANGE_OF_STATE event type too, so that's a plus.

I'm going to wait a week to give others time to chime in if they want.
Otherwise I'll give a proper approval for this series next week.

William Breathitt Gray

> ---
>  drivers/counter/interrupt-cnt.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cnt.c
> index 9e99702470c2..3b13f56bbb11 100644
> --- a/drivers/counter/interrupt-cnt.c
> +++ b/drivers/counter/interrupt-cnt.c
> @@ -26,10 +26,13 @@ struct interrupt_cnt_priv {
>  
>  static irqreturn_t interrupt_cnt_isr(int irq, void *dev_id)
>  {
> -	struct interrupt_cnt_priv *priv = dev_id;
> +	struct counter_device *counter = dev_id;
> +	struct interrupt_cnt_priv *priv = counter_priv(counter);
>  
>  	atomic_inc(&priv->count);
>  
> +	counter_push_event(counter, COUNTER_EVENT_CHANGE_OF_STATE, 0);
> +
>  	return IRQ_HANDLED;
>  }
>  
> @@ -209,7 +212,7 @@ static int interrupt_cnt_probe(struct platform_device *pdev)
>  	irq_set_status_flags(priv->irq, IRQ_NOAUTOEN);
>  	ret = devm_request_irq(dev, priv->irq, interrupt_cnt_isr,
>  			       IRQF_TRIGGER_RISING | IRQF_NO_THREAD,
> -			       dev_name(dev), priv);
> +			       dev_name(dev), counter);
>  	if (ret)
>  		return ret;
>  
> -- 
> 2.30.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 0/2] counter: push event on every pulse

[William Breathitt Gray]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

On Thu, Feb 03, 2022 at 02:57:25PM +0100, Oleksij Rempel wrote:
> changes v2
> - rebase against latest kernel and fix some regressions
> - add COUNTER_EVENT_CHANGE_OF_STATE event
> 
> Add support of push even on every pulse.
> 
> Oleksij Rempel (2):
>   counter: add new COUNTER_EVENT_CHANGE_OF_STATE
>   counter: interrupt-cnt: add counter_push_event()
> 
>  drivers/counter/interrupt-cnt.c | 7 +++++--
>  include/uapi/linux/counter.h    | 2 ++
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> -- 
> 2.30.2

Thank you Oleksij, I'm picking this up now and I'll submit it with the
rest of the Counter patches for this cycle.

William Breathitt Gray

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]