* [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean
@ 2023-04-22 14:27 Rong Tao
2023-04-22 16:08 ` William Breathitt Gray
2023-04-23 13:45 ` William Breathitt Gray
0 siblings, 2 replies; 4+ messages in thread
From: Rong Tao @ 2023-04-22 14:27 UTC (permalink / raw)
To: william.gray; +Cc: Rong Tao, open list:COUNTER SUBSYSTEM, open list
From: Rong Tao <rongtao@cestc.cn>
'make' create 'include' directory, we should remove it when 'make clean'.
Signed-off-by: Rong Tao <rongtao@cestc.cn>
---
v2: this commit, according to William Breathitt Gray's suggession in v1
v1: https://lore.kernel.org/lkml/tencent_FA682F628E818DD04B96C3E5A94ACFABE206@qq.com/
---
tools/counter/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/counter/Makefile b/tools/counter/Makefile
index 8843f0fa6119..a0f4cab71fe5 100644
--- a/tools/counter/Makefile
+++ b/tools/counter/Makefile
@@ -40,6 +40,7 @@ $(OUTPUT)counter_example: $(COUNTER_EXAMPLE)
clean:
rm -f $(ALL_PROGRAMS)
rm -rf $(OUTPUT)include/linux/counter.h
+ rmdir -p $(OUTPUT)include/linux
find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
install: $(ALL_PROGRAMS)
--
2.40.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean
2023-04-22 14:27 [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean Rong Tao
@ 2023-04-22 16:08 ` William Breathitt Gray
2023-04-23 0:22 ` Rong Tao
2023-04-23 13:45 ` William Breathitt Gray
1 sibling, 1 reply; 4+ messages in thread
From: William Breathitt Gray @ 2023-04-22 16:08 UTC (permalink / raw)
To: Rong Tao; +Cc: Rong Tao, open list:COUNTER SUBSYSTEM, open list
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
On Sat, Apr 22, 2023 at 10:27:38PM +0800, Rong Tao wrote:
> From: Rong Tao <rongtao@cestc.cn>
>
> 'make' create 'include' directory, we should remove it when 'make clean'.
>
> Signed-off-by: Rong Tao <rongtao@cestc.cn>
Hi Rong,
The code changes in this v2 are acceptable for me now, but I would like
the commit description typos fixed. I can fix it myself when I apply
this patch so that you don't need to submit a v3. Would you be okay if I
did that?
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean
2023-04-22 14:27 [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean Rong Tao
2023-04-22 16:08 ` William Breathitt Gray
@ 2023-04-23 13:45 ` William Breathitt Gray
1 sibling, 0 replies; 4+ messages in thread
From: William Breathitt Gray @ 2023-04-23 13:45 UTC (permalink / raw)
To: Rong Tao; +Cc: william.gray, Rong Tao, open list:COUNTER SUBSYSTEM, open list
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
On Sat, Apr 22, 2023 at 10:27:38PM +0800, Rong Tao wrote:
> From: Rong Tao <rongtao@cestc.cn>
>
> 'make' create 'include' directory, we should remove it when 'make clean'.
>
> Signed-off-by: Rong Tao <rongtao@cestc.cn>
Queued (with minor commit description cleanup) for the counter-next
branch of the Counter tree.
Thank you,
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-23 13:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-22 14:27 [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean Rong Tao
2023-04-22 16:08 ` William Breathitt Gray
2023-04-23 0:22 ` Rong Tao
2023-04-23 13:45 ` William Breathitt Gray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox