From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Alejandro Tafalla <atafalla@dnyon.com>
Cc: jic23@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH] iio: imu: lsm6dsx: Fix mount matrix retrieval
Date: Wed, 12 Jul 2023 13:04:05 +0200 [thread overview]
Message-ID: <ZK6IpZvG47zsKZFk@lore-rh-laptop> (raw)
In-Reply-To: <12960181.O9o76ZdvQC@alexpc>
[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]
> The function lsm6dsx_get_acpi_mount_matrix should return true when ACPI
> support is not enabled to allow executing iio_read_mount_matrix in the
> probe function.
>
> Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")
>
> Signed-off-by: Alejandro Tafalla <atafalla@dnyon.com>
> ---
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/
> st_lsm6dsx/st_lsm6dsx_core.c
> index 6a18b363cf73..62bc3ee783fb 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct device
> *dev,
> static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> struct
> iio_mount_matrix *orientation)
> {
> - return false;
> + return true;
I would say it should return something like -EOPNOTSUPP.
Regards,
Lorenzo
> }
>
> #endif
> --
> 2.41.0
>
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-07-12 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 10:32 [PATCH] iio: imu: lsm6dsx: Fix mount matrix retrieval Alejandro Tafalla
2023-07-12 11:04 ` Lorenzo Bianconi [this message]
2023-07-12 18:24 ` Alejandro Tafalla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK6IpZvG47zsKZFk@lore-rh-laptop \
--to=lorenzo@kernel.org \
--cc=atafalla@dnyon.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox