* [PATCH] iio: magnetometer: ak8975: Convert enum->pointer for data in the match tables
@ 2023-08-16 18:40 Biju Das
2023-08-17 10:26 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Biju Das @ 2023-08-16 18:40 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Biju Das, Lars-Peter Clausen, Uwe Kleine-König,
Andy Shevchenko, linux-iio, Geert Uytterhoeven, linux-renesas-soc
Convert enum->pointer for data in the match tables to simplify the probe()
by replacing device_get_match_data() and i2c_client_get_device_id by
i2c_get_match_data() as we have similar I2C, ACPI and DT matching table.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
Note:
* This patch is only compile tested.
---
drivers/iio/magnetometer/ak8975.c | 75 +++++++++++++------------------
1 file changed, 30 insertions(+), 45 deletions(-)
diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index eb706d0bf70b..104798549de1 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -813,13 +813,13 @@ static const struct iio_info ak8975_info = {
};
static const struct acpi_device_id ak_acpi_match[] = {
- {"AK8975", AK8975},
- {"AK8963", AK8963},
- {"INVN6500", AK8963},
- {"AK009911", AK09911},
- {"AK09911", AK09911},
- {"AKM9911", AK09911},
- {"AK09912", AK09912},
+ {"AK8975", (kernel_ulong_t)&ak_def_array[AK8975] },
+ {"AK8963", (kernel_ulong_t)&ak_def_array[AK8963] },
+ {"INVN6500", (kernel_ulong_t)&ak_def_array[AK8963] },
+ {"AK009911", (kernel_ulong_t)&ak_def_array[AK09911] },
+ {"AK09911", (kernel_ulong_t)&ak_def_array[AK09911] },
+ {"AKM9911", (kernel_ulong_t)&ak_def_array[AK09911] },
+ {"AK09912", (kernel_ulong_t)&ak_def_array[AK09912] },
{ }
};
MODULE_DEVICE_TABLE(acpi, ak_acpi_match);
@@ -883,10 +883,7 @@ static int ak8975_probe(struct i2c_client *client)
struct iio_dev *indio_dev;
struct gpio_desc *eoc_gpiod;
struct gpio_desc *reset_gpiod;
- const void *match;
- unsigned int i;
int err;
- enum asahi_compass_chipset chipset;
const char *name = NULL;
/*
@@ -928,27 +925,15 @@ static int ak8975_probe(struct i2c_client *client)
return err;
/* id will be NULL when enumerated via ACPI */
- match = device_get_match_data(&client->dev);
- if (match) {
- chipset = (uintptr_t)match;
- name = dev_name(&client->dev);
- } else if (id) {
- chipset = (enum asahi_compass_chipset)(id->driver_data);
- name = id->name;
- } else
- return -ENOSYS;
-
- for (i = 0; i < ARRAY_SIZE(ak_def_array); i++)
- if (ak_def_array[i].type == chipset)
- break;
-
- if (i == ARRAY_SIZE(ak_def_array)) {
- dev_err(&client->dev, "AKM device type unsupported: %d\n",
- chipset);
+ data->def = i2c_get_match_data(client);
+ if (!data->def)
return -ENODEV;
- }
- data->def = &ak_def_array[i];
+ /* If enumerated via firmware node, fix the ABI */
+ if (dev_fwnode(&client->dev))
+ name = dev_name(&client->dev);
+ else
+ name = id->name;
/* Fetch the regulators */
data->vdd = devm_regulator_get(&client->dev, "vdd");
@@ -1077,28 +1062,28 @@ static DEFINE_RUNTIME_DEV_PM_OPS(ak8975_dev_pm_ops, ak8975_runtime_suspend,
ak8975_runtime_resume, NULL);
static const struct i2c_device_id ak8975_id[] = {
- {"ak8975", AK8975},
- {"ak8963", AK8963},
- {"AK8963", AK8963},
- {"ak09911", AK09911},
- {"ak09912", AK09912},
- {"ak09916", AK09916},
+ {"ak8975", (kernel_ulong_t)&ak_def_array[AK8975] },
+ {"ak8963", (kernel_ulong_t)&ak_def_array[AK8963] },
+ {"AK8963", (kernel_ulong_t)&ak_def_array[AK8963] },
+ {"ak09911", (kernel_ulong_t)&ak_def_array[AK09911] },
+ {"ak09912", (kernel_ulong_t)&ak_def_array[AK09912] },
+ {"ak09916", (kernel_ulong_t)&ak_def_array[AK09916] },
{}
};
MODULE_DEVICE_TABLE(i2c, ak8975_id);
static const struct of_device_id ak8975_of_match[] = {
- { .compatible = "asahi-kasei,ak8975", },
- { .compatible = "ak8975", },
- { .compatible = "asahi-kasei,ak8963", },
- { .compatible = "ak8963", },
- { .compatible = "asahi-kasei,ak09911", },
- { .compatible = "ak09911", },
- { .compatible = "asahi-kasei,ak09912", },
- { .compatible = "ak09912", },
- { .compatible = "asahi-kasei,ak09916", },
- { .compatible = "ak09916", },
+ { .compatible = "asahi-kasei,ak8975", .data = &ak_def_array[AK8975] },
+ { .compatible = "ak8975", .data = &ak_def_array[AK8975] },
+ { .compatible = "asahi-kasei,ak8963", .data = &ak_def_array[AK8963] },
+ { .compatible = "ak8963", .data = &ak_def_array[AK8963] },
+ { .compatible = "asahi-kasei,ak09911", .data = &ak_def_array[AK09911] },
+ { .compatible = "ak09911", .data = &ak_def_array[AK09911] },
+ { .compatible = "asahi-kasei,ak09912", .data = &ak_def_array[AK09912] },
+ { .compatible = "ak09912", .data = &ak_def_array[AK09912] },
+ { .compatible = "asahi-kasei,ak09916", .data = &ak_def_array[AK09916] },
+ { .compatible = "ak09916", .data = &ak_def_array[AK09916] },
{}
};
MODULE_DEVICE_TABLE(of, ak8975_of_match);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: magnetometer: ak8975: Convert enum->pointer for data in the match tables
2023-08-16 18:40 [PATCH] iio: magnetometer: ak8975: Convert enum->pointer for data in the match tables Biju Das
@ 2023-08-17 10:26 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2023-08-17 10:26 UTC (permalink / raw)
To: Biju Das
Cc: Jonathan Cameron, Lars-Peter Clausen, Uwe Kleine-König,
linux-iio, Geert Uytterhoeven, linux-renesas-soc
On Wed, Aug 16, 2023 at 07:40:15PM +0100, Biju Das wrote:
> Convert enum->pointer for data in the match tables to simplify the probe()
> by replacing device_get_match_data() and i2c_client_get_device_id by
> i2c_get_match_data() as we have similar I2C, ACPI and DT matching table.
...
> static const struct acpi_device_id ak_acpi_match[] = {
> + {"AK8975", (kernel_ulong_t)&ak_def_array[AK8975] },
> + {"AK8963", (kernel_ulong_t)&ak_def_array[AK8963] },
> + {"INVN6500", (kernel_ulong_t)&ak_def_array[AK8963] },
> + {"AK009911", (kernel_ulong_t)&ak_def_array[AK09911] },
> + {"AK09911", (kernel_ulong_t)&ak_def_array[AK09911] },
> + {"AKM9911", (kernel_ulong_t)&ak_def_array[AK09911] },
> + {"AK09912", (kernel_ulong_t)&ak_def_array[AK09912] },
Please, sort them by HID. ACPI has no issues (as I learnt about OF) with
the ordering of IDs.
> { }
> };
...
> - {"AK8963", AK8963},
> + {"AK8963", (kernel_ulong_t)&ak_def_array[AK8963] },
Seems the wrong ID to begin with.
I would suggest to drop it in a separate patch.
...
> static const struct of_device_id ak8975_of_match[] = {
> + { .compatible = "asahi-kasei,ak8975", .data = &ak_def_array[AK8975] },
> + { .compatible = "ak8975", .data = &ak_def_array[AK8975] },
> + { .compatible = "asahi-kasei,ak8963", .data = &ak_def_array[AK8963] },
> + { .compatible = "ak8963", .data = &ak_def_array[AK8963] },
> + { .compatible = "asahi-kasei,ak09911", .data = &ak_def_array[AK09911] },
> + { .compatible = "ak09911", .data = &ak_def_array[AK09911] },
> + { .compatible = "asahi-kasei,ak09912", .data = &ak_def_array[AK09912] },
> + { .compatible = "ak09912", .data = &ak_def_array[AK09912] },
> + { .compatible = "asahi-kasei,ak09916", .data = &ak_def_array[AK09916] },
> + { .compatible = "ak09916", .data = &ak_def_array[AK09916] },
Maybe the asashi being grouped it won't regress...
{ .compatible = "asahi-kasei,ak8975", .data = &ak_def_array[AK8975] },
{ .compatible = "asahi-kasei,ak8963", .data = &ak_def_array[AK8963] },
{ .compatible = "asahi-kasei,ak09911", .data = &ak_def_array[AK09911] },
{ .compatible = "asahi-kasei,ak09912", .data = &ak_def_array[AK09912] },
{ .compatible = "asahi-kasei,ak09916", .data = &ak_def_array[AK09916] },
{ .compatible = "ak8975", .data = &ak_def_array[AK8975] },
{ .compatible = "ak8963", .data = &ak_def_array[AK8963] },
{ .compatible = "ak09911", .data = &ak_def_array[AK09911] },
{ .compatible = "ak09912", .data = &ak_def_array[AK09912] },
{ .compatible = "ak09916", .data = &ak_def_array[AK09916] },
> {}
> };
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-17 10:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-16 18:40 [PATCH] iio: magnetometer: ak8975: Convert enum->pointer for data in the match tables Biju Das
2023-08-17 10:26 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox