* [PATCH] iio: pressure: ms5637: Use i2c_get_match_data()
@ 2023-08-12 18:07 Biju Das
2023-08-15 14:51 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Biju Das @ 2023-08-12 18:07 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Biju Das, Lars-Peter Clausen, Uwe Kleine-König,
Andy Shevchenko, linux-iio, Geert Uytterhoeven, linux-renesas-soc
Replace device_get_match_data() and id lookup for retrieving match data
by i2c_get_match_data().
While at it, drop ununsed variable id from probe().
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
drivers/iio/pressure/ms5637.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/iio/pressure/ms5637.c b/drivers/iio/pressure/ms5637.c
index 9b3abffb724b..ac30d76285d1 100644
--- a/drivers/iio/pressure/ms5637.c
+++ b/drivers/iio/pressure/ms5637.c
@@ -144,7 +144,6 @@ static const struct iio_info ms5637_info = {
static int ms5637_probe(struct i2c_client *client)
{
- const struct i2c_device_id *id = i2c_client_get_device_id(client);
const struct ms_tp_data *data;
struct ms_tp_dev *dev_data;
struct iio_dev *indio_dev;
@@ -159,10 +158,7 @@ static int ms5637_probe(struct i2c_client *client)
return -EOPNOTSUPP;
}
- if (id)
- data = (const struct ms_tp_data *)id->driver_data;
- else
- data = device_get_match_data(&client->dev);
+ data = i2c_get_match_data(client);
if (!data)
return -EINVAL;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: pressure: ms5637: Use i2c_get_match_data()
2023-08-12 18:07 [PATCH] iio: pressure: ms5637: Use i2c_get_match_data() Biju Das
@ 2023-08-15 14:51 ` Andy Shevchenko
2023-08-18 15:01 ` Biju Das
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2023-08-15 14:51 UTC (permalink / raw)
To: Biju Das
Cc: Jonathan Cameron, Lars-Peter Clausen, Uwe Kleine-König,
linux-iio, Geert Uytterhoeven, linux-renesas-soc
On Sat, Aug 12, 2023 at 07:07:00PM +0100, Biju Das wrote:
> Replace device_get_match_data() and id lookup for retrieving match data
> by i2c_get_match_data().
>
> While at it, drop ununsed variable id from probe().
With commit message fixed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] iio: pressure: ms5637: Use i2c_get_match_data()
2023-08-15 14:51 ` Andy Shevchenko
@ 2023-08-18 15:01 ` Biju Das
0 siblings, 0 replies; 3+ messages in thread
From: Biju Das @ 2023-08-18 15:01 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Jonathan Cameron, Lars-Peter Clausen, Uwe Kleine-König,
linux-iio@vger.kernel.org, Geert Uytterhoeven,
linux-renesas-soc@vger.kernel.org
Hi Andy Shevchenko,
> Subject: Re: [PATCH] iio: pressure: ms5637: Use i2c_get_match_data()
>
> On Sat, Aug 12, 2023 at 07:07:00PM +0100, Biju Das wrote:
> > Replace device_get_match_data() and id lookup for retrieving match
> > data by i2c_get_match_data().
> >
> > While at it, drop ununsed variable id from probe().
>
> With commit message fixed,
Agreed.
Cheers,
Biju
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> --
> With Best Regards,
> Andy Shevchenko
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-18 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-12 18:07 [PATCH] iio: pressure: ms5637: Use i2c_get_match_data() Biju Das
2023-08-15 14:51 ` Andy Shevchenko
2023-08-18 15:01 ` Biju Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox