From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Eason Yang <j2anfernee@gmail.com>,
lars@metafoo.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
javier.carrasco.cruz@gmail.com, gstols@baylibre.com,
alisadariana@gmail.com, tgamblin@baylibre.com,
olivier.moysan@foss.st.com, antoniu.miclaus@analog.com,
eblanc@baylibre.com, joao.goncalves@toradex.com,
tobias.sperling@softing.com, marcelo.schmitt@analog.com,
angelogioacchino.delregno@collabora.com,
thomas.bonnefille@bootlin.com, herve.codina@bootlin.com,
chanh@os.amperecomputing.com, KWLIU@nuvoton.com,
yhyang2@nuvoton.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] iio: adc: add support for Nuvoton NCT7201
Date: Sat, 19 Apr 2025 18:23:29 +0300 [thread overview]
Message-ID: <aAO_8d7j-KgxbmKU@smile.fi.intel.com> (raw)
In-Reply-To: <20250418171326.07634113@jic23-huawei>
On Fri, Apr 18, 2025 at 05:13:26PM +0100, Jonathan Cameron wrote:
> On Wed, 16 Apr 2025 16:17:34 +0800
> Eason Yang <j2anfernee@gmail.com> wrote:
...
> > + struct device *dev = chip->dev;
> > + __le16 data = cpu_to_le16(NCT7201_REG_CHANNEL_ENABLE_MASK);
>
> Assign this value down near where it is used. That will generally help
> readability.
Actually it is a good, but not a main reason, the problem with this style is
long-term maintenance when some code may appear in between and become so long
that one can screw up this assignment at some point.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-04-19 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 8:17 [PATCH v6 0/2] iio: adc: add Nuvoton NCT7201 ADC driver Eason Yang
2025-04-16 8:17 ` [PATCH v6 1/2] dt-bindings: iio: adc: add NCT7201 ADCs Eason Yang
2025-04-17 6:20 ` Krzysztof Kozlowski
2025-04-16 8:17 ` [PATCH v6 2/2] iio: adc: add support for Nuvoton NCT7201 Eason Yang
2025-04-16 9:34 ` Andy Shevchenko
2025-04-20 13:03 ` Yu-Hsian Yang
2025-04-20 19:45 ` Andy Shevchenko
2025-04-18 16:13 ` Jonathan Cameron
2025-04-19 15:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAO_8d7j-KgxbmKU@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=KWLIU@nuvoton.com \
--cc=alisadariana@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=antoniu.miclaus@analog.com \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=eblanc@baylibre.com \
--cc=gstols@baylibre.com \
--cc=herve.codina@bootlin.com \
--cc=j2anfernee@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=joao.goncalves@toradex.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=robh@kernel.org \
--cc=tgamblin@baylibre.com \
--cc=thomas.bonnefille@bootlin.com \
--cc=tobias.sperling@softing.com \
--cc=yhyang2@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox