From: Andy Shevchenko <andy@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Nuno Sá" <noname.nuno@gmail.com>,
"Angelo Dureghello" <adureghello@baylibre.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/5] Documentation: ABI: IIO: add calibphase_delay documentation
Date: Wed, 30 Apr 2025 17:45:13 +0300 [thread overview]
Message-ID: <aBI3eUPirZEXpZgG@smile.fi.intel.com> (raw)
In-Reply-To: <070b269c-c536-49c5-a11d-7e23653613f9@baylibre.com>
On Wed, Apr 30, 2025 at 09:21:28AM -0500, David Lechner wrote:
> On 4/30/25 12:40 AM, Nuno Sá wrote:
> > On Tue, 2025-04-29 at 15:06 +0200, Angelo Dureghello wrote:
> >> From: Angelo Dureghello <adureghello@baylibre.com>
> >>
> >> Add new IIO calibphase_delay documentation.
> >>
> >> The delay suffix is added to specify that the phase, generally in
> >> radiants, is for this case (needed from ad7606) in nanoseconds.
...
> >> +What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_calibphase_delay
> >
> > Not sure if I'm too convinced on the _delay suffix
> >
> Phase is measured in radians, not seconds, so it seems wrong to use it here.
>
> https://en.wikipedia.org/wiki/Phase_(waves)
>
> And the delay here is with respect to individual samples in a simultaneous
> conversion without regard for a sampling frequency, so I don't see how we could
> convert the time to radians in any meaningful way.
And how this delay is aplicable to the phase in the hardware? Sounds to me that
HW has some meaningful way of such a conversion?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-30 14:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 13:06 [PATCH 0/5] iio: adc: add ad7606 calibration support Angelo Dureghello
2025-04-29 13:06 ` [PATCH 1/5] Documentation: ABI: IIO: add calibphase_delay documentation Angelo Dureghello
2025-04-30 5:40 ` Nuno Sá
2025-04-30 14:21 ` David Lechner
2025-04-30 14:45 ` Andy Shevchenko [this message]
2025-04-30 14:56 ` David Lechner
2025-04-30 15:04 ` David Lechner
2025-05-01 12:33 ` Angelo Dureghello
2025-05-01 14:44 ` David Lechner
2025-05-04 15:04 ` Jonathan Cameron
2025-04-29 13:06 ` [PATCH 2/5] iio: core: add ADC phase calibration definition Angelo Dureghello
2025-04-29 13:06 ` [PATCH 3/5] iio: adc: ad7606: add offset and phase calibration support Angelo Dureghello
2025-04-30 12:50 ` Andy Shevchenko
2025-05-01 12:37 ` Angelo Dureghello
2025-04-30 15:36 ` Nuno Sá
2025-04-30 16:14 ` David Lechner
2025-04-30 18:33 ` David Lechner
2025-05-02 7:43 ` Nuno Sá
2025-04-29 13:06 ` [PATCH 4/5] dt-bindings: iio: adc: adi,ad7606: add gain " Angelo Dureghello
2025-04-29 14:56 ` Conor Dooley
2025-04-29 15:26 ` David Lechner
2025-04-29 20:45 ` Angelo Dureghello
2025-04-29 13:06 ` [PATCH 5/5] iio: adc: ad7606: " Angelo Dureghello
2025-04-29 22:34 ` Andy Shevchenko
2025-05-01 13:49 ` Angelo Dureghello
2025-04-29 22:46 ` David Lechner
2025-05-01 13:35 ` Angelo Dureghello
2025-05-01 14:26 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBI3eUPirZEXpZgG@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=adureghello@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox