From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Chu Guangqing <chuguangqing@inspur.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
subhajit.ghosh@tweaklogic.com, javier.carrasco.cruz@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] iio: light: apds9960: convert to use maple tree register cache
Date: Fri, 24 Oct 2025 11:47:25 +0300 [thread overview]
Message-ID: <aPs9HdeTZKoqFqdk@smile.fi.intel.com> (raw)
In-Reply-To: <20251024073823.35122-5-chuguangqing@inspur.com>
On Fri, Oct 24, 2025 at 03:38:23PM +0800, Chu Guangqing wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
...
> .reg_defaults = apds9960_reg_defaults,
> .num_reg_defaults = ARRAY_SIZE(apds9960_reg_defaults),
^^^^ Be careful with such cases, the cache implementations may behave
differently. Have you tested this on the actual HW?
> .max_register = APDS9960_REG_GFIFO_DIR(RIGHT),
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_MAPLE,
> };
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-10-24 8:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 7:38 [PATCH 0/4] iio: convert to use maple tree register cache Chu Guangqing
2025-10-24 7:38 ` [PATCH 1/4] iio: adc: ade9000: " Chu Guangqing
2025-10-24 7:38 ` [PATCH 2/4] iio: light: veml3235: " Chu Guangqing
2025-10-24 7:38 ` [PATCH 3/4] iio: light: apds9306: " Chu Guangqing
2025-10-27 13:06 ` Subhajit Ghosh
2025-10-24 7:38 ` [PATCH 4/4] iio: light: apds9960: " Chu Guangqing
2025-10-24 8:47 ` Andy Shevchenko [this message]
[not found] ` <68fc4591.1.gk94qBPVZajhk94q@inspur.com>
2025-10-27 8:30 ` Andy Shevchenko
2025-10-27 13:38 ` Jonathan Cameron
2025-10-28 8:10 ` Andy Shevchenko
2025-11-02 12:11 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPs9HdeTZKoqFqdk@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=chuguangqing@inspur.com \
--cc=dlechner@baylibre.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=subhajit.ghosh@tweaklogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox