[PATCH v2] iio: adc: ad_sigma_delta: Format block comments

[PATCH v2] iio: adc: ad_sigma_delta: Format block comments

[Giorgi Tchankvetadze]

Format the multi-line comment in ad_sd_set_comm() according to
the kernel multi-line comment style.

Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
Changes in v2:
- Use proper multi-line comment layout
- Address review comments from Andy Shevchenko

 drivers/iio/adc/ad_sigma_delta.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
index 7852884703b0..a955556f9ec8 100644
--- a/drivers/iio/adc/ad_sigma_delta.c
+++ b/drivers/iio/adc/ad_sigma_delta.c
@@ -51,8 +51,10 @@
  */
 void ad_sd_set_comm(struct ad_sigma_delta *sigma_delta, u8 comm)
 {
-	/* Some variants use the lower two bits of the communications register
-	 * to select the channel */
+	/*
+	 * Some variants use the lower two bits of the communications register
+	 * to select the channel.
+	 */
 	sigma_delta->comm = comm & AD_SD_COMM_CHAN_MASK;
 }
 EXPORT_SYMBOL_NS_GPL(ad_sd_set_comm, "IIO_AD_SIGMA_DELTA");
-- 
2.52.0

Re: [PATCH v2] iio: adc: ad_sigma_delta: Format block comments

[Andy Shevchenko]

On Sat, Mar 14, 2026 at 03:12:53PM +0400, Giorgi Tchankvetadze wrote:
> Format the multi-line comment in ad_sd_set_comm() according to
> the kernel multi-line comment style.

Assuming this is only a single issue of a kind in entire iio/adc,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] iio: adc: ad_sigma_delta: Format block comments

[Jonathan Cameron]

On Mon, 16 Mar 2026 12:02:19 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Sat, Mar 14, 2026 at 03:12:53PM +0400, Giorgi Tchankvetadze wrote:
> > Format the multi-line comment in ad_sd_set_comm() according to
> > the kernel multi-line comment style.  
> 
> Assuming this is only a single issue of a kind in entire iio/adc,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 

I'm not that fussed as long as it's the only one in this particular
driver.  Ideally nice to clean up any others though.

Anyhow, applied as is without confirmation of Andy's question one
way or the other.

Thanks,

Jonathan

p.s. I'm favouring clearing patches this weekend even if not
necessarily perfect.

Re: [PATCH v2] iio: adc: ad_sigma_delta: Format block comments

[Giorgi Tchankvetadze]

On Sun, Mar 22, 2026 at 1:08 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> Anyhow, applied as is without confirmation of Andy's question one
> way or the other.
>
> Thanks,
>
> Jonathan
>
> p.s. I'm favouring clearing patches this weekend even if not
> necessarily perfect.

Thanks Jonathan, and thanks Andy for the review.

I haven’t done a full sweep across iio/adc yet; this was a local fix.
Given how broad this kind of cleanup can get(fixing formatting in
multi line comments in the entire iio/adc directory), I assumed it
would be preferred to keep the scope limited rather than risk missing
cases in a larger series.


Regards,
Giorgi

Re: [PATCH v2] iio: adc: ad_sigma_delta: Format block comments

[Jonathan Cameron]

On Mon, 23 Mar 2026 11:20:51 +0400
Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com> wrote:

> On Sun, Mar 22, 2026 at 1:08 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > Anyhow, applied as is without confirmation of Andy's question one
> > way or the other.
> >
> > Thanks,
> >
> > Jonathan
> >
> > p.s. I'm favouring clearing patches this weekend even if not
> > necessarily perfect.  
> 
> Thanks Jonathan, and thanks Andy for the review.
> 
> I haven’t done a full sweep across iio/adc yet; this was a local fix.
> Given how broad this kind of cleanup can get(fixing formatting in
> multi line comments in the entire iio/adc directory), I assumed it
> would be preferred to keep the scope limited rather than risk missing
> cases in a larger series.

How big is it looking?  I wasn't expecting these to be particularly common.

Jonathan

> 
> 
> Regards,
> Giorgi

Re: [PATCH v2] iio: adc: ad_sigma_delta: Format block comments

[Giorgi Tchankvetadze]

On Thu, Mar 26, 2026 at 12:40 AM Jonathan Cameron <jic23@kernel.org> wrote:
>

> > I haven’t done a full sweep across iio/adc yet; this was a local fix.
> > Given how broad this kind of cleanup can get(fixing formatting in
> > multi line comments in the entire iio/adc directory), I assumed it
> > would be preferred to keep the scope limited rather than risk missing
> > cases in a larger series.
>
> How big is it looking?  I wasn't expecting these to be particularly common.
>
> Jonathan
>

Hi Jonathan,
I took a closer look.
There are a handful of similar multi-line comments across
drivers/iio/adc.. However, a good portion of them
are file headers, NOTE blocks, or structured comments that appear
intentional.

There are some cases similar to the one fixed here, but overall it
doesn’t seem particularly widespread. I think , not widespread enough
for patch series.


Regards,
Giorgi

Re: [PATCH v2] iio: adc: ad_sigma_delta: Format block comments

[Jonathan Cameron]

On Thu, 26 Mar 2026 12:06:13 +0400
Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com> wrote:

> On Thu, Mar 26, 2026 at 12:40 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> 
> > > I haven’t done a full sweep across iio/adc yet; this was a local fix.
> > > Given how broad this kind of cleanup can get(fixing formatting in
> > > multi line comments in the entire iio/adc directory), I assumed it
> > > would be preferred to keep the scope limited rather than risk missing
> > > cases in a larger series.
> >
> > How big is it looking?  I wasn't expecting these to be particularly common.
> >
> > Jonathan
> >
> 
> Hi Jonathan,
> I took a closer look.
> There are a handful of similar multi-line comments across
> drivers/iio/adc.. However, a good portion of them
> are file headers, NOTE blocks, or structured comments that appear
> intentional.
> 
> There are some cases similar to the one fixed here, but overall it
> doesn’t seem particularly widespread. I think , not widespread enough
> for patch series.
OK.  If you want to work on this, send whatever tidy ups look sensible
to you.  I don't mind how you break them up into patches / series as
long as finest granularity is one per file. Somewhat coarser is also
fine.

Thanks,

Jonathan

> 
> 
> Regards,
> Giorgi