From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Giovanna Luisa Hirata dos Anjos <giovannaluisahirata@usp.br>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, Naili Lucia Marques <naahmarque345@usp.br>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: common: ms_sensors: use guard(mutex) helper
Date: Fri, 17 Apr 2026 11:31:12 +0300 [thread overview]
Message-ID: <aeHv0DEEc2bS4YB8@ashevche-desk.local> (raw)
In-Reply-To: <20260416032351.224072-1-giovannaluisahirata@usp.br>
On Thu, Apr 16, 2026 at 12:23:45AM -0300, Giovanna Luisa Hirata dos Anjos wrote:
> The guard(mutex) macro helps to simplify the code by automatically
> releasing the mutex when the dev_data->lock variable goes out of scope.
> This reduces the risk of forgetting to call mutex_unlock in error paths.
>
> Refactor all functions in this driver to use this modern cleanup helper.
Please, read my comments to your other changes. Slow down with the submissions
of a new one until we settle on the rest, you will develop the style that will
be accepted in the future without comments.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-17 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 3:23 [PATCH] iio: common: ms_sensors: use guard(mutex) helper Giovanna Luisa Hirata dos Anjos
2026-04-17 8:31 ` Andy Shevchenko [this message]
2026-04-20 22:52 ` Giovanna Luisa Hirata dos Anjos
2026-04-22 6:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeHv0DEEc2bS4YB8@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=giovannaluisahirata@usp.br \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=naahmarque345@usp.br \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox