Re: [PATCH] iio: common: ms_sensors: use guard(mutex) helper

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Mon, Apr 20, 2026 at 07:52:25PM -0300, Giovanna Luisa Hirata dos Anjos wrote:

Please, do not top-post!

> Thank you for the feedback.
> 
> Regarding the other changes, we believe there might be a
> misunderstanding, as this is our first submission to the list. We've
> checked lore and only found this specific thread:
> https://lore.kernel.org/all/?q=f%3Agiovanna+luisa+hirata
> 
> As newcomers, we appreciate the guidance and will follow your
> suggestion to slow down and refine our style before further
> submissions.
> 
> I have already reordered the includes alphabetically and will send a
> v2 once the current discussion settles.

So many patches lately with similar content... It may be I mixed yours with
somebody's else. The outcome of it is obvious lack of reviewing the code *by
newcomers* (by humans in other words). I am now starting thinking that newcomers
has to review at least 10 patches on the topic (subsystem) before submit their
first one. This will train more on the process, and other useful skills.


> Em sex., 17 de abr. de 2026 às 05:31, Andy Shevchenko
> <andriy.shevchenko@intel.com> escreveu:
> >
> > On Thu, Apr 16, 2026 at 12:23:45AM -0300, Giovanna Luisa Hirata dos Anjos wrote:
> > > The guard(mutex) macro helps to simplify the code by automatically
> > > releasing the mutex when the dev_data->lock variable goes out of scope.
> > > This reduces the risk of forgetting to call mutex_unlock in error paths.
> > >
> > > Refactor all functions in this driver to use this modern cleanup helper.
> >
> > Please, read my comments to your other changes. Slow down with the submissions
> > of a new one until we settle on the rest, you will develop the style that will
> > be accepted in the future without comments.

-- 
With Best Regards,
Andy Shevchenko