* [PATCH] iio: adc: rtq6056: add i2c_device_id support
@ 2026-04-20 12:52 Kevin Tung
2026-04-20 17:12 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Tung @ 2026-04-20 12:52 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: linux-iio, linux-kernel, Kevin Tung, Kevin Tung
Add i2c_device_id table to support legacy I2C instantiation.
Update probe to use i2c_get_match_data() so device data can be
retrieved consistently for both OF and legacy I2C instantiation.
Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
drivers/iio/adc/rtq6056.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/rtq6056.c b/drivers/iio/adc/rtq6056.c
index 2bf3a09ac6b0416d1afea85de3d343ed503ac3b9..e2b1da13c0d31fa90cf9a7bfe494f331bcce2675 100644
--- a/drivers/iio/adc/rtq6056.c
+++ b/drivers/iio/adc/rtq6056.c
@@ -728,7 +728,7 @@ static int rtq6056_probe(struct i2c_client *i2c)
if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_SMBUS_WORD_DATA))
return -EOPNOTSUPP;
- devdata = device_get_match_data(dev);
+ devdata = i2c_get_match_data(i2c);
if (!devdata)
return dev_err_probe(dev, -EINVAL, "Invalid dev data\n");
@@ -871,6 +871,13 @@ static const struct richtek_dev_data rtq6059_devdata = {
.set_average = rtq6059_adc_set_average,
};
+static const struct i2c_device_id rtq6056_id[] = {
+ { "rtq6056", (kernel_ulong_t)&rtq6056_devdata },
+ { "rtq6059", (kernel_ulong_t)&rtq6059_devdata },
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, rtq6056_id);
+
static const struct of_device_id rtq6056_device_match[] = {
{ .compatible = "richtek,rtq6056", .data = &rtq6056_devdata },
{ .compatible = "richtek,rtq6059", .data = &rtq6059_devdata },
@@ -885,6 +892,7 @@ static struct i2c_driver rtq6056_driver = {
.pm = pm_ptr(&rtq6056_pm_ops),
},
.probe = rtq6056_probe,
+ .id_table = rtq6056_id,
};
module_i2c_driver(rtq6056_driver);
---
base-commit: c1f49dea2b8f335813d3b348fd39117fb8efb428
change-id: 20260420-rtq6056_support_sysfs_instantiation-c6ee66edbec7
Best regards,
--
Kevin Tung <kevin.tung.openbmc@gmail.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: adc: rtq6056: add i2c_device_id support
2026-04-20 12:52 [PATCH] iio: adc: rtq6056: add i2c_device_id support Kevin Tung
@ 2026-04-20 17:12 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-04-20 17:12 UTC (permalink / raw)
To: Kevin Tung
Cc: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
linux-iio, linux-kernel, Kevin Tung
On Mon, Apr 20, 2026 at 08:52:52PM +0800, Kevin Tung wrote:
> Add i2c_device_id table to support legacy I2C instantiation.
> Update probe to use i2c_get_match_data() so device data can be
> retrieved consistently for both OF and legacy I2C instantiation.
Maybe someone finds this useful...
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-20 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-20 12:52 [PATCH] iio: adc: rtq6056: add i2c_device_id support Kevin Tung
2026-04-20 17:12 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox