From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: joshua.crofts1@gmail.com
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
sashiko-bot <sashiko-bot@kernel.org>
Subject: Re: [PATCH v4 0/8] iio: light: si1133: driver cleanup
Date: Mon, 4 May 2026 11:55:30 +0300 [thread overview]
Message-ID: <afhfAjTShsY8AYiu@ashevche-desk.local> (raw)
In-Reply-To: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com>
On Thu, Apr 30, 2026 at 05:04:20PM +0200, Joshua Crofts via B4 Relay wrote:
> This series deals with the cleanup and modernization of the Silicon
> Labs SI1133 UV/Ambient light sensor.
>
> What seemed like a simple checkpatch cleanup turned out to be more
> complex, therefore I've ended up doing a patch series instead.
>
> Changes include:
> - adding missing headers
> - removing unused macros
> - adding guard(mutex)() support
> - code style fixes
> - race condition fixes reported by Sashiko
I'm not sure about patches 1 & 2 without testing on HW (the reports sound good
and fixes look reasonable, but it might be some behaviour that relies on a
[buggy] implementation). Also not sure about patch 7, however don't care much.
For the rest feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-04 8:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 15:04 [PATCH v4 0/8] iio: light: si1133: driver cleanup Joshua Crofts via B4 Relay
2026-04-30 15:04 ` [PATCH v4 1/8] iio: light: si1133: reset counter to prevent race condition Joshua Crofts via B4 Relay
2026-04-30 15:04 ` [PATCH v4 2/8] iio: light: si1133: prevent race condition on timeout Joshua Crofts via B4 Relay
2026-04-30 15:04 ` [PATCH v4 3/8] iio: light: si1133: remove unused macros Joshua Crofts via B4 Relay
2026-05-04 8:49 ` Andy Shevchenko
2026-04-30 15:04 ` [PATCH v4 4/8] iio: light: si1133: prefer complex macros enclosed in parenthesis Joshua Crofts via B4 Relay
2026-04-30 15:04 ` [PATCH v4 5/8] iio: light: si1133: add missing include headers Joshua Crofts via B4 Relay
2026-04-30 19:42 ` Joshua Crofts
2026-04-30 15:04 ` [PATCH v4 6/8] iio: light: si1133: group generic <linux/*> headers Joshua Crofts via B4 Relay
2026-04-30 15:04 ` [PATCH v4 7/8] iio: light: si1133: add local variable for timeout Joshua Crofts via B4 Relay
2026-05-04 8:53 ` Andy Shevchenko
2026-05-04 8:59 ` Joshua Crofts
2026-05-04 9:03 ` Andy Shevchenko
2026-05-05 12:25 ` Jonathan Cameron
2026-04-30 15:04 ` [PATCH v4 8/8] iio: light: si1133: use guard(mutex)() macro Joshua Crofts via B4 Relay
2026-05-04 8:55 ` Andy Shevchenko [this message]
2026-05-04 9:09 ` [PATCH v4 0/8] iio: light: si1133: driver cleanup Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afhfAjTShsY8AYiu@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox