From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 7/8] iio: light: si1133: add local variable for timeout
Date: Mon, 4 May 2026 12:03:08 +0300 [thread overview]
Message-ID: <afhgzKmlXsVnrP8E@ashevche-desk.local> (raw)
In-Reply-To: <CALoEA-yhUAMg8d5hbYVQ1pAdY1TXL3Fwy_h8O8mbiBaAu_dKsA@mail.gmail.com>
On Mon, May 04, 2026 at 10:59:21AM +0200, Joshua Crofts wrote:
> On Mon, 4 May 2026 at 10:53, Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Thu, Apr 30, 2026 at 05:04:27PM +0200, Joshua Crofts via B4 Relay wrote:
> >
> > > Add local variable for timeout to improve readability.
> > >
> > > No functional change.
> >
> > Hmm... I am not sure about this as previously it was one jump and now two jumps
> > over the code to get the actual value of the timeout. OTOH, I don't care much
> > in this case.
>
> This was actually a suggestion by Jonathan, as the original indentation
> of the function parameters was horrible, so it was better to just add it as
> a variable to improve readability. Perhaps I should've added a suggested-by tag.
You added it, and I have seen that. Still my opinion stays. Of course, it's up to
Jonathan to make the final decision.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-04 9:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 15:04 [PATCH v4 0/8] iio: light: si1133: driver cleanup Joshua Crofts via B4 Relay
2026-04-30 15:04 ` [PATCH v4 1/8] iio: light: si1133: reset counter to prevent race condition Joshua Crofts via B4 Relay
2026-04-30 15:04 ` [PATCH v4 2/8] iio: light: si1133: prevent race condition on timeout Joshua Crofts via B4 Relay
2026-04-30 15:04 ` [PATCH v4 3/8] iio: light: si1133: remove unused macros Joshua Crofts via B4 Relay
2026-05-04 8:49 ` Andy Shevchenko
2026-04-30 15:04 ` [PATCH v4 4/8] iio: light: si1133: prefer complex macros enclosed in parenthesis Joshua Crofts via B4 Relay
2026-04-30 15:04 ` [PATCH v4 5/8] iio: light: si1133: add missing include headers Joshua Crofts via B4 Relay
2026-04-30 19:42 ` Joshua Crofts
2026-04-30 15:04 ` [PATCH v4 6/8] iio: light: si1133: group generic <linux/*> headers Joshua Crofts via B4 Relay
2026-04-30 15:04 ` [PATCH v4 7/8] iio: light: si1133: add local variable for timeout Joshua Crofts via B4 Relay
2026-05-04 8:53 ` Andy Shevchenko
2026-05-04 8:59 ` Joshua Crofts
2026-05-04 9:03 ` Andy Shevchenko [this message]
2026-05-05 12:25 ` Jonathan Cameron
2026-04-30 15:04 ` [PATCH v4 8/8] iio: light: si1133: use guard(mutex)() macro Joshua Crofts via B4 Relay
2026-05-04 8:55 ` [PATCH v4 0/8] iio: light: si1133: driver cleanup Andy Shevchenko
2026-05-04 9:09 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afhgzKmlXsVnrP8E@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox