[PATCH] iio: temperature: Build mlx90635 with CONFIG_MLX90635

[PATCH] iio: temperature: Build mlx90635 with CONFIG_MLX90635

[Pengpeng Hou]

drivers/iio/temperature/Kconfig has a dedicated `MLX90635` option, but
the Makefile currently builds mlx90635.o under `CONFIG_MLX90632`.

This means enabling `CONFIG_MLX90635` alone does not carry its provider
object into the build, while enabling `CONFIG_MLX90632` unexpectedly
also builds mlx90635.o.

Gate mlx90635.o on the matching generated Kconfig symbol.

Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
 drivers/iio/temperature/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/temperature/Makefile b/drivers/iio/temperature/Makefile
--- a/drivers/iio/temperature/Makefile
+++ b/drivers/iio/temperature/Makefile
@@ -13,7 +13,7 @@ obj-$(CONFIG_MAX31856) += max31856.o
 obj-$(CONFIG_MAX31865) += max31865.o
 obj-$(CONFIG_MCP9600) += mcp9600.o
 obj-$(CONFIG_MLX90614) += mlx90614.o
 obj-$(CONFIG_MLX90632) += mlx90632.o
-obj-$(CONFIG_MLX90632) += mlx90635.o
+obj-$(CONFIG_MLX90635) += mlx90635.o
 obj-$(CONFIG_TMP006) += tmp006.o
 obj-$(CONFIG_TMP007) += tmp007.o
 obj-$(CONFIG_TMP117) += tmp117.o

Re: [PATCH] iio: temperature: Build mlx90635 with CONFIG_MLX90635

[Andy Shevchenko]

On Wed, Jun 24, 2026 at 04:13:09PM +0800, Pengpeng Hou wrote:
> drivers/iio/temperature/Kconfig has a dedicated `MLX90635` option, but
> the Makefile currently builds mlx90635.o under `CONFIG_MLX90632`.
> 
> This means enabling `CONFIG_MLX90635` alone does not carry its provider
> object into the build, while enabling `CONFIG_MLX90632` unexpectedly
> also builds mlx90635.o.
> 
> Gate mlx90635.o on the matching generated Kconfig symbol.

Good catch! Does it need a Fixes tag? I haven't checked if this is in
Jonathan's testing or togreg branch. If the latter, the Fixes tag is
a must.

-- 
With Best Regards,
Andy Shevchenko

[PATCH v2] iio: temperature: Build mlx90635 with CONFIG_MLX90635

[Pengpeng Hou]

drivers/iio/temperature/Kconfig has a dedicated MLX90635 option, but
the Makefile currently builds mlx90635.o under CONFIG_MLX90632.

This means enabling CONFIG_MLX90635 alone does not carry its provider
object into the build, while enabling CONFIG_MLX90632 unexpectedly also
builds mlx90635.o.

Gate mlx90635.o on the matching generated Kconfig symbol.

Fixes: a1d1ba5e1c28 ("iio: temperature: mlx90635 MLX90635 IR Temperature sensor")
Cc: stable@vger.kernel.org
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
Changes in v2:
- Add the Fixes tag after Andy asked whether one is needed.
- Add stable Cc because this is a released Kbuild symbol mismatch.

 drivers/iio/temperature/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/temperature/Makefile b/drivers/iio/temperature/Makefile
index f046bb2f8a98..192b65965a27 100644
--- a/drivers/iio/temperature/Makefile
+++ b/drivers/iio/temperature/Makefile
@@ -13,7 +13,7 @@ obj-$(CONFIG_MAX31856) += maxim_thermocouple.o
 obj-$(CONFIG_MAX31865) += max31865.o
 obj-$(CONFIG_MCP9600) += mcp9600.o
 obj-$(CONFIG_MLX90614) += mlx90614.o
 obj-$(CONFIG_MLX90632) += mlx90632.o
-obj-$(CONFIG_MLX90632) += mlx90635.o
+obj-$(CONFIG_MLX90635) += mlx90635.o
 obj-$(CONFIG_TMP006) += tmp006.o
 obj-$(CONFIG_TMP007) += tmp007.o
 obj-$(CONFIG_TMP117) += tmp117.o
-- 
2.50.1

Re: [PATCH v2] iio: temperature: Build mlx90635 with CONFIG_MLX90635

[Andy Shevchenko]

On Thu, Jun 25, 2026 at 01:42:59PM +0800, Pengpeng Hou wrote:
> drivers/iio/temperature/Kconfig has a dedicated MLX90635 option, but
> the Makefile currently builds mlx90635.o under CONFIG_MLX90632.
> 
> This means enabling CONFIG_MLX90635 alone does not carry its provider
> object into the build, while enabling CONFIG_MLX90632 unexpectedly also
> builds mlx90635.o.
> 
> Gate mlx90635.o on the matching generated Kconfig symbol.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] iio: temperature: Build mlx90635 with CONFIG_MLX90635

[Crt Mori]

Thanks for spotting this Pengpeng Hou; it's strange that nobody
noticed until now. I would like to apologize to everyone for this
mistake.

Acked-by: Crt Mori <cmo@melexis.com>

On Thu, 25 Jun 2026 at 08:43, Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
>
> On Thu, Jun 25, 2026 at 01:42:59PM +0800, Pengpeng Hou wrote:
> > drivers/iio/temperature/Kconfig has a dedicated MLX90635 option, but
> > the Makefile currently builds mlx90635.o under CONFIG_MLX90632.
> >
> > This means enabling CONFIG_MLX90635 alone does not carry its provider
> > object into the build, while enabling CONFIG_MLX90632 unexpectedly also
> > builds mlx90635.o.
> >
> > Gate mlx90635.o on the matching generated Kconfig symbol.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Re: [PATCH v2] iio: temperature: Build mlx90635 with CONFIG_MLX90635

[Jonathan Cameron]

On Thu, 25 Jun 2026 09:54:58 +0200
Crt Mori <cmo@melexis.com> wrote:

> Thanks for spotting this Pengpeng Hou; it's strange that nobody
> noticed until now. I would like to apologize to everyone for this
> mistake.
> 
> Acked-by: Crt Mori <cmo@melexis.com>
Applied to the fixes-togreg branch of iio.git

Thanks

Jonathan

> 
> On Thu, 25 Jun 2026 at 08:43, Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> >
> > On Thu, Jun 25, 2026 at 01:42:59PM +0800, Pengpeng Hou wrote:  
> > > drivers/iio/temperature/Kconfig has a dedicated MLX90635 option, but
> > > the Makefile currently builds mlx90635.o under CONFIG_MLX90632.
> > >
> > > This means enabling CONFIG_MLX90635 alone does not carry its provider
> > > object into the build, while enabling CONFIG_MLX90632 unexpectedly also
> > > builds mlx90635.o.
> > >
> > > Gate mlx90635.o on the matching generated Kconfig symbol.  
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >
> >