From: Julia Lawall <julia.lawall@inria.fr>
To: Enrique Vargas <jevargas@seas.upenn.edu>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Stefan Popa <stefan.popa@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: iio: adc: align multi-line function argument with open parenthesis
Date: Thu, 12 Mar 2020 15:38:31 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2003121536280.2418@hadrien> (raw)
In-Reply-To: <20200312142721.GA2748@evX1>
On Thu, 12 Mar 2020, Enrique Vargas wrote:
> Eliminate WARNING found with checkpatch.pl for argument split in two
> lines not matching coding conventions identation.
The message seems a bit obscure. There is no argument that is split in
two lines, although it is the case that the argument list is split in two
lines.
For the subject line, maybe "reduce parameter indentation"
And then for the log message:
"Align function parameter with the right side of the open parenthesis
starting the parameter list, to follow kernel coding style. Problem found
using checkpatch."
julia
>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
> drivers/staging/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 51b1cd3ad1de..5f65d084e320 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -477,7 +477,7 @@ static ssize_t ad7192_set(struct device *dev,
> }
>
> static void ad7192_get_available_filter_freq(struct ad7192_state *st,
> - int *freq)
> + int *freq)
> {
> unsigned int fadc;
>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200312142721.GA2748%40evX1.
>
prev parent reply other threads:[~2020-03-12 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 14:27 [PATCH] Staging: iio: adc: align multi-line function argument with open parenthesis Enrique Vargas
2020-03-12 14:38 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2003121536280.2418@hadrien \
--to=julia.lawall@inria.fr \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=jevargas@seas.upenn.edu \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox