Linux IIO development
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Yash Suthar <yashsuthar983@gmail.com>,
	dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	grondon@gmail.com, linusw@kernel.org, hexlabsecurity@proton.me,
	sakari.ailus@linux.intel.com,
	srinivas.pandruvada@linux.intel.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] iio: accel: bmc150: use iio_push_to_buffers_with_ts()
Date: Mon, 31 Aug 2026 10:00:47 +0300	[thread overview]
Message-ID: <apUmn2WKlqO1mZXO@ashevche-desk.local> (raw)
In-Reply-To: <20260831012728.0261184b@jic23-huawei>

On Mon, Aug 31, 2026 at 01:27:28AM +0100, Jonathan Cameron wrote:
> On Thu, 27 Aug 2026 10:08:07 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > On Tue, Aug 25, 2026 at 02:21:56PM +0530, Yash Suthar wrote:
> > > Replace deprecated iio_push_to_buffers_with_timestamp() with
> > > iio_push_to_buffers_with_ts() to allow source size runtime checks.  
> > 
> > With this you might want to use IIO_DECLARE_DMA_BUFFER_WITH_TS() in the

(For the record, I put it as "might".)

> > definition of the scan buffer.
> > 
> Why?  The structure used is: 
> 	struct {
>  		__le16 channels[3];
>  		aligned_s64 ts;
>  	} scan __aligned(IIO_DMA_MINALIGN);
> 
> So given we never let things get enabled with just timestamp, the timestamp
> and channels always end up in the places the structure describes.

OK! I personally consider the macro a bit more robust in the cases when
we _might_ have new HW to support where it will be the case.

> Where that is the case, I much prefer this to the magic buffer with enough
> elements of the channel type on the end.

No objections.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-08-31  7:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  8:51 [PATCH v3 0/3] iio: accel: bmc150: DMA-safe buffers and use iio_push_to_buffers_with_ts() Yash Suthar
2026-08-25  8:51 ` [PATCH v3 1/3] iio: accel: bmc150: use aligned scan buffer for both trigger and fifo Yash Suthar
2026-08-27  6:57   ` Andy Shevchenko
2026-08-25  8:51 ` [PATCH v3 2/3] iio: accel: bmc150: use DMA-safe buffers for regmap bulk reads Yash Suthar
2026-08-27  7:05   ` Andy Shevchenko
2026-08-31  0:24     ` Jonathan Cameron
2026-08-31  6:57       ` Andy Shevchenko
2026-08-25  8:51 ` [PATCH v3 3/3] iio: accel: bmc150: use iio_push_to_buffers_with_ts() Yash Suthar
2026-08-27  7:08   ` Andy Shevchenko
2026-08-31  0:27     ` Jonathan Cameron
2026-08-31  7:00       ` Andy Shevchenko [this message]
2026-09-01  1:34         ` Jonathan Cameron
2026-08-27  6:52 ` [PATCH v3 0/3] iio: accel: bmc150: DMA-safe buffers and " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apUmn2WKlqO1mZXO@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=grondon@gmail.com \
    --cc=hexlabsecurity@proton.me \
    --cc=jic23@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=yashsuthar983@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox