From: Tsz Shan Chan <tsz.chan.dev@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Subhajit Ghosh" <subhajit.ghosh@tweaklogic.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Tsz Shan Chan" <tchan@jacques.com.au>
Subject: Re: [PATCH] iio: light: apds9306: fix default sampling frequency definition
Date: Thu, 3 Sep 2026 17:02:04 +1000 [thread overview]
Message-ID: <apkag8drdFFofWFT@fedora-1> (raw)
In-Reply-To: <apkWlzZZIIzVDz4C@ashevche-desk.local>
On Thu, Sep 03, 2026 at 09:41:27AM +0300, Andy Shevchenko wrote:
> On Thu, Sep 03, 2026 at 03:38:47PM +1000, Tsz Shan Chan wrote:
> > APDS9306_SAMP_FREQ_10HZ is defined as 0.
> >
> > According to the datasheet (page 11, ALS_MEAS_RATE), bits[2:0] set the
>
> Can you add a Datasheet link? (Or at least the version and name)
>
> > measurement rate:
> > - 000: 25ms (40Hz)
> > - 001: 20ms (20Hz)
> > - 010: 100ms (10Hz)
> >
> > Change APDS9306_SAMP_FREQ_10HZ from 0 to 2 to write the correct value
> > for 10Hz.
>
> > Fixes: 620d1e6c7a3f ("iio: light: Add support for APDS9306 Light Sensor")
> >
> > Signed-off-by: Tsz Shan Chan <tchan@jacques.com.au>
>
> No blank lines in the tag block (at the end of the commit message).
I'll add the datasheet link and remove the blank line in v2 commit
message. Thanks.
prev parent reply other threads:[~2026-09-03 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 5:38 [PATCH] iio: light: apds9306: fix default sampling frequency definition Tsz Shan Chan
2026-09-03 6:41 ` Andy Shevchenko
2026-09-03 7:02 ` Tsz Shan Chan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apkag8drdFFofWFT@fedora-1 \
--to=tsz.chan.dev@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=subhajit.ghosh@tweaklogic.com \
--cc=tchan@jacques.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox