[PATCH] iio: light: apds9306: fix default sampling frequency definition

[PATCH] iio: light: apds9306: fix default sampling frequency definition

[Tsz Shan Chan]

APDS9306_SAMP_FREQ_10HZ is defined as 0.

According to the datasheet (page 11, ALS_MEAS_RATE), bits[2:0] set the
measurement rate:
- 000: 25ms  (40Hz)
- 001: 20ms  (20Hz)
- 010: 100ms (10Hz)

Change APDS9306_SAMP_FREQ_10HZ from 0 to 2 to write the correct value
for 10Hz.

Fixes: 620d1e6c7a3f ("iio: light: Add support for APDS9306 Light Sensor")

Signed-off-by: Tsz Shan Chan <tchan@jacques.com.au>
---
 drivers/iio/light/apds9306.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
index f681b02e4922..7dd41136734f 100644
--- a/drivers/iio/light/apds9306.c
+++ b/drivers/iio/light/apds9306.c
@@ -61,7 +61,7 @@
 #define APDS9306_NUM_REPEAT_RATES	7
 #define APDS9306_INT_SRC_CLEAR	0
 #define APDS9306_INT_SRC_ALS	1
-#define APDS9306_SAMP_FREQ_10HZ	0
+#define APDS9306_SAMP_FREQ_10HZ	2
 
 /**
  * struct part_id_gts_multiplier - Part no. and corresponding gts multiplier

---
base-commit: 940de590b839f71d6dc846160534bf202401b8b7
change-id: 20260903-apds9306-bedba7b74e59

Best regards,
-- 
Tsz Shan Chan <tchan@jacques.com.au>

Re: [PATCH] iio: light: apds9306: fix default sampling frequency definition

[Andy Shevchenko]

On Thu, Sep 03, 2026 at 03:38:47PM +1000, Tsz Shan Chan wrote:
> APDS9306_SAMP_FREQ_10HZ is defined as 0.
> 
> According to the datasheet (page 11, ALS_MEAS_RATE), bits[2:0] set the

Can you add a Datasheet link? (Or at least the version and name)

> measurement rate:
> - 000: 25ms  (40Hz)
> - 001: 20ms  (20Hz)
> - 010: 100ms (10Hz)
> 
> Change APDS9306_SAMP_FREQ_10HZ from 0 to 2 to write the correct value
> for 10Hz.

> Fixes: 620d1e6c7a3f ("iio: light: Add support for APDS9306 Light Sensor")
> 
> Signed-off-by: Tsz Shan Chan <tchan@jacques.com.au>

No blank lines in the tag block (at the end of the commit message).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: light: apds9306: fix default sampling frequency definition

[Tsz Shan Chan]

On Thu, Sep 03, 2026 at 09:41:27AM +0300, Andy Shevchenko wrote:
> On Thu, Sep 03, 2026 at 03:38:47PM +1000, Tsz Shan Chan wrote:
> > APDS9306_SAMP_FREQ_10HZ is defined as 0.
> > 
> > According to the datasheet (page 11, ALS_MEAS_RATE), bits[2:0] set the
> 
> Can you add a Datasheet link? (Or at least the version and name)
> 
> > measurement rate:
> > - 000: 25ms  (40Hz)
> > - 001: 20ms  (20Hz)
> > - 010: 100ms (10Hz)
> > 
> > Change APDS9306_SAMP_FREQ_10HZ from 0 to 2 to write the correct value
> > for 10Hz.
> 
> > Fixes: 620d1e6c7a3f ("iio: light: Add support for APDS9306 Light Sensor")
> > 
> > Signed-off-by: Tsz Shan Chan <tchan@jacques.com.au>
> 
> No blank lines in the tag block (at the end of the commit message).

I'll add the datasheet link and remove the blank line in v2 commit
message. Thanks.