Re: [PATCH v2 2/2] iio: adc: Add the NXP SAR ADC support for the s32g2/3 platforms

[David Lechner <dlechner@baylibre.com>]

On 9/11/25 7:55 AM, Daniel Lezcano wrote:
> 
> Hi Jonathan,
> 
> thanks for the review
> 
> On 10/09/2025 19:32, Jonathan Cameron wrote:
>> On Wed, 10 Sep 2025 17:57:56 +0200
>> Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> 
> [ ... ]
> 

...

> 
>>> +    indio_dev->name = dev_name(dev);
>>
>> This should be the 'part number'.  That is a little ill defined
>> for a SoC integrated ADC, but generally not what we get from dev_name()
>> on the platform_device.
> 
> Sorry, I don't get the comment. If I refer to the different drivers there is not consistency with the iio_dev->name.

dev_name() will be something like adc@12345678 from the devicetree,
so not the "part number".

> 
> rtq6056.c:      indio_dev->name = "rtq6056";

This style is preferred if there is only one supported part.

> rzg2l_adc.c:    indio_dev->name = DRIVER_NAME;

We try to avoid using a macro for the driver name like this.

> sc27xx_adc.c:   indio_dev->name = dev_name(dev);

Looks like we missed catching this one in review.

> mt6359-auxadc.c:  indio_dev->name = adc_dev->chip_info->model_name;

This is preferred if there is more than one part supported in the driver.

> mcp3911.c:      indio_dev->name = spi_get_device_id(spi)->name;

This is fine too in cases where there isn't chip_info.

> 
> Are you suggesting to use the compatible part number ?
> 
>     indio->name = "s32g2-sar-adc";
> 

That works.