[PATCH] iio: (ms5637) Add Measurement Specialties explicit MS5805 and MS5837 support

[PATCH] iio: (ms5637) Add Measurement Specialties explicit MS5805 and MS5837 support

[Markezana, William]

U2lnbmVkLW9mZi1ieTogV2lsbGlhbSBNYXJrZXphbmEgPHdpbGxpYW0ubWFya2V6YW5hQG1lYXMt
c3BlYy5jb20+DQotLS0NCiBkcml2ZXJzL2lpby9wcmVzc3VyZS9tczU2MzcuYyB8IDIwICsrKysr
KysrKysrKysrKysrLS0tDQogMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDMgZGVs
ZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJzL2lpby9wcmVzc3VyZS9tczU2MzcuYyBi
L2RyaXZlcnMvaWlvL3ByZXNzdXJlL21zNTYzNy5jDQppbmRleCBlOGQwZTBkLi42ZWNjNjg2IDEw
MDY0NA0KLS0tIGEvZHJpdmVycy9paW8vcHJlc3N1cmUvbXM1NjM3LmMNCisrKyBiL2RyaXZlcnMv
aWlvL3ByZXNzdXJlL21zNTYzNy5jDQpAQCAtMSw1ICsxLDYgQEANCiAvKg0KLSAqIG1zNTYzNy5j
IC0gU3VwcG9ydCBmb3IgTWVhc3VyZW1lbnQtU3BlY2lhbHRpZXMgbXM1NjM3IGFuZCBtczg2MDcN
CisgKiBtczU2MzcuYyAtIFN1cHBvcnQgZm9yIE1lYXN1cmVtZW50LVNwZWNpYWx0aWVzIG1zNTYz
NywgbXM4NjA3LA0KKyAgICAgICAgICAgICAgbXM1ODA1IGFuZCBtczU4MzcNCiAgKiAgICAgICAg
ICAgIHByZXNzdXJlICYgdGVtcGVyYXR1cmUgc2Vuc29yDQogICoNCiAgKiBDb3B5cmlnaHQgKGMp
IDIwMTUgTWVhc3VyZW1lbnQtU3BlY2lhbHRpZXMNCkBAIC0xMiw2ICsxMywxMCBAQA0KICAqICBo
dHRwOi8vd3d3Lm1lYXMtc3BlYy5jb20vZG93bmxvYWRzL01TNTYzNy0wMkJBMDMucGRmDQogICog
RGF0YXNoZWV0Og0KICAqICBodHRwOi8vd3d3Lm1lYXMtc3BlYy5jb20vZG93bmxvYWRzL01TODYw
Ny0wMkJBMDEucGRmDQorICogRGF0YXNoZWV0Og0KKyAqICBodHRwOi8vd3d3Lm1lYXMtc3BlYy5j
b20vZG93bmxvYWRzL01TNTgwNS0wMkJBMDEucGRmDQorICogRGF0YXNoZWV0Og0KKyAqICBodHRw
Oi8vbWVhcy1zcGVjLmNvbS9kb3dubG9hZHMvTVM1ODM3LTMwQkEucGRmDQogICovDQogDQogI2lu
Y2x1ZGUgPGxpbnV4L2luaXQuaD4NCkBAIC0yNiw2ICszMSwxMyBAQA0KIA0KICNpbmNsdWRlICIu
Li9jb21tb24vbXNfc2Vuc29ycy9tc19zZW5zb3JzX2kyYy5oIg0KIA0KK2VudW0gew0KKwlNUzU2
MzcsDQorCU1TODYwNywNCisJTVM1ODA1LA0KKwlNUzU4MzcNCit9Ow0KKw0KIHN0YXRpYyBjb25z
dCBpbnQgbXM1NjM3X3NhbXBfZnJlcVs2XSA9IHsgOTYwLCA0ODAsIDI0MCwgMTIwLCA2MCwgMzAg
fTsNCiAvKiBTdHJpbmcgY29weSBvZiB0aGUgYWJvdmUgY29uc3QgZm9yIHJlYWRhYmlsaXR5IHB1
cnBvc2UgKi8NCiBzdGF0aWMgY29uc3QgY2hhciBtczU2Mzdfc2hvd19zYW1wX2ZyZXFbXSA9ICI5
NjAgNDgwIDI0MCAxMjAgNjAgMzAiOw0KQEAgLTE2OSw4ICsxODEsMTAgQEAgc3RhdGljIGludCBt
czU2MzdfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCwNCiB9DQogDQogc3RhdGljIGNv
bnN0IHN0cnVjdCBpMmNfZGV2aWNlX2lkIG1zNTYzN19pZFtdID0gew0KLQl7Im1zNTYzNyIsIDB9
LA0KLQl7Im1zODYwNy10ZW1wcHJlc3N1cmUiLCAxfSwNCisJeyJtczU2MzciLCBNUzU2Mzd9LA0K
Kwl7Im1zODYwNy10ZW1wcHJlc3N1cmUiLCBNUzg2MDd9LA0KKwl7Im1zNTgwNSIsIE1TNTgwNX0s
DQorCXsibXM1ODM3IiwgTVM1ODM3fSwNCiAJe30NCiB9Ow0KIA0KLS0gDQoyLjEuNA0KDQoNCg==

Re: [PATCH] iio: (ms5637) Add Measurement Specialties explicit MS5805 and MS5837 support

[Lars-Peter Clausen]

On 05/31/2016 03:01 PM, Markezana, William wrote:
> Signed-off-by: William Markezana <william.markezana@meas-spec.com>

This needs a commit message.

Re: [PATCH] iio: (ms5637) Add Measurement Specialties explicit MS5805 and MS5837 support

[Markezana, William]

aWlvOiAobXM1NjM3KSBBZGQgTWVhc3VyZW1lbnQgU3BlY2lhbHRpZXMgZXhwbGljaXQgTVM1ODA1
IGFuZCBNUzU4Mzcgc3VwcG9ydA0KDQpTaWduZWQtb2ZmLWJ5OiBXaWxsaWFtIE1hcmtlemFuYSA8
d2lsbGlhbS5tYXJrZXphbmFAbWVhcy1zcGVjLmNvbT4NCi0tLQ0KIGRyaXZlcnMvaWlvL3ByZXNz
dXJlL21zNTYzNy5jIHwgMjAgKysrKysrKysrKysrKysrKystLS0NCiAxIGZpbGUgY2hhbmdlZCwg
MTcgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2RyaXZlcnMv
aWlvL3ByZXNzdXJlL21zNTYzNy5jIGIvZHJpdmVycy9paW8vcHJlc3N1cmUvbXM1NjM3LmMNCmlu
ZGV4IGU4ZDBlMGQuLjZlY2M2ODYgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2lpby9wcmVzc3VyZS9t
czU2MzcuYw0KKysrIGIvZHJpdmVycy9paW8vcHJlc3N1cmUvbXM1NjM3LmMNCkBAIC0xLDUgKzEs
NiBAQA0KIC8qDQotICogbXM1NjM3LmMgLSBTdXBwb3J0IGZvciBNZWFzdXJlbWVudC1TcGVjaWFs
dGllcyBtczU2MzcgYW5kIG1zODYwNw0KKyAqIG1zNTYzNy5jIC0gU3VwcG9ydCBmb3IgTWVhc3Vy
ZW1lbnQtU3BlY2lhbHRpZXMgbXM1NjM3LCBtczg2MDcsDQorICAgICAgICAgICAgICBtczU4MDUg
YW5kIG1zNTgzNw0KICAqICAgICAgICAgICAgcHJlc3N1cmUgJiB0ZW1wZXJhdHVyZSBzZW5zb3IN
CiAgKg0KICAqIENvcHlyaWdodCAoYykgMjAxNSBNZWFzdXJlbWVudC1TcGVjaWFsdGllcw0KQEAg
LTEyLDYgKzEzLDEwIEBADQogICogIGh0dHA6Ly93d3cubWVhcy1zcGVjLmNvbS9kb3dubG9hZHMv
TVM1NjM3LTAyQkEwMy5wZGYNCiAgKiBEYXRhc2hlZXQ6DQogICogIGh0dHA6Ly93d3cubWVhcy1z
cGVjLmNvbS9kb3dubG9hZHMvTVM4NjA3LTAyQkEwMS5wZGYNCisgKiBEYXRhc2hlZXQ6DQorICog
IGh0dHA6Ly93d3cubWVhcy1zcGVjLmNvbS9kb3dubG9hZHMvTVM1ODA1LTAyQkEwMS5wZGYNCisg
KiBEYXRhc2hlZXQ6DQorICogIGh0dHA6Ly9tZWFzLXNwZWMuY29tL2Rvd25sb2Fkcy9NUzU4Mzct
MzBCQS5wZGYNCiAgKi8NCiANCiAjaW5jbHVkZSA8bGludXgvaW5pdC5oPg0KQEAgLTI2LDYgKzMx
LDEzIEBADQogDQogI2luY2x1ZGUgIi4uL2NvbW1vbi9tc19zZW5zb3JzL21zX3NlbnNvcnNfaTJj
LmgiDQogDQorZW51bSB7DQorCU1TNTYzNywNCisJTVM4NjA3LA0KKwlNUzU4MDUsDQorCU1TNTgz
Nw0KK307DQorDQogc3RhdGljIGNvbnN0IGludCBtczU2Mzdfc2FtcF9mcmVxWzZdID0geyA5NjAs
IDQ4MCwgMjQwLCAxMjAsIDYwLCAzMCB9Ow0KIC8qIFN0cmluZyBjb3B5IG9mIHRoZSBhYm92ZSBj
b25zdCBmb3IgcmVhZGFiaWxpdHkgcHVycG9zZSAqLw0KIHN0YXRpYyBjb25zdCBjaGFyIG1zNTYz
N19zaG93X3NhbXBfZnJlcVtdID0gIjk2MCA0ODAgMjQwIDEyMCA2MCAzMCI7DQpAQCAtMTY5LDgg
KzE4MSwxMCBAQCBzdGF0aWMgaW50IG1zNTYzN19wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xp
ZW50LA0KIH0NCiANCiBzdGF0aWMgY29uc3Qgc3RydWN0IGkyY19kZXZpY2VfaWQgbXM1NjM3X2lk
W10gPSB7DQotCXsibXM1NjM3IiwgMH0sDQotCXsibXM4NjA3LXRlbXBwcmVzc3VyZSIsIDF9LA0K
Kwl7Im1zNTYzNyIsIE1TNTYzN30sDQorCXsibXM4NjA3LXRlbXBwcmVzc3VyZSIsIE1TODYwN30s
DQorCXsibXM1ODA1IiwgTVM1ODA1fSwNCisJeyJtczU4MzciLCBNUzU4Mzd9LA0KIAl7fQ0KIH07
DQogDQotLSANCjIuMS40DQoNCg0K

Re: [PATCH] iio: (ms5637) Add Measurement Specialties explicit MS5805 and MS5837 support

[Peter Meerwald-Stadler]

On Tue, 31 May 2016, Markezana, William wrote:

> Signed-off-by: William Markezana <william.markezana@meas-spec.com>
> ---
>  drivers/iio/pressure/ms5637.c | 20 +++++++++++++++++---
>  1 file changed, 17 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/pressure/ms5637.c b/drivers/iio/pressure/ms5637.c
> index e8d0e0d..6ecc686 100644
> --- a/drivers/iio/pressure/ms5637.c
> +++ b/drivers/iio/pressure/ms5637.c
> @@ -1,5 +1,6 @@
>  /*
> - * ms5637.c - Support for Measurement-Specialties ms5637 and ms8607
> + * ms5637.c - Support for Measurement-Specialties ms5637, ms8607,
> +              ms5805 and ms5837

I guess we expect it to look like
 *             ms5805 and ms5837 pressure & temperature sensors

and I suggest to list the chips in lexicographic order (here and all other 
lists)

it seems there is no functional difference?

>   *            pressure & temperature sensor
>   *
>   * Copyright (c) 2015 Measurement-Specialties
> @@ -12,6 +13,10 @@
>   *  http://www.meas-spec.com/downloads/MS5637-02BA03.pdf
>   * Datasheet:
>   *  http://www.meas-spec.com/downloads/MS8607-02BA01.pdf
> + * Datasheet:
> + *  http://www.meas-spec.com/downloads/MS5805-02BA01.pdf
> + * Datasheet:
> + *  http://meas-spec.com/downloads/MS5837-30BA.pdf
>   */
>  
>  #include <linux/init.h>
> @@ -26,6 +31,13 @@
>  
>  #include "../common/ms_sensors/ms_sensors_i2c.h"
>  
> +enum {
> +	MS5637,
> +	MS8607,
> +	MS5805,
> +	MS5837
> +};
> +
>  static const int ms5637_samp_freq[6] = { 960, 480, 240, 120, 60, 30 };
>  /* String copy of the above const for readability purpose */
>  static const char ms5637_show_samp_freq[] = "960 480 240 120 60 30";
> @@ -169,8 +181,10 @@ static int ms5637_probe(struct i2c_client *client,
>  }
>  
>  static const struct i2c_device_id ms5637_id[] = {
> -	{"ms5637", 0},
> -	{"ms8607-temppressure", 1},
> +	{"ms5637", MS5637},
> +	{"ms8607-temppressure", MS8607},
> +	{"ms5805", MS5805},
> +	{"ms5837", MS5837},
>  	{}
>  };
>  
> 

-- 

Peter Meerwald-Stadler
+43-664-2444418 (mobile)

RE: [PATCH] iio: (ms5637) Add Measurement Specialties explicit MS5805 and MS5837 support

[Markezana, William]

On Tue, 31 May 2016, Markezana, William wrote:

> Signed-off-by: William Markezana <william.markezana@meas-spec.com>
> ---
>  drivers/iio/pressure/ms5637.c | 20 +++++++++++++++++---
>  1 file changed, 17 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/pressure/ms5637.c 
> b/drivers/iio/pressure/ms5637.c index e8d0e0d..6ecc686 100644
> --- a/drivers/iio/pressure/ms5637.c
> +++ b/drivers/iio/pressure/ms5637.c
> @@ -1,5 +1,6 @@
>  /*
> - * ms5637.c - Support for Measurement-Specialties ms5637 and ms8607
> + * ms5637.c - Support for Measurement-Specialties ms5637, ms8607,
> +              ms5805 and ms5837

I guess we expect it to look like
 *             ms5805 and ms5837 pressure & temperature sensors

and I suggest to list the chips in lexicographic order (here and all other
lists)

-I will update the patch according to you suggestion.

it seems there is no functional difference?

-All sensors are different and have various measurement range. 
This patch is about making people aware that this driver is compatible 
with other sensors without duplicating code. 
Is there a better way to do that ?

>   *            pressure & temperature sensor
>   *
>   * Copyright (c) 2015 Measurement-Specialties @@ -12,6 +13,10 @@
>   *  http://www.meas-spec.com/downloads/MS5637-02BA03.pdf
>   * Datasheet:
>   *  http://www.meas-spec.com/downloads/MS8607-02BA01.pdf
> + * Datasheet:
> + *  http://www.meas-spec.com/downloads/MS5805-02BA01.pdf
> + * Datasheet:
> + *  http://meas-spec.com/downloads/MS5837-30BA.pdf
>   */
>  
>  #include <linux/init.h>
> @@ -26,6 +31,13 @@
>  
>  #include "../common/ms_sensors/ms_sensors_i2c.h"
>  
> +enum {
> +	MS5637,
> +	MS8607,
> +	MS5805,
> +	MS5837
> +};
> +
>  static const int ms5637_samp_freq[6] = { 960, 480, 240, 120, 60, 30 
> };
>  /* String copy of the above const for readability purpose */  static 
> const char ms5637_show_samp_freq[] = "960 480 240 120 60 30"; @@ 
> -169,8 +181,10 @@ static int ms5637_probe(struct i2c_client *client,  
> }
>  
>  static const struct i2c_device_id ms5637_id[] = {
> -	{"ms5637", 0},
> -	{"ms8607-temppressure", 1},
> +	{"ms5637", MS5637},
> +	{"ms8607-temppressure", MS8607},
> +	{"ms5805", MS5805},
> +	{"ms5837", MS5837},
>  	{}
>  };
>  
> 

-- 

Peter Meerwald-Stadler
+43-664-2444418 (mobile)

Re: [PATCH] iio: (ms5637) Add Measurement Specialties explicit MS5805 and MS5837 support

[Jonathan Cameron]

On 01/06/16 08:27, Markezana, William wrote:
> On Tue, 31 May 2016, Markezana, William wrote:
> 
>> Signed-off-by: William Markezana <william.markezana@meas-spec.com>
>> ---
>>  drivers/iio/pressure/ms5637.c | 20 +++++++++++++++++---
>>  1 file changed, 17 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/pressure/ms5637.c 
>> b/drivers/iio/pressure/ms5637.c index e8d0e0d..6ecc686 100644
>> --- a/drivers/iio/pressure/ms5637.c
>> +++ b/drivers/iio/pressure/ms5637.c
>> @@ -1,5 +1,6 @@
>>  /*
>> - * ms5637.c - Support for Measurement-Specialties ms5637 and ms8607
>> + * ms5637.c - Support for Measurement-Specialties ms5637, ms8607,
>> +              ms5805 and ms5837
> 
> I guess we expect it to look like
>  *             ms5805 and ms5837 pressure & temperature sensors
> 
> and I suggest to list the chips in lexicographic order (here and all other
> lists)
> 
> -I will update the patch according to you suggestion.
> 
> it seems there is no functional difference?
> 
> -All sensors are different and have various measurement range. 
> This patch is about making people aware that this driver is compatible 
> with other sensors without duplicating code. 
> Is there a better way to do that ?
This is fine. 

As far as I can immediately see though the enum values are unused?

If so, don't bother having the enum and set all the client data to 0.

Thanks,

Jonathan
> 
>>   *            pressure & temperature sensor
>>   *
>>   * Copyright (c) 2015 Measurement-Specialties @@ -12,6 +13,10 @@
>>   *  http://www.meas-spec.com/downloads/MS5637-02BA03.pdf
>>   * Datasheet:
>>   *  http://www.meas-spec.com/downloads/MS8607-02BA01.pdf
>> + * Datasheet:
>> + *  http://www.meas-spec.com/downloads/MS5805-02BA01.pdf
>> + * Datasheet:
>> + *  http://meas-spec.com/downloads/MS5837-30BA.pdf
>>   */
>>  
>>  #include <linux/init.h>
>> @@ -26,6 +31,13 @@
>>  
>>  #include "../common/ms_sensors/ms_sensors_i2c.h"
>>  
>> +enum {
>> +	MS5637,
>> +	MS8607,
>> +	MS5805,
>> +	MS5837
>> +};
>> +
>>  static const int ms5637_samp_freq[6] = { 960, 480, 240, 120, 60, 30 
>> };
>>  /* String copy of the above const for readability purpose */  static 
>> const char ms5637_show_samp_freq[] = "960 480 240 120 60 30"; @@ 
>> -169,8 +181,10 @@ static int ms5637_probe(struct i2c_client *client,  
>> }
>>  
>>  static const struct i2c_device_id ms5637_id[] = {
>> -	{"ms5637", 0},
>> -	{"ms8607-temppressure", 1},
>> +	{"ms5637", MS5637},
>> +	{"ms8607-temppressure", MS8607},
>> +	{"ms5805", MS5805},
>> +	{"ms5837", MS5837},
>>  	{}
>>  };
>>  
>>
> 

RE: [PATCH] iio: (ms5637) Add Measurement Specialties explicit MS5805 and MS5837 support

[Markezana, William]

iio: (ms5637) Add Measurement Specialties explicit MS5805 and MS5837 suppor=
t

Signed-off-by: William Markezana <william.markezana@meas-spec.com>
---
 drivers/iio/pressure/ms5637.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/pressure/ms5637.c b/drivers/iio/pressure/ms5637.c
index e8d0e0d..66f1a4c 100644
--- a/drivers/iio/pressure/ms5637.c
+++ b/drivers/iio/pressure/ms5637.c
@@ -1,6 +1,6 @@
 /*
- * ms5637.c - Support for Measurement-Specialties ms5637 and ms8607
- *            pressure & temperature sensor
+ * ms5637.c - Support for Measurement-Specialties MS5637, MS5805
+ *            MS5837 and MS8607 pressure & temperature sensor
  *
  * Copyright (c) 2015 Measurement-Specialties
  *
@@ -11,6 +11,10 @@
  * Datasheet:
  *  http://www.meas-spec.com/downloads/MS5637-02BA03.pdf
  * Datasheet:
+ *  http://www.meas-spec.com/downloads/MS5805-02BA01.pdf
+ * Datasheet:
+ *  http://www.meas-spec.com/downloads/MS5837-30BA.pdf
+ * Datasheet:
  *  http://www.meas-spec.com/downloads/MS8607-02BA01.pdf
  */
=20
@@ -170,7 +174,9 @@ static int ms5637_probe(struct i2c_client *client,
=20
 static const struct i2c_device_id ms5637_id[] =3D {
 	{"ms5637", 0},
-	{"ms8607-temppressure", 1},
+	{"ms5805", 0},
+	{"ms5837", 0},
+	{"ms8607-temppressure", 0},
 	{}
 };
=20
--=20
2.1.4

Re: [PATCH] iio: (ms5637) Add Measurement Specialties explicit MS5805 and MS5837 support

[Jonathan Cameron]

On 06/06/16 09:12, Markezana, William wrote:
> iio: (ms5637) Add Measurement Specialties explicit MS5805 and MS5837 support
> 
> Signed-off-by: William Markezana <william.markezana@meas-spec.com>
Please send a new series, with [PATCH V2] as the title for a new version.
Try applying this with git AM and you'll see the fun it makes from this
commit message.

Fixed up and applied with some fuzz to the togreg branch of iio.git
Initially pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/pressure/ms5637.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/pressure/ms5637.c b/drivers/iio/pressure/ms5637.c
> index e8d0e0d..66f1a4c 100644
> --- a/drivers/iio/pressure/ms5637.c
> +++ b/drivers/iio/pressure/ms5637.c
> @@ -1,6 +1,6 @@
>  /*
> - * ms5637.c - Support for Measurement-Specialties ms5637 and ms8607
> - *            pressure & temperature sensor
> + * ms5637.c - Support for Measurement-Specialties MS5637, MS5805
> + *            MS5837 and MS8607 pressure & temperature sensor
>   *
>   * Copyright (c) 2015 Measurement-Specialties
>   *
> @@ -11,6 +11,10 @@
>   * Datasheet:
>   *  http://www.meas-spec.com/downloads/MS5637-02BA03.pdf
>   * Datasheet:
> + *  http://www.meas-spec.com/downloads/MS5805-02BA01.pdf
> + * Datasheet:
> + *  http://www.meas-spec.com/downloads/MS5837-30BA.pdf
> + * Datasheet:
>   *  http://www.meas-spec.com/downloads/MS8607-02BA01.pdf
>   */
>  
> @@ -170,7 +174,9 @@ static int ms5637_probe(struct i2c_client *client,
>  
>  static const struct i2c_device_id ms5637_id[] = {
>  	{"ms5637", 0},
> -	{"ms8607-temppressure", 1},
> +	{"ms5805", 0},
> +	{"ms5837", 0},
> +	{"ms8607-temppressure", 0},
>  	{}
>  };
>  
>