* [PATCH] iio: imu: bmi323: check i2c_transfer() return value
@ 2026-11-19 7:08 Siqi Chen
2026-11-19 9:27 ` Joshua Crofts
2026-11-19 9:30 ` Joshua Crofts
0 siblings, 2 replies; 3+ messages in thread
From: Siqi Chen @ 2026-11-19 7:08 UTC (permalink / raw)
To: jagathjog1996, jic23; +Cc: dlechner, nuno.sa, andy, linux-iio, linux-kernel
i2c_transfer() returns the number of messages transferred or a negative
error code. The BMI323 I2C read path only checks for negative values and
maps all errors to -EIO.
If only the register-address message is transferred, the function copies
data from the receive buffer and reports success even though the read
message was not completed.
Require both messages to be transferred, preserve negative error codes,
and return -EIO for a short transfer.
OpenCode was used to identify the issue and draft the code and changelog.
Compile-tested with CONFIG_BMI323_I2C=m using:
make O=/tmp/opencode/linux-build-bmi323 W=1 \
drivers/iio/imu/bmi323/bmi323_i2c.o
No hardware or I2C fault-injection testing was performed.
Fixes: 8a636db3aa57 ("iio: imu: Add driver for BMI323 IMU")
Signed-off-by: Siqi Chen <chensiqi@uniontech.com>
---
drivers/iio/imu/bmi323/bmi323_i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/imu/bmi323/bmi323_i2c.c b/drivers/iio/imu/bmi323/bmi323_i2c.c
index e025c88c30b4..18f05f119961 100644
--- a/drivers/iio/imu/bmi323/bmi323_i2c.c
+++ b/drivers/iio/imu/bmi323/bmi323_i2c.c
@@ -40,8 +40,8 @@ static int bmi323_regmap_i2c_read(void *context, const void *reg_buf,
msgs[1].flags = priv->i2c->flags | I2C_M_RD;
ret = i2c_transfer(priv->i2c->adapter, msgs, ARRAY_SIZE(msgs));
- if (ret < 0)
- return -EIO;
+ if (ret != ARRAY_SIZE(msgs))
+ return ret < 0 ? ret : -EIO;
memcpy(val_buf, priv->i2c_rx_buffer + BMI323_I2C_DUMMY, val_size);
base-commit: c1b99c6982dccade0199879966a2d97f27a0a110
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: imu: bmi323: check i2c_transfer() return value
2026-11-19 7:08 [PATCH] iio: imu: bmi323: check i2c_transfer() return value Siqi Chen
@ 2026-11-19 9:27 ` Joshua Crofts
2026-11-19 9:30 ` Joshua Crofts
1 sibling, 0 replies; 3+ messages in thread
From: Joshua Crofts @ 2026-11-19 9:27 UTC (permalink / raw)
To: Siqi Chen, jagathjog1996, jic23
Cc: dlechner, nuno.sa, andy, linux-iio, linux-kernel
On 19-Nov-26 8:08, Siqi Chen wrote:
> drivers/iio/imu/bmi323/bmi323_i2c.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/bmi323/bmi323_i2c.c b/drivers/iio/imu/bmi323/bmi323_i2c.c
> index e025c88c30b4..18f05f119961 100644
> --- a/drivers/iio/imu/bmi323/bmi323_i2c.c
> +++ b/drivers/iio/imu/bmi323/bmi323_i2c.c
> @@ -40,8 +40,8 @@ static int bmi323_regmap_i2c_read(void *context, const void *reg_buf,
> msgs[1].flags = priv->i2c->flags | I2C_M_RD;
>
> ret = i2c_transfer(priv->i2c->adapter, msgs, ARRAY_SIZE(msgs));
> - if (ret < 0)
> - return -EIO;
> + if (ret != ARRAY_SIZE(msgs))
> + return ret < 0 ? ret : -EIO;
Better to do
if (ret < 0)
return ret;
if (ret != ARRAY_SIZE(msgs))
return -EIO;
It improves readability.
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: imu: bmi323: check i2c_transfer() return value
2026-11-19 7:08 [PATCH] iio: imu: bmi323: check i2c_transfer() return value Siqi Chen
2026-11-19 9:27 ` Joshua Crofts
@ 2026-11-19 9:30 ` Joshua Crofts
1 sibling, 0 replies; 3+ messages in thread
From: Joshua Crofts @ 2026-11-19 9:30 UTC (permalink / raw)
To: Siqi Chen, jagathjog1996, jic23
Cc: dlechner, nuno.sa, andy, linux-iio, linux-kernel
On 19-Nov-26 8:08, Siqi Chen wrote:
> i2c_transfer() returns the number of messages transferred or a negative
> error code. The BMI323 I2C read path only checks for negative values and
> maps all errors to -EIO.
>
> If only the register-address message is transferred, the function copies
> data from the receive buffer and reports success even though the read
> message was not completed.
>
> Require both messages to be transferred, preserve negative error codes,
> and return -EIO for a short transfer.
>
> OpenCode was used to identify the issue and draft the code and changelog.
>
> Compile-tested with CONFIG_BMI323_I2C=m using:
>
> make O=/tmp/opencode/linux-build-bmi323 W=1 \
> drivers/iio/imu/bmi323/bmi323_i2c.o
>
> No hardware or I2C fault-injection testing was performed.
Also the testing info should go under the ---, as it's compile tested only.
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-19 9:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 7:08 [PATCH] iio: imu: bmi323: check i2c_transfer() return value Siqi Chen
2026-11-19 9:27 ` Joshua Crofts
2026-11-19 9:30 ` Joshua Crofts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox