2.6.26-rc3 - appletouch resume "incomplete data package"

2.6.26-rc3 - appletouch resume "incomplete data package"

[Bob Copeland]

This appears to be a regression since 2.6.25.  After resuming, I get:

    appletouch: incomplete data package (first byte: 2, length: 4).
    appletouch: incomplete data package (first byte: 2, length: 4).
    appletouch: incomplete data package (first byte: 2, length: 4).
    [...]

And the touchpad doesn't work.  This is on a first gen MacBook.  I
didn't see any changes to the driver itself in that timeframe.
Anyone have ideas, or should I try a bisect?

-- 
Bob Copeland %% www.bobcopeland.com

Re: 2.6.26-rc3 - appletouch resume "incomplete data package"

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

On Sun, 2008-05-25 at 16:24 -0400, Bob Copeland wrote:
> This appears to be a regression since 2.6.25.  After resuming, I get:
> 
>     appletouch: incomplete data package (first byte: 2, length: 4).
>     appletouch: incomplete data package (first byte: 2, length: 4).
>     appletouch: incomplete data package (first byte: 2, length: 4).
>     [...]
> 
> And the touchpad doesn't work.  This is on a first gen MacBook.  I
> didn't see any changes to the driver itself in that timeframe.
> Anyone have ideas, or should I try a bisect?

I have intermittently seen this problem happen for quite a while, a
bisect will probably not help you. The "incomplete data package" message
doesn't actually seem to be related to the fact that suspend/resume
sometimes breaks the touchpad though, it seems to happen, for example,
when you switch from X to a console and back, something must be bad with
the timing, possibly even in the hardware.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: 2.6.26-rc3 - appletouch resume "incomplete data package"

[Oliver Neukum]

Am Sonntag 25 Mai 2008 22:24:13 schrieb Bob Copeland:
> This appears to be a regression since 2.6.25.  After resuming, I get:
> 
>     appletouch: incomplete data package (first byte: 2, length: 4).
>     appletouch: incomplete data package (first byte: 2, length: 4).
>     appletouch: incomplete data package (first byte: 2, length: 4).
>     [...]
> 
> And the touchpad doesn't work.  This is on a first gen MacBook.  I
> didn't see any changes to the driver itself in that timeframe.
> Anyone have ideas, or should I try a bisect?
> 

Can you add a RESET_RESUME quirk for the device?

	Regards
		Oliver

Re: 2.6.26-rc3 - appletouch resume "incomplete data package"

[Bob Copeland]

On Mon, May 26, 2008 at 7:06 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Sun, 2008-05-25 at 16:24 -0400, Bob Copeland wrote:
>> This appears to be a regression since 2.6.25.  After resuming, I get:
>>
>>     appletouch: incomplete data package (first byte: 2, length: 4).
>>     appletouch: incomplete data package (first byte: 2, length: 4).
>>     appletouch: incomplete data package (first byte: 2, length: 4).

> I have intermittently seen this problem happen for quite a while, a
> bisect will probably not help you.

Hmm, well the console switch in suspend may be triggering it, but I
didn't have the issue in 2.6.25 and it seems to be easily repeatable
for me in .26 so far.  Doing ctrl-alt-f1 to switch to text mode and
back a dozen times didn't break the mouse, but suspending once did.

I tried a bisect anyway but didn't come up with any smoking gun.  Darn.

-- 
Bob Copeland %% www.bobcopeland.com

Re: 2.6.26-rc3 - appletouch resume "incomplete data package"

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]

On Thu, 2008-05-29 at 22:56 -0400, Bob Copeland wrote:
> On Mon, May 26, 2008 at 7:06 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Sun, 2008-05-25 at 16:24 -0400, Bob Copeland wrote:
> >> This appears to be a regression since 2.6.25.  After resuming, I get:
> >>
> >>     appletouch: incomplete data package (first byte: 2, length: 4).
> >>     appletouch: incomplete data package (first byte: 2, length: 4).
> >>     appletouch: incomplete data package (first byte: 2, length: 4).
> 
> > I have intermittently seen this problem happen for quite a while, a
> > bisect will probably not help you.
> 
> Hmm, well the console switch in suspend may be triggering it, but I
> didn't have the issue in 2.6.25 and it seems to be easily repeatable
> for me in .26 so far.  Doing ctrl-alt-f1 to switch to text mode and
> back a dozen times didn't break the mouse, but suspending once did.

Oh I didn't say it breaks, the thing is I get this message once a while
without it breaking, while suspend once a while breaks it (but I'm not
sure the message happens when it breaks)

> I tried a bisect anyway but didn't come up with any smoking gun.  Darn.

Yeah, I tried looking at the code but didn't really find anything
either. There must be something else... The thing is, nothing makes
sense unless there's a bug elsewhere, because it works fine after you
resume broken and reload the module. But reloading the module doesn't
really do anything to the hardware, it only submits a new urb while
resume simply resubmits the old one. All the other code is
kernel-internal housekeeping stuff.

Or can the urb endpoint information change so we need to re-do
usb_fill_int_urb?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]