From: Joe Perches <joe@perches.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <trivial@kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use
Date: Tue, 26 Oct 2010 18:10:25 -0700 [thread overview]
Message-ID: <1288141825.4145.83.camel@Joe-Laptop> (raw)
In-Reply-To: <BFA186FD-32F7-4E1A-9193-CA1575248B73@gmail.com>
On Tue, 2010-10-26 at 18:00 -0700, Dmitry Torokhov wrote:
> On Oct 26, 2010, at 5:46 PM, Joe Perches <joe@perches.com> wrote:
> > On Tue, 2010-10-26 at 17:40 -0700, Dmitry Torokhov wrote:
> >>> Mind if I move the time to the front like this?
> >>> +#define dbg(format, arg...) \
> >>> +do { \
> >>> + if (i8042_debug) \
> >>> + printk(KERN_DEBUG KBUILD_MODNAME ": [%d]" format), \
> >>> + (int)(jiffies - i8042_start_time), ##arg); \
> >>> +} while (0)
> >> Another option would be to leave '\n' in dbg() and leave most of the
> >> callers as is.
> > That's really error prone though.
> In what way?
$ grep -w dbg drivers/input/serio/i8042.c | cat -n
1 dbg("%02x <- i8042 (flush, %s)", data,
2 dbg("%02x -> i8042 (command)", command & 0xff);
3 dbg("%02x -> i8042 (parameter)", param[i]);
4 dbg(" -- i8042 (timeout)");
5 dbg(" -- i8042 (auxerr)");
6 dbg("%02x <- i8042 (return)", param[i]);
7 dbg("%02x -> i8042 (kbd-data)", c);
8 dbg("Extra keyboard ACK - filtered out\n");
9 dbg("Filtered out by platform filter\n");
10 if (irq) dbg("Interrupt %d, without any data", irq);
11 dbg("MUX error, status is %02x, data is %02x", str, data);
12 dbg("%02x <- i8042 (interrupt, %d, %d%s%s)",
13 dbg("%02x <- i8042 (aux_test_irq, %s)",
14 dbg(" -- i8042 (aux irq test timeout)");
15 dbg("%02x -> i8042 (panic blink)", 0xed);
16 dbg("%02x -> i8042 (panic blink)", led);
I think 2 defects in 16 uses is a pretty high error rate.
next prev parent reply other threads:[~2010-10-27 1:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 2:44 [PATCH 00/10] Remove multiple uses of KERN_<level> Joe Perches
2010-10-26 2:44 ` [PATCH 03/10] drivers/hid/hid-input.c: Remove KERN_DEBUG from dbg_hid use Joe Perches
2010-11-03 14:13 ` Jiri Kosina
2010-10-26 2:44 ` [PATCH 05/10] drivers/input/mouse/appletouch.c: Remove KERN_DEBUG use from dprintk Joe Perches
2010-10-26 15:52 ` Dmitry Torokhov
2010-10-26 2:44 ` [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use Joe Perches
2010-10-26 15:50 ` Dmitry Torokhov
2010-10-26 23:25 ` Joe Perches
2010-10-27 0:40 ` Dmitry Torokhov
2010-10-27 0:46 ` Joe Perches
2010-10-27 1:00 ` Dmitry Torokhov
2010-10-27 1:10 ` Joe Perches [this message]
2010-10-27 1:28 ` Dmitry Torokhov
2010-10-27 1:35 ` Joe Perches
2010-10-27 3:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288141825.4145.83.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox