* [PATCH v2] hid: Fix uninitialized variable "size" in hid-wiimote-debug
@ 2013-01-17 21:02 Simon Que
2013-01-17 21:07 ` David Herrmann
0 siblings, 1 reply; 3+ messages in thread
From: Simon Que @ 2013-01-17 21:02 UTC (permalink / raw)
To: jkosina, dh.herrmann, linux-input; +Cc: msb, Simon Que
This variable is initialized conditionally, based on whether a wiimote
call succeeds. However, the logic is not obvious to the compiler so it
throws a warning. Eliminate the warning by initializing "size" to 0.
The warning is:
files/drivers/hid/hid-wiimote-debug.c:69:18: warning: 'size' may be used
uninitialized in this function [-Wmaybe-uninitialized]
Signed-off-by: Simon Que <sque@chromium.org>
---
drivers/hid/hid-wiimote-debug.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-wiimote-debug.c b/drivers/hid/hid-wiimote-debug.c
index eec3291..90124ff 100644
--- a/drivers/hid/hid-wiimote-debug.c
+++ b/drivers/hid/hid-wiimote-debug.c
@@ -31,7 +31,7 @@ static ssize_t wiidebug_eeprom_read(struct file *f, char __user *u, size_t s,
unsigned long flags;
ssize_t ret;
char buf[16];
- __u16 size;
+ __u16 size = 0;
if (s == 0)
return -EINVAL;
--
1.7.8.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] hid: Fix uninitialized variable "size" in hid-wiimote-debug
2013-01-17 21:02 [PATCH v2] hid: Fix uninitialized variable "size" in hid-wiimote-debug Simon Que
@ 2013-01-17 21:07 ` David Herrmann
2013-01-18 9:59 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: David Herrmann @ 2013-01-17 21:07 UTC (permalink / raw)
To: Simon Que; +Cc: jkosina, linux-input, msb
Hi Simon
On Thu, Jan 17, 2013 at 10:02 PM, Simon Que <sque@chromium.org> wrote:
> This variable is initialized conditionally, based on whether a wiimote
> call succeeds. However, the logic is not obvious to the compiler so it
> throws a warning. Eliminate the warning by initializing "size" to 0.
>
> The warning is:
> files/drivers/hid/hid-wiimote-debug.c:69:18: warning: 'size' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
Thanks!
Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> Signed-off-by: Simon Que <sque@chromium.org>
> ---
> drivers/hid/hid-wiimote-debug.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-wiimote-debug.c b/drivers/hid/hid-wiimote-debug.c
> index eec3291..90124ff 100644
> --- a/drivers/hid/hid-wiimote-debug.c
> +++ b/drivers/hid/hid-wiimote-debug.c
> @@ -31,7 +31,7 @@ static ssize_t wiidebug_eeprom_read(struct file *f, char __user *u, size_t s,
> unsigned long flags;
> ssize_t ret;
> char buf[16];
> - __u16 size;
> + __u16 size = 0;
>
> if (s == 0)
> return -EINVAL;
> --
> 1.7.8.6
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] hid: Fix uninitialized variable "size" in hid-wiimote-debug
2013-01-17 21:07 ` David Herrmann
@ 2013-01-18 9:59 ` Jiri Kosina
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2013-01-18 9:59 UTC (permalink / raw)
To: David Herrmann; +Cc: Simon Que, linux-input, msb
On Thu, 17 Jan 2013, David Herrmann wrote:
> > This variable is initialized conditionally, based on whether a wiimote
> > call succeeds. However, the logic is not obvious to the compiler so it
> > throws a warning. Eliminate the warning by initializing "size" to 0.
> >
> > The warning is:
> > files/drivers/hid/hid-wiimote-debug.c:69:18: warning: 'size' may be used
> > uninitialized in this function [-Wmaybe-uninitialized]
>
> Thanks!
>
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
Applied, thanks!
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-18 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-17 21:02 [PATCH v2] hid: Fix uninitialized variable "size" in hid-wiimote-debug Simon Que
2013-01-17 21:07 ` David Herrmann
2013-01-18 9:59 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox