* [PATCH v3.11-rc2] HID: sony: fix HID mapping for PS3 sixaxis controller
@ 2013-07-24 14:53 Benjamin Tissoires
2013-07-24 14:57 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Tissoires @ 2013-07-24 14:53 UTC (permalink / raw)
To: Benjamin Tissoires, Jiri Kosina, linux-input, linux-kernel
Commit f04d51404f51 (HID: driver for PS2/3 Buzz controllers) introduced
an input_mapping() callback, but set the return value to -1 to all devices
except the Buzz controllers. The result of this is that the Sixaxis input
device is not populated, making it useless.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
Hi Jiri,
I have since yesterday a Sixaxis controller on my desk, and I noticed that it
was broken in v3.11.
Cheers,
Benjamin
drivers/hid/hid-sony.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index ecbc749..87fbe29 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -369,7 +369,8 @@ static int sony_mapping(struct hid_device *hdev, struct hid_input *hi,
if (sc->quirks & PS3REMOTE)
return ps3remote_mapping(hdev, hi, field, usage, bit, max);
- return -1;
+ /* Let hid-core decide for the others */
+ return 0;
}
/*
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3.11-rc2] HID: sony: fix HID mapping for PS3 sixaxis controller
2013-07-24 14:53 [PATCH v3.11-rc2] HID: sony: fix HID mapping for PS3 sixaxis controller Benjamin Tissoires
@ 2013-07-24 14:57 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2013-07-24 14:57 UTC (permalink / raw)
To: Benjamin Tissoires; +Cc: Benjamin Tissoires, linux-input, linux-kernel
On Wed, 24 Jul 2013, Benjamin Tissoires wrote:
> Commit f04d51404f51 (HID: driver for PS2/3 Buzz controllers) introduced
> an input_mapping() callback, but set the return value to -1 to all devices
> except the Buzz controllers. The result of this is that the Sixaxis input
> device is not populated, making it useless.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> Hi Jiri,
>
> I have since yesterday a Sixaxis controller on my desk, and I noticed that it
> was broken in v3.11.
Good catch, applied, thanks Benjamin.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-24 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-24 14:53 [PATCH v3.11-rc2] HID: sony: fix HID mapping for PS3 sixaxis controller Benjamin Tissoires
2013-07-24 14:57 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox