Linux Input/HID development
 help / color / mirror / Atom feed
* [RFC] Input: Remove unused BUS IDs
@ 2014-12-01 10:51 Jarkko Nikula
  2014-12-01 10:57 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: Jarkko Nikula @ 2014-12-01 10:51 UTC (permalink / raw)
  To: linux-input; +Cc: Dmitry Torokhov, Dmitry Torokhov, Jarkko Nikula

There are a few BUS IDs that are not used anywhere in kernel tree:

- BUS_ISAPNP
  Has no changes or use in kernel git history
- BUS_GSC
  Was added by commit 6ab0f5cd3644 ("[PARISC] Update parisc specific input
  code from parisc tree") but never used
- BUS_ATARI
  Became unused after commit 6615c5b25e0b ("m68k: Atari input drivers
  cleanup")

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
I'm not familiar with the input and don't know is there use for these in
userspace. Therefore I didn't sort these IDs after removal.
---
 include/uapi/linux/input.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index 1874ebe9ac1e..39d535034169 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -940,7 +940,6 @@ struct input_keymap_entry {
 #define ID_VERSION		3
 
 #define BUS_PCI			0x01
-#define BUS_ISAPNP		0x02
 #define BUS_USB			0x03
 #define BUS_HIL			0x04
 #define BUS_BLUETOOTH		0x05
@@ -956,8 +955,6 @@ struct input_keymap_entry {
 #define BUS_ADB			0x17
 #define BUS_I2C			0x18
 #define BUS_HOST		0x19
-#define BUS_GSC			0x1A
-#define BUS_ATARI		0x1B
 #define BUS_SPI			0x1C
 
 /*
-- 
2.1.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RFC] Input: Remove unused BUS IDs
  2014-12-01 10:51 [RFC] Input: Remove unused BUS IDs Jarkko Nikula
@ 2014-12-01 10:57 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2014-12-01 10:57 UTC (permalink / raw)
  To: Jarkko Nikula; +Cc: linux-input, Dmitry Torokhov, Dmitry Torokhov

Hi Jarkko,

> There are a few BUS IDs that are not used anywhere in kernel tree:
> 
> - BUS_ISAPNP
>  Has no changes or use in kernel git history
> - BUS_GSC
>  Was added by commit 6ab0f5cd3644 ("[PARISC] Update parisc specific input
>  code from parisc tree") but never used
> - BUS_ATARI
>  Became unused after commit 6615c5b25e0b ("m68k: Atari input drivers
>  cleanup")
> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
> I'm not familiar with the input and don't know is there use for these in
> userspace. Therefore I didn't sort these IDs after removal.

actually /dev/uinput can still use these values if it wants to.

Regards

Marcel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-01 10:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-01 10:51 [RFC] Input: Remove unused BUS IDs Jarkko Nikula
2014-12-01 10:57 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox