Linux Input/HID development
 help / color / mirror / Atom feed
* [PATCH v2 1/1] dt-bindings: input: touchscreen: convert lpc32xx-tsc.txt to yaml format
@ 2025-06-25 16:34 Frank Li
  2025-06-27 21:07 ` Rob Herring (Arm)
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Frank Li @ 2025-06-25 16:34 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Vladimir Zapolskiy, Piotr Wojtaszczyk,
	open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/LPC32XX SOC SUPPORT, open list
  Cc: imx

Convert lpc32xx-tsc.txt to yaml format.

Additional changes:
- add clocks and put it into required list to match existed lpc32xx.dtsi.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
changes in v2
- add clocks and put it into required list to match existed lpc32xx.dtsi.
---
 .../input/touchscreen/lpc32xx-tsc.txt         | 16 -------
 .../input/touchscreen/nxp,lpc3220-tsc.yaml    | 43 +++++++++++++++++++
 2 files changed, 43 insertions(+), 16 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml

diff --git a/Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt b/Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt
deleted file mode 100644
index 41cbf4b7a670d..0000000000000
--- a/Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt
+++ /dev/null
@@ -1,16 +0,0 @@
-* NXP LPC32xx SoC Touchscreen Controller (TSC)
-
-Required properties:
-- compatible: must be "nxp,lpc3220-tsc"
-- reg: physical base address of the controller and length of memory mapped
-  region.
-- interrupts: The TSC/ADC interrupt
-
-Example:
-
-	tsc@40048000 {
-		compatible = "nxp,lpc3220-tsc";
-		reg = <0x40048000 0x1000>;
-		interrupt-parent = <&mic>;
-		interrupts = <39 0>;
-	};
diff --git a/Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml
new file mode 100644
index 0000000000000..b6feda127c7b5
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/touchscreen/nxp,lpc3220-tsc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP LPC32xx SoC Touchscreen Controller (TSC)
+
+maintainers:
+  - Frank Li <Frank.Li@nxp.com>
+
+properties:
+  compatible:
+    const: nxp,lpc3220-tsc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/lpc32xx-clock.h>
+
+    touchscreen@40048000 {
+        compatible = "nxp,lpc3220-tsc";
+        reg = <0x40048000 0x1000>;
+        interrupt-parent = <&mic>;
+        interrupts = <39 0>;
+        clocks = <&clk LPC32XX_CLK_ADC>;
+    };
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] dt-bindings: input: touchscreen: convert lpc32xx-tsc.txt to yaml format
  2025-06-25 16:34 [PATCH v2 1/1] dt-bindings: input: touchscreen: convert lpc32xx-tsc.txt to yaml format Frank Li
@ 2025-06-27 21:07 ` Rob Herring (Arm)
  2025-06-28  0:59 ` Dmitry Torokhov
  2025-06-28  1:01 ` Vladimir Zapolskiy
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-06-27 21:07 UTC (permalink / raw)
  To: Frank Li
  Cc: linux-arm-kernel, linux-input, Dmitry Torokhov,
	Krzysztof Kozlowski, devicetree, Conor Dooley, imx, linux-kernel,
	Piotr Wojtaszczyk, Vladimir Zapolskiy


On Wed, 25 Jun 2025 12:34:28 -0400, Frank Li wrote:
> Convert lpc32xx-tsc.txt to yaml format.
> 
> Additional changes:
> - add clocks and put it into required list to match existed lpc32xx.dtsi.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> changes in v2
> - add clocks and put it into required list to match existed lpc32xx.dtsi.
> ---
>  .../input/touchscreen/lpc32xx-tsc.txt         | 16 -------
>  .../input/touchscreen/nxp,lpc3220-tsc.yaml    | 43 +++++++++++++++++++
>  2 files changed, 43 insertions(+), 16 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] dt-bindings: input: touchscreen: convert lpc32xx-tsc.txt to yaml format
  2025-06-25 16:34 [PATCH v2 1/1] dt-bindings: input: touchscreen: convert lpc32xx-tsc.txt to yaml format Frank Li
  2025-06-27 21:07 ` Rob Herring (Arm)
@ 2025-06-28  0:59 ` Dmitry Torokhov
  2025-06-28  1:01 ` Vladimir Zapolskiy
  2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2025-06-28  0:59 UTC (permalink / raw)
  To: Frank Li
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Vladimir Zapolskiy, Piotr Wojtaszczyk,
	open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/LPC32XX SOC SUPPORT, open list, imx

On Wed, Jun 25, 2025 at 12:34:28PM -0400, Frank Li wrote:
> Convert lpc32xx-tsc.txt to yaml format.
> 
> Additional changes:
> - add clocks and put it into required list to match existed lpc32xx.dtsi.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Applied, thank you.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] dt-bindings: input: touchscreen: convert lpc32xx-tsc.txt to yaml format
  2025-06-25 16:34 [PATCH v2 1/1] dt-bindings: input: touchscreen: convert lpc32xx-tsc.txt to yaml format Frank Li
  2025-06-27 21:07 ` Rob Herring (Arm)
  2025-06-28  0:59 ` Dmitry Torokhov
@ 2025-06-28  1:01 ` Vladimir Zapolskiy
  2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Zapolskiy @ 2025-06-28  1:01 UTC (permalink / raw)
  To: Frank Li, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Piotr Wojtaszczyk,
	open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/LPC32XX SOC SUPPORT, open list
  Cc: imx

On 6/25/25 19:34, Frank Li wrote:
> Convert lpc32xx-tsc.txt to yaml format.
> 
> Additional changes:
> - add clocks and put it into required list to match existed lpc32xx.dtsi.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

<snip>

> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/lpc32xx-clock.h>
> +
> +    touchscreen@40048000 {
> +        compatible = "nxp,lpc3220-tsc";
> +        reg = <0x40048000 0x1000>;
> +        interrupt-parent = <&mic>;
> +        interrupts = <39 0>;

interrupt-parent = <&sic1>;
interrupts = <7 4>;

> +        clocks = <&clk LPC32XX_CLK_ADC>;
> +    };

With this minor asked correction, feel free to add my

Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>

-- 
Best wishes,
Vladimir

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-06-28  1:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-25 16:34 [PATCH v2 1/1] dt-bindings: input: touchscreen: convert lpc32xx-tsc.txt to yaml format Frank Li
2025-06-27 21:07 ` Rob Herring (Arm)
2025-06-28  0:59 ` Dmitry Torokhov
2025-06-28  1:01 ` Vladimir Zapolskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox