Linux Input/HID development
 help / color / mirror / Atom feed
* [PATCH] HID: quirks: add ALWAYS_POLL quirk for SDINNOVATION gaming keyboard
@ 2026-08-24  3:14 Junjie Cao
  2026-09-07  2:44 ` Junjie Cao
  2026-09-07 13:32 ` Benjamin Tissoires
  0 siblings, 2 replies; 3+ messages in thread
From: Junjie Cao @ 2026-08-24  3:14 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires
  Cc: linux-input, linux-kernel, Marco Carvalho, stable

The SDINNOVATION gaming keyboard (USB ID 36ae:feab) stops reporting
input events after its RGB lighting mode is switched about twice.
Disabling USB autosuspend and unbinding the other HID interfaces make
no difference; the issue does not occur on Windows.

HID_QUIRK_ALWAYS_POLL alone resolves it, verified on 7.1.8 via
usbhid.quirks=0x36ae:0xfeab:0x400.

Reported-by: Marco Carvalho <marcocarvalho.web@gmail.com>
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2514627
Cc: stable@vger.kernel.org
Signed-off-by: Junjie Cao <junjie.cao@intel.com>
---
 drivers/hid/hid-ids.h    | 3 +++
 drivers/hid/hid-quirks.c | 1 +
 2 files changed, 4 insertions(+)

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 341bf587863b..10f3a69b82db 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -1295,6 +1295,9 @@
 #define USB_DEVICE_ID_SAMSUNG_WIRELESS_UNIVERSAL_KBD	0xa006
 #define USB_DEVICE_ID_SAMSUNG_WIRELESS_MULTI_HOGP_KBD	0xa064
 
+#define USB_VENDOR_ID_SDINNOVATION		0x36ae
+#define USB_DEVICE_ID_SDINNOVATION_GAMING_KBD	0xfeab
+
 #define USB_VENDOR_ID_SEMICO			0x1a2c
 #define USB_DEVICE_ID_SEMICO_USB_KEYKOARD	0x0023
 #define USB_DEVICE_ID_SEMICO_USB_KEYKOARD2	0x0027
diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
index 8a0b51d47040..c8c6b29fc04d 100644
--- a/drivers/hid/hid-quirks.c
+++ b/drivers/hid/hid-quirks.c
@@ -186,6 +186,7 @@ static const struct hid_device_id hid_quirks[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_X52_2), HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_X52_PRO), HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_X65), HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_SDINNOVATION, USB_DEVICE_ID_SDINNOVATION_GAMING_KBD), HID_QUIRK_ALWAYS_POLL },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SEMICO, USB_DEVICE_ID_SEMICO_USB_KEYKOARD2), HID_QUIRK_NO_INIT_REPORTS },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SEMICO, USB_DEVICE_ID_SEMICO_USB_KEYKOARD), HID_QUIRK_NO_INIT_REPORTS },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SENNHEISER, USB_DEVICE_ID_SENNHEISER_BTD500USB), HID_QUIRK_NOGET },
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] HID: quirks: add ALWAYS_POLL quirk for SDINNOVATION gaming keyboard
  2026-08-24  3:14 [PATCH] HID: quirks: add ALWAYS_POLL quirk for SDINNOVATION gaming keyboard Junjie Cao
@ 2026-09-07  2:44 ` Junjie Cao
  2026-09-07 13:32 ` Benjamin Tissoires
  1 sibling, 0 replies; 3+ messages in thread
From: Junjie Cao @ 2026-09-07  2:44 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires; +Cc: Marco Carvalho, linux-input, linux-kernel

Ping. Still applies to hid.git for-7.3/upstream-fixes and
for-next as of 2026-09-06.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] HID: quirks: add ALWAYS_POLL quirk for SDINNOVATION gaming keyboard
  2026-08-24  3:14 [PATCH] HID: quirks: add ALWAYS_POLL quirk for SDINNOVATION gaming keyboard Junjie Cao
  2026-09-07  2:44 ` Junjie Cao
@ 2026-09-07 13:32 ` Benjamin Tissoires
  1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2026-09-07 13:32 UTC (permalink / raw)
  To: Jiri Kosina, Junjie Cao; +Cc: linux-input, linux-kernel, Marco Carvalho, stable

On Mon, 24 Aug 2026 11:14:19 +0800, Junjie Cao wrote:
> The SDINNOVATION gaming keyboard (USB ID 36ae:feab) stops reporting
> input events after its RGB lighting mode is switched about twice.
> Disabling USB autosuspend and unbinding the other HID interfaces make
> no difference; the issue does not occur on Windows.
> 
> HID_QUIRK_ALWAYS_POLL alone resolves it, verified on 7.1.8 via
> usbhid.quirks=0x36ae:0xfeab:0x400.
> 
> [...]

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-7.3/upstream-fixes), thanks!

[1/1] HID: quirks: add ALWAYS_POLL quirk for SDINNOVATION gaming keyboard
      https://git.kernel.org/hid/hid/c/cdb669a3b8f8

Cheers,
-- 
Benjamin Tissoires <bentiss@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-07 13:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-24  3:14 [PATCH] HID: quirks: add ALWAYS_POLL quirk for SDINNOVATION gaming keyboard Junjie Cao
2026-09-07  2:44 ` Junjie Cao
2026-09-07 13:32 ` Benjamin Tissoires

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox