* [PATCH] linux-2.6.24/drivers/hid/hid-input.c [not found] <alpine.LFD.1.00.0801241506500.15329@hp.linux-foundation.org> @ 2008-01-25 10:11 ` Philipp Matthias Hahn 2008-01-25 10:30 ` Jiri Kosina 0 siblings, 1 reply; 2+ messages in thread From: Philipp Matthias Hahn @ 2008-01-25 10:11 UTC (permalink / raw) To: Jiri Kosina; +Cc: Kernel Mailing List, linux-input In hidinput_configure_usage(device), IS_CHICONY_TACTICAL_PAD(devic) gets passed the 'device' parameter. But that macro still references its parameter by 'device' instead of by its local name 'x'. Signed-off-by: Philipp Matthias Hahn <pmhahn@titan.lahn.de> --- linux/drivers/hid/hid-input.c 2008-01-25 09:57:17.000000000 +0100 +++ linux/drivers/hid/hid-input.c 2008-01-25 10:56:35.835871529 +0100 @@ -87,7 +87,7 @@ #define map_key_clear(c) do { map_key(c); clear_bit(c, bit); } while (0) /* hardware needing special handling due to colliding MSVENDOR page usages */ -#define IS_CHICONY_TACTICAL_PAD(x) (x->vendor == 0x04f2 && device->product == 0x0418) +#define IS_CHICONY_TACTICAL_PAD(x) (x->vendor == 0x04f2 && x->product == 0x0418) #define IS_MS_KB(x) (x->vendor == 0x045e && (x->product == 0x00db || x->product == 0x00f9)) #ifdef CONFIG_USB_HIDINPUT_POWERBOOK -- / / (_)__ __ ____ __ Philipp Hahn / /__/ / _ \/ // /\ \/ / /____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] linux-2.6.24/drivers/hid/hid-input.c 2008-01-25 10:11 ` [PATCH] linux-2.6.24/drivers/hid/hid-input.c Philipp Matthias Hahn @ 2008-01-25 10:30 ` Jiri Kosina 0 siblings, 0 replies; 2+ messages in thread From: Jiri Kosina @ 2008-01-25 10:30 UTC (permalink / raw) To: Philipp Matthias Hahn; +Cc: Kernel Mailing List, linux-input On Fri, 25 Jan 2008, Philipp Matthias Hahn wrote: > In hidinput_configure_usage(device), IS_CHICONY_TACTICAL_PAD(devic) gets > passed the 'device' parameter. But that macro still references its > parameter by 'device' instead of by its local name 'x'. > Signed-off-by: Philipp Matthias Hahn <pmhahn@titan.lahn.de> > > --- linux/drivers/hid/hid-input.c 2008-01-25 09:57:17.000000000 +0100 > +++ linux/drivers/hid/hid-input.c 2008-01-25 10:56:35.835871529 +0100 > @@ -87,7 +87,7 @@ > #define map_key_clear(c) do { map_key(c); clear_bit(c, bit); } while (0) > > /* hardware needing special handling due to colliding MSVENDOR page usages */ > -#define IS_CHICONY_TACTICAL_PAD(x) (x->vendor == 0x04f2 && device->product == 0x0418) > +#define IS_CHICONY_TACTICAL_PAD(x) (x->vendor == 0x04f2 && x->product == 0x0418) > #define IS_MS_KB(x) (x->vendor == 0x045e && (x->product == 0x00db || x->product == 0x00f9)) Hi Philipp, thanks a lot for spotting this. I have however rewritten the ugly handling of hid-input mapping quirks code, so this bug is not present anymore (please see hid-input-quirks branch of my git tree, if interested). Thanks, -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-25 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <alpine.LFD.1.00.0801241506500.15329@hp.linux-foundation.org>
2008-01-25 10:11 ` [PATCH] linux-2.6.24/drivers/hid/hid-input.c Philipp Matthias Hahn
2008-01-25 10:30 ` Jiri Kosina
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox