disconnect in ati_remote2

disconnect in ati_remote2

[Oliver Neukum]

Hi,

this doesn't look quite right. Somebody might use sysfs or usbfs to
disconnect only one interface. In that case you should give up the other
interface, not depending on the first interface being disconnected.

	Regards
		Oliver

static void ati_remote2_disconnect(struct usb_interface *interface)
{
	struct ati_remote2 *ar2;
	struct usb_host_interface *alt = interface->cur_altsetting;

	if (alt->desc.bInterfaceNumber)
		return;

	ar2 = usb_get_intfdata(interface);
	usb_set_intfdata(interface, NULL);

	input_unregister_device(ar2->idev);

	ati_remote2_urb_cleanup(ar2);

	usb_driver_release_interface(&ati_remote2_driver, ar2->intf[1]);

	kfree(ar2);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: disconnect in ati_remote2

[Ville Syrjälä]

On Wed, Jul 02, 2008 at 11:31:43PM +0200, Oliver Neukum wrote:
> Hi,
> 
> this doesn't look quite right. Somebody might use sysfs or usbfs to
> disconnect only one interface. In that case you should give up the other
> interface, not depending on the first interface being disconnected.

I never considered the possibility of disconnecting just one interface.
I'll put it on my TODO list for the future.

-- 
Ville Syrjälä
syrjala-ORSVBvAovxo@public.gmane.org
http://www.sci.fi/~syrjala/
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html