* [PATCH] hid: Add NOGET quirk for Quanta usb optical touchscreen Pixart to prevent timeout @ 2010-03-29 14:20 Anisse Astier 2010-03-29 14:25 ` Jiri Kosina 0 siblings, 1 reply; 4+ messages in thread From: Anisse Astier @ 2010-03-29 14:20 UTC (permalink / raw) To: linux-input; +Cc: Jiri Kosina, Stephane Chatty, Alex Neblett Add the NOGET quirk for the Quanta optical touchscreen present on MSI AE2220, Otherwise, the hid-quanta driver timeouts at load time: drivers/hid/usbhid/hid-core.c: usb_submit_urb(ctrl) failed quanta-touch 0003:0408:3001.0003: timeout initializing reports input: PixArt Imaging Inc. Optical Touch Screen as /class/input/input7 quanta-touch 0003:0408:3001.0003: input: USB HID v1.10 Device [PixArt Imaging Inc. Optical Touch Screen] on usb-0000:00:06.0-2/input0 Signed-off-by: Anisse Astier <anisse@astier.eu> --- drivers/hid/usbhid/hid-quirks.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c index 928943c..e71e005 100644 --- a/drivers/hid/usbhid/hid-quirks.c +++ b/drivers/hid/usbhid/hid-quirks.c @@ -60,6 +60,7 @@ static const struct hid_blacklist { { USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET }, { USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET }, { USB_VENDOR_ID_PRODIGE, USB_DEVICE_ID_PRODIGE_CORDLESS, HID_QUIRK_NOGET }, + { USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN, HID_QUIRK_NOGET }, { USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET }, { USB_VENDOR_ID_TURBOX, USB_DEVICE_ID_TURBOX_KEYBOARD, HID_QUIRK_NOGET }, { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_PF1209, HID_QUIRK_MULTI_INPUT }, -- 1.6.5.7 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hid: Add NOGET quirk for Quanta usb optical touchscreen Pixart to prevent timeout 2010-03-29 14:20 [PATCH] hid: Add NOGET quirk for Quanta usb optical touchscreen Pixart to prevent timeout Anisse Astier @ 2010-03-29 14:25 ` Jiri Kosina 2010-03-29 15:03 ` Anisse Astier 0 siblings, 1 reply; 4+ messages in thread From: Jiri Kosina @ 2010-03-29 14:25 UTC (permalink / raw) To: Anisse Astier; +Cc: linux-input, Stephane Chatty, Alex Neblett On Mon, 29 Mar 2010, Anisse Astier wrote: > > Add the NOGET quirk for the Quanta optical touchscreen present on MSI AE2220, > Otherwise, the hid-quanta driver timeouts at load time: > > drivers/hid/usbhid/hid-core.c: usb_submit_urb(ctrl) failed > quanta-touch 0003:0408:3001.0003: timeout initializing reports > input: PixArt Imaging Inc. Optical Touch Screen as /class/input/input7 > quanta-touch 0003:0408:3001.0003: input: USB HID v1.10 Device [PixArt Imaging Inc. Optical Touch Screen] on usb-0000:00:06.0-2/input0 > > Signed-off-by: Anisse Astier <anisse@astier.eu> > --- > drivers/hid/usbhid/hid-quirks.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c > index 928943c..e71e005 100644 > --- a/drivers/hid/usbhid/hid-quirks.c > +++ b/drivers/hid/usbhid/hid-quirks.c > @@ -60,6 +60,7 @@ static const struct hid_blacklist { > { USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET }, > { USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET }, > { USB_VENDOR_ID_PRODIGE, USB_DEVICE_ID_PRODIGE_CORDLESS, HID_QUIRK_NOGET }, > + { USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN, HID_QUIRK_NOGET }, > { USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET }, > { USB_VENDOR_ID_TURBOX, USB_DEVICE_ID_TURBOX_KEYBOARD, HID_QUIRK_NOGET }, > { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_PF1209, HID_QUIRK_MULTI_INPUT }, I have applied the patch, but I wonder why Alex (who added this device ID initially) wasn't seeing it? Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hid: Add NOGET quirk for Quanta usb optical touchscreen Pixart to prevent timeout 2010-03-29 14:25 ` Jiri Kosina @ 2010-03-29 15:03 ` Anisse Astier 2010-03-30 1:09 ` Alex Neblett 0 siblings, 1 reply; 4+ messages in thread From: Anisse Astier @ 2010-03-29 15:03 UTC (permalink / raw) To: Jiri Kosina; +Cc: linux-input, Stephane Chatty, Alex Neblett On Mon, 29 Mar 2010 16:25:31 +0200 (CEST), Jiri Kosina <jkosina@suse.cz> wrote : > On Mon, 29 Mar 2010, Anisse Astier wrote: > > > > > Add the NOGET quirk for the Quanta optical touchscreen present on MSI AE2220, > > Otherwise, the hid-quanta driver timeouts at load time: > > > > drivers/hid/usbhid/hid-core.c: usb_submit_urb(ctrl) failed > > quanta-touch 0003:0408:3001.0003: timeout initializing reports > > input: PixArt Imaging Inc. Optical Touch Screen as /class/input/input7 > > quanta-touch 0003:0408:3001.0003: input: USB HID v1.10 Device [PixArt Imaging Inc. Optical Touch Screen] on usb-0000:00:06.0-2/input0 > > > > Signed-off-by: Anisse Astier <anisse@astier.eu> > > --- > > drivers/hid/usbhid/hid-quirks.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c > > index 928943c..e71e005 100644 > > --- a/drivers/hid/usbhid/hid-quirks.c > > +++ b/drivers/hid/usbhid/hid-quirks.c > > @@ -60,6 +60,7 @@ static const struct hid_blacklist { > > { USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET }, > > { USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET }, > > { USB_VENDOR_ID_PRODIGE, USB_DEVICE_ID_PRODIGE_CORDLESS, HID_QUIRK_NOGET }, > > + { USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN, HID_QUIRK_NOGET }, > > { USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET }, > > { USB_VENDOR_ID_TURBOX, USB_DEVICE_ID_TURBOX_KEYBOARD, HID_QUIRK_NOGET }, > > { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_PF1209, HID_QUIRK_MULTI_INPUT }, > > I have applied the patch, but I wonder why Alex (who added this device ID > initially) wasn't seeing it? Good question indeed, that's why I included him in the Cc. I just assumed that he saw it but didn't bother, since this problem is not critical: the driver just works correctly after the timeout, and we can receive the touchscreen events. Maybe I'm wrong, Alex? Regards, Anisse ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hid: Add NOGET quirk for Quanta usb optical touchscreen Pixart to prevent timeout 2010-03-29 15:03 ` Anisse Astier @ 2010-03-30 1:09 ` Alex Neblett 0 siblings, 0 replies; 4+ messages in thread From: Alex Neblett @ 2010-03-30 1:09 UTC (permalink / raw) To: Anisse Astier, Jiri Kosina; +Cc: linux-input, Stephane Chatty Anisse, Sorry for being out of pocket. I had some health issues that I had to address. The answer is that I have never encountered it. I would assume that it might be related to usb devices present, bios version and/or kernel configuration. However, I am not surprised by your findings and appreciate your addressing your findings. My son has an msi gaming laptop. Until we updated the bios and the camera bios to the latest version, he was unable to boot kernels > 2.6.32rc2 without the dreaded read/64 error -110. Even with the updates, restart produces the same error. As a result, he now does a shutdown and then powers up to restart... I think that it is safe to assume that some users would have fared as I have and some would have faired as you have. Thanks for the great work. Cheers, Alex ----- Original Message ---- From: Anisse Astier <anisse@astier.eu> To: Jiri Kosina <jkosina@suse.cz> Cc: linux-input@vger.kernel.org; Stephane Chatty <chatty@lii-enac.fr>; Alex Neblett <alexneblett01@yahoo.com> Sent: Mon, March 29, 2010 10:03:53 AM Subject: Re: [PATCH] hid: Add NOGET quirk for Quanta usb optical touchscreen Pixart to prevent timeout On Mon, 29 Mar 2010 16:25:31 +0200 (CEST), Jiri Kosina <jkosina@suse.cz> wrote : > On Mon, 29 Mar 2010, Anisse Astier wrote: > > > > > Add the NOGET quirk for the Quanta optical touchscreen present on MSI AE2220, > > Otherwise, the hid-quanta driver timeouts at load time: > > > > drivers/hid/usbhid/hid-core.c: usb_submit_urb(ctrl) failed > > quanta-touch 0003:0408:3001.0003: timeout initializing reports > > input: PixArt Imaging Inc. Optical Touch Screen as /class/input/input7 > > quanta-touch 0003:0408:3001.0003: input: USB HID v1.10 Device [PixArt Imaging Inc. Optical Touch Screen] on usb-0000:00:06.0-2/input0 > > > > Signed-off-by: Anisse Astier <anisse@astier.eu> > > --- > > drivers/hid/usbhid/hid-quirks.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c > > index 928943c..e71e005 100644 > > --- a/drivers/hid/usbhid/hid-quirks.c > > +++ b/drivers/hid/usbhid/hid-quirks.c > > @@ -60,6 +60,7 @@ static const struct hid_blacklist { > > { USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET }, > > { USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET }, > > { USB_VENDOR_ID_PRODIGE, USB_DEVICE_ID_PRODIGE_CORDLESS, HID_QUIRK_NOGET }, > > + { USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN, HID_QUIRK_NOGET }, > > { USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET }, > > { USB_VENDOR_ID_TURBOX, USB_DEVICE_ID_TURBOX_KEYBOARD, HID_QUIRK_NOGET }, > > { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_PF1209, HID_QUIRK_MULTI_INPUT }, > > I have applied the patch, but I wonder why Alex (who added this device ID > initially) wasn't seeing it? Good question indeed, that's why I included him in the Cc. I just assumed that he saw it but didn't bother, since this problem is not critical: the driver just works correctly after the timeout, and we can receive the touchscreen events. Maybe I'm wrong, Alex? Regards, Anisse ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-30 1:16 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-03-29 14:20 [PATCH] hid: Add NOGET quirk for Quanta usb optical touchscreen Pixart to prevent timeout Anisse Astier 2010-03-29 14:25 ` Jiri Kosina 2010-03-29 15:03 ` Anisse Astier 2010-03-30 1:09 ` Alex Neblett
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox