From: Dan Carpenter <error27@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: [patch 2/2 -next] hid-lg4ff: add a kfree() to an error path
Date: Thu, 18 Aug 2011 16:43:43 +0300 [thread overview]
Message-ID: <20110818134343.GB21927@shale.localdomain> (raw)
There is a small rare potential memory leak here. But it's easy to
fix.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
index dc38c2d..2b4bbcb 100644
--- a/drivers/hid/hid-lg4ff.c
+++ b/drivers/hid/hid-lg4ff.c
@@ -438,6 +438,7 @@ int lg4ff_init(struct hid_device *hid)
entry->device_id = (char *)kzalloc(strlen((&hid->dev)->kobj.name) + 1, GFP_KERNEL);
if (!entry->device_id) {
hid_err(hid, "Cannot set device_id, insufficient memory.\n");
+ kfree(entry);
return -ENOMEM;
}
strcpy(entry->device_id, (&hid->dev)->kobj.name);
next reply other threads:[~2011-08-18 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 13:43 Dan Carpenter [this message]
[not found] ` <CAMvewQJigdY81gPrpndqV=FxN+cEeif4NkzSbBZKCO4z3guQew@mail.gmail.com>
2011-08-18 16:24 ` [patch 2/2 -next] hid-lg4ff: add a kfree() to an error path Dan Carpenter
[not found] ` <4E4D2E4A.3020205@bfs.de>
2011-08-19 8:00 ` [patch 2/2 -next v2] " Dan Carpenter
2011-08-23 8:46 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110818134343.GB21927@shale.localdomain \
--to=error27@gmail.com \
--cc=jkosina@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox