From: Dan Carpenter <error27@gmail.com>
To: Zic Rim <zicrim@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2 -next] hid-lg4ff: add a kfree() to an error path
Date: Thu, 18 Aug 2011 19:24:47 +0300 [thread overview]
Message-ID: <20110818162447.GE21927@shale.localdomain> (raw)
In-Reply-To: <CAMvewQJigdY81gPrpndqV=FxN+cEeif4NkzSbBZKCO4z3guQew@mail.gmail.com>
On Thu, Aug 18, 2011 at 07:59:32PM +0530, Zic Rim wrote:
> There is no leak here. If kzalloc fails , it means memory is not allocated.
> It is wrong to free something that is not allocated .
No. The entry allocation succeeded and the entry->device_id
allocation failed. Look again.
regards,
dan carpenter
next prev parent reply other threads:[~2011-08-18 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 13:43 [patch 2/2 -next] hid-lg4ff: add a kfree() to an error path Dan Carpenter
[not found] ` <CAMvewQJigdY81gPrpndqV=FxN+cEeif4NkzSbBZKCO4z3guQew@mail.gmail.com>
2011-08-18 16:24 ` Dan Carpenter [this message]
[not found] ` <4E4D2E4A.3020205@bfs.de>
2011-08-19 8:00 ` [patch 2/2 -next v2] " Dan Carpenter
2011-08-23 8:46 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110818162447.GE21927@shale.localdomain \
--to=error27@gmail.com \
--cc=jkosina@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=zicrim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox